HomePhabricator

Revert rL370996 from llvm/trunk: [AArch64][GlobalISel] Teach…

Authored by RKSimon on Thu, Sep 5, 3:38 AM.

Description

Revert rL370996 from llvm/trunk: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls

This adds support for basic sibling call lowering in AArch64. The intent here is
to only handle tail calls which do not change the ABI (hence, sibling calls.)

At this point, it is very restricted. It does not handle

  • Vararg calls.
  • Calls with outgoing arguments.
  • Calls whose calling conventions differ from the caller's calling convention.
  • Tail/sibling calls with BTI enabled.

This patch adds

  • AArch64CallLowering::isEligibleForTailCallOptimization, which is equivalent to the same function in AArch64ISelLowering.cpp (albeit with the restrictions above.)
  • mayTailCallThisCC and canGuaranteeTCO, which are identical to those in AArch64ISelLowering.cpp.
  • getCallOpcode, which is exactly what it sounds like.

Tail/sibling calls are lowered by checking if they pass target-independent tail
call positioning checks, and checking if they satisfy
isEligibleForTailCallOptimization. If they do, then a tail call instruction is
emitted instead of a normal call. If we have a sibling call (which is always the
case in this patch), then we do not emit any stack adjustment operations. When
we go to lower a return, we check if we've already emitted a tail call. If so,
then we skip the return lowering.

For testing, this patch

  • Adds call-translator-tail-call.ll to test which tail calls we currently lower, which ones we don't, and which ones we shouldn't.
  • Updates branch-target-enforcement-indirect-calls.ll to show that we fall back as expected.

Differential Revision: https://reviews.llvm.org/D67189
........
This fails on EXPENSIVE_CHECKS builds due to a -verify-machineinstrs test failure in CodeGen/AArch64/dllimport.ll

llvm-svn: 371051