HomePhabricator

MSan: handle llvm.lifetime.start intrinsic

Authored by glider on Apr 30 2019, 1:35 AM.

Description

MSan: handle llvm.lifetime.start intrinsic

Summary:
When a variable goes into scope several times within a single function
or when two variables from different scopes share a stack slot it may
be incorrect to poison such scoped locals at the beginning of the
function.
In the former case it may lead to false negatives (see
https://github.com/google/sanitizers/issues/590), in the latter - to
incorrect reports (because only one origin remains on the stack).

If Clang emits lifetime intrinsics for such scoped variables we insert
code poisoning them after each call to llvm.lifetime.start().
If for a certain intrinsic we fail to find a corresponding alloca, we
fall back to poisoning allocas for the whole function, as it's now
impossible to tell which alloca was missed.

The new instrumentation may slow down hot loops containing local
variables with lifetime intrinsics, so we allow disabling it with
-mllvm -msan-handle-lifetime-intrinsics=false.

Reviewers: eugenis, pcc

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60617

llvm-svn: 359536

Details

Committed
gliderApr 30 2019, 1:35 AM
Differential Revision
D60617: MSan: handle llvm.lifetime.start intrinsic
Parents
rGa475da36eb50: [DebugInfo] DW_OP_deref_size in PrologEpilogInserter.
Branches
Unknown
Tags
Unknown