HomePhabricator

[perf-training] Ignore ' (in-process)' prefix from -###

Authored by thegameg on Jan 17 2020, 9:36 AM.

Description

[perf-training] Ignore ' (in-process)' prefix from -###

After D69825, the output of clang -### when running in process can be
prefixed by ' (in-process)'. Skip it.

Details

Committed
thegamegJan 17 2020, 9:38 AM
Parents
rG12e479475a89: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot
Branches
Unknown
Tags
Unknown

Event Timeline

Hi,

It looks like recent change did add a line-break after " (in-process)", so I guess this should be reverted, and instead a patch more or less like this should make it work again:

--- a/clang/utils/perf-training/perf-helper.py
+++ b/clang/utils/perf-training/perf-helper.py
@@ -125,6 +125,7 @@
           ln.startswith('Thread model:') or
           ln.startswith('InstalledDir:') or
           ln.startswith('LLVM Profile Note') or
+          ln.startswith(' (in-process)') or
           ' version ' in ln):
           continue
       cc_commands.append(ln)

Cheers,
Romain

Hi,

It looks like recent change did add a line-break after " (in-process)", so I guess this should be reverted, and instead a patch more or less like this should make it work again:

--- a/clang/utils/perf-training/perf-helper.py
+++ b/clang/utils/perf-training/perf-helper.py
@@ -125,6 +125,7 @@
           ln.startswith('Thread model:') or
           ln.startswith('InstalledDir:') or
           ln.startswith('LLVM Profile Note') or
+          ln.startswith(' (in-process)') or
           ' version ' in ln):
           continue
       cc_commands.append(ln)

Cheers,
Romain

Thanks Romain! 0f34ea5dc3cb [perf-training] Update ' (in-process)' prefix handling