HomePhabricator

Partial fix for TestConflictingSymbol.py on Windows

Authored by amccarth on Feb 26 2018, 1:22 PM.

Description

Partial fix for TestConflictingSymbol.py on Windows

Without this fix, the test ERRORs because the link of the inferior fails. This
patch adds the LLDB_TEST_API macro where needed and uses the new -2 magic
value for num_expected_locations to account for lazy-loading of module symbols
on Windows.

With this fix, the test itself still fails: conflicting_symbol isn't in the
debug info nor the export table, and Windows binaries don't have an equivalent
of the ELF .symtab. We need to understand why the test works to keep the
symbol out of the debug info. In the mean time, having the test fail at this
point is a better indication of the remaining problem than a build error.

Differential Revision: https://reviews.llvm.org/D43688

llvm-svn: 326130

Details

Committed
amccarthFeb 26 2018, 1:22 PM
Differential Revision
D43688: Partial fix for TestConflictingSymbol.py on Windows
Parents
rGa04793eb933b: [DebugInfo] Remove target-specific instructions in test
Branches
Unknown
Tags
Unknown