HomePhabricator

SafeStack: Fix flaky test (PR39001)

Authored by vlad.tsyrklevich on Sep 21 2018, 12:02 PM.

Description

SafeStack: Fix flaky test (PR39001)

Summary:
pthread_join() can return before a thread finishes exit()ing in the
kernel and a subsequent tgkill() can report the thread still alive.
Update the pthread-cleanup.c test to sleep and retry if it hits this
possible flake.

Thanks to Jeremy Morse for reporting.

Reviewers: jmorse, eugenis, vitalybuka

Reviewed By: jmorse, vitalybuka

Subscribers: delcypher, jfb, llvm-commits, #sanitizers, kcc

Differential Revision: https://reviews.llvm.org/D52330

llvm-svn: 342763

Details

Committed
vlad.tsyrklevichSep 21 2018, 12:02 PM
Reviewer
jmorse
Differential Revision
D52330: SafeStack: Fix flaky test (PR39001)
Parents
rG7aa9e7bc5739: Move architecture-specific address adjustment to architecture plugins
Branches
Unknown
Tags
Unknown