HomePhabricator

[clang-tidy] Check for sizeof that call functions

Description

[clang-tidy] Check for sizeof that call functions

Summary:
A common mistake that I have found in our codebase is calling a function to get an integer or enum that represents the type such as:

int numBytes = numElements * sizeof(x.GetType());

So this extends the sizeof check to check for these cases. There is also a WarnOnSizeOfCall option so it can be disabled.

Patch by Paul Fultz II!

Reviewers: hokein, alexfh, aaron.ballman, ilya-biryukov

Reviewed By: alexfh

Subscribers: lebedev.ri, xazax.hun, jkorous-apple, cfe-commits

Tags: #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D44231

Details

Committed
hokeinApr 3 2018, 8:10 AM
Reviewer
alexfh
Differential Revision
D44231: [clang-tidy] Check for sizeof that call functions
Branches
Unknown
Tags
Unknown