[clang-tidy] Check for sizeof that call functions
A common mistake that I have found in our codebase is calling a function to get an integer or enum that represents the type such as:
int numBytes = numElements * sizeof(x.GetType());
So this extends the sizeof check to check for these cases. There is also a WarnOnSizeOfCall option so it can be disabled.
Patch by Paul Fultz II!
Reviewers: hokein, alexfh, aaron.ballman, ilya-biryukov
Reviewed By: alexfh
Subscribers: lebedev.ri, xazax.hun, jkorous-apple, cfe-commits
Differential Revision: https://reviews.llvm.org/D44231