HomePhabricator

[clang-tidy] Catch trivially true statements like a != 1 || a != 3

Description

[clang-tidy] Catch trivially true statements like a != 1 || a != 3

Catch trivially true statements of the form a != 1 || a != 3. Statements like
these are likely errors. They are particularly easy to miss when handling enums:

enum State {
RUNNING,
STOPPED,
STARTING,
ENDING
}

...
if (state != RUNNING || state != STARTING)
...

Patch by Blaise Watson!

Differential revision: https://reviews.llvm.org/D29858

Details

Committed
alexfhMar 23 2017, 8:13 AM
Differential Revision
D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3
Branches
Unknown
Tags
Unknown