HomePhabricator

[analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Description

[analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Summary:
A condition could be a multi-line expression where we create the highlight
in separated chunks. PathDiagnosticPopUpPiece is not made for that purpose,
it cannot be added to multiple lines because we have only one ending part
which contains all the notes. So that it cannot have multiple endings and
therefore this patch narrows down the ranges of the highlight to the given
interesting variable of the condition. It prevents HTML-breaking injections.

Reviewed By: NoQ

Differential Revision: https://reviews.llvm.org/D65663

Details

Committed
CharussoAug 8 2019, 7:20 PM
Reviewer
NoQ
Differential Revision
D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces
Parents
rC368381: [clang-scan-deps] Add minimizer support for C++20 modules.
Branches
Unknown
Tags
Unknown