HomePhabricator

[Driver] Verify GCCInstallation is valid

Description

[Driver] Verify GCCInstallation is valid

Summary:
Values returned by GCCInstallation.getParentLibPath() and
GCCInstallation.getTriple() are not valid unless
GCCInstallation.isValid() returns true. This has previously been
ignored, and the former two values were used without checking whether
GCCInstallation is valid. This led to the bad path "/../bin" being added
to the list of program paths.

author: danielmentz "Daniel Mentz <danielmentz@google.com>"

Reviewers: #clang, tstellar, srhines

Reviewed By: srhines

Subscribers: danielmentz, ormris, nickdesaulniers, srhines, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57930

Details

Committed
nickdesaulniersMay 21 2019, 2:21 PM
Reviewer
srhines
Differential Revision
D57930: [Driver] Verify GCCInstallation is valid
Branches
Unknown
Tags
Unknown