HomePhabricator

[OpenMP][bugfix] Add missing math functions variants for log and abs.
Concern RaisedrC361066

Description

[OpenMP][bugfix] Add missing math functions variants for log and abs.

Summary: When including the random header in C++, some of the math functions it relies on are not present in the CUDA headers. We include this variants in this case.

Reviewers: jdoerfert, hfinkel, tra, caomhin

Reviewed By: tra

Subscribers: efriedma, guansong, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D62046

Details

Auditors
JonChesterfield
Committed
gberceaMay 17 2019, 12:15 PM
Reviewer
tra
Differential Revision
D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.
Parents
rC361065: Add more tests for AST JSON output; NFC.
Branches
Unknown
Tags
Unknown

Event Timeline

JonChesterfield raised a concern with this commit.Nov 4 2019, 2:35 PM
JonChesterfield added a subscriber: JonChesterfield.

I think this is broken. Specifically, the abs definition conflicts with the one in libstdc++ (at least version 7.2 and 7.4). Bug raised as https://bugs.llvm.org/show_bug.cgi?id=42972, @ikitayama emailed openmp-dev to raise the concern.

This commit now has outstanding concerns.Nov 4 2019, 2:35 PM