HomePhabricator

[analyzer] Remove the default value arg from getChecker*Option

Description

[analyzer] Remove the default value arg from getChecker*Option

Since D57922, the config table contains every checker option, and it's default
value, so having it as an argument for getChecker*Option is redundant.

By the time any of the getChecker*Option function is called, we verified the
value in CheckerRegistry (after D57860), so we can confidently assert here, as
any irregularities detected at this point must be a programmer error. However,
in compatibility mode, verification won't happen, so the default value must be
restored.

This implies something else, other than adding removing one more potential point
of failure -- debug.ConfigDumper will always contain valid values for
checker/package options!

Differential Revision: https://reviews.llvm.org/D59195

Details

Committed
SzelethusMay 17 2019, 8:52 AM
Differential Revision
D59195: [analyzer] Remove the default value arg from getChecker*Option
Branches
Unknown
Tags
Unknown