HomePhabricator

[clang][ASTContext] Call setAttached for comments attached to a declaration

Description

[clang][ASTContext] Call setAttached for comments attached to a declaration

This is a bug affecting performance when compiling with -Wdocumentation.

In Sema::ActOnDocumentable we're checking whether there are any comments unattached to declaration at the end of comment list whenever we encounter new documentable declaration.
Since this property of RawComment was never set we were trying to find comments every time and that involves at least a couple expensive SourceLocation decompositions.

Differential Revision: https://reviews.llvm.org/D61538

Details

Committed
jkorousMay 13 2019, 10:52 AM
Differential Revision
D61538: [clang][ASTContext] Call setAttached for comments attached to a declaration
Branches
Unknown
Tags
Unknown