HomePhabricator

[Lookup] Invisible decls should not be ambiguous when renaming.

Description

[Lookup] Invisible decls should not be ambiguous when renaming.

Summary:
For example, a renamed type in a header file can conflict with declaration in
a random file that includes the header, but we should not consider the decl ambiguous if
it's not visible at the rename location. This improves consistency of generated replacements
when header file is included in different TUs.

Reviewers: hokein

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D60257

Details

Committed
ioericApr 15 2019, 1:46 AM
Differential Revision
D60257: [Lookup] Invisible decls should not be ambiguous when renaming.
Branches
Unknown
Tags
Unknown