HomePhabricator

Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes."

Description

Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes."

Test does not pass on Windows

Details

Committed
rnkFeb 25 2019, 6:22 PM
Parents
rC354838: [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword
Branches
Unknown
Tags
Unknown

Event Timeline

This is a destructive revert commit which does not simply revert the mentioned r354832 commit. Besides reverting that commit, it does remove a bunch of unrelated test files! E.g. cfe/trunk/test/ASTMerge/var/Inputs/var1.c. Could you please investigate and restore the unrelated test files?

rnk added a comment.May 14 2019, 1:07 PM

This is a destructive revert commit which does not simply revert the mentioned r354832 commit. Besides reverting that commit, it does remove a bunch of unrelated test files! E.g. cfe/trunk/test/ASTMerge/var/Inputs/var1.c. Could you please investigate and restore the unrelated test files?

Sorry about that! I added the files back in rC360699, but some of the tests now fail, so I XFAIL'd them and applied the fixes separately in rC360701 (and forgot one change, which became rC360705). It looks like you made the behavior change in rC357394 that would've caused these tests to start failing, so you might want to take a look. It's also worth pointing out that clang/test/ASTMerge/class-template-partial-specialization/test.cpp crashes clang right now. It may have been a regression from April, but I couldn't say for sure.

I might try to reproduce the git-llvm bug that caused the file deletion if I have time, but more likely I won't get to it, and I'll just have to be more careful when reverting things in the future.

This is a destructive revert commit which does not simply revert the mentioned r354832 commit. Besides reverting that commit, it does remove a bunch of unrelated test files! E.g. cfe/trunk/test/ASTMerge/var/Inputs/var1.c. Could you please investigate and restore the unrelated test files?

Sorry about that! I added the files back in rC360699, but some of the tests now fail, so I XFAIL'd them and applied the fixes separately in rC360701 (and forgot one change, which became rC360705). It looks like you made the behavior change in rC357394 that would've caused these tests to start failing, so you might want to take a look. It's also worth pointing out that clang/test/ASTMerge/class-template-partial-specialization/test.cpp crashes clang right now. It may have been a regression from April, but I couldn't say for sure.

I might try to reproduce the git-llvm bug that caused the file deletion if I have time, but more likely I won't get to it, and I'll just have to be more careful when reverting things in the future.

Okay, no problem, thank you for taking care of this. I'll investigate further the XFAIL'd test and the assertion.