HomePhabricator

Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor

Description

Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor

-Wdelete-non-virtual-dtor previously controlled two diagnostics: 1)
calling a non-virtual dtor from an abstract class, and 2) calling a
non-virtual dtor from a polymorphic class. 1) is a lot more severe
than 2), since 1) is a guaranteed crash, but 2) is just "code smell".
Previously, projects compiled with -Wall -Wno-delete-non-virtual-dtor,
which is somewhat reasonable, silently crashed on 1).

rdar://40380564

Differential revision: https://reviews.llvm.org/D56405

Details

Committed
epilkJan 7 2019, 4:21 PM
Differential Revision
D56405: Split -Wdelete-non-virtual-dtor into two groups
Branches
Unknown
Tags
Unknown