HomePhabricator

clang: Allow ifunc resolvers to accept arguments

Description

clang: Allow ifunc resolvers to accept arguments

When ifunc support was added to Clang (r265917) it did not allow
resolvers to take function arguments. This was based on GCC's
documentation, which states resolvers return a pointer and take no
arguments.

However, GCC actually allows resolvers to take arguments, and glibc (on
non-x86 platforms) and FreeBSD (on x86 and arm64) pass some CPU
identification information as arguments to ifunc resolvers. I believe
GCC's documentation is simply incorrect / out-of-date.

FreeBSD already removed the prohibition in their in-tree Clang copy.

Differential Revision: https://reviews.llvm.org/D52703

Details

Committed
emasteOct 9 2018, 5:34 PM
Differential Revision
D52703: Allow ifunc resolvers to accept arguments
Branches
Unknown
Tags
Unknown