HomePhabricator

[clang-format] Don't insert space between r_paren and 'new' in ObjC decl

Description

[clang-format] Don't insert space between r_paren and 'new' in ObjC decl

Summary:
Previously, clang-format would insert a space between
the closing parenthesis and 'new' in the following valid Objective-C
declaration:

+ (instancetype)new;

This was because 'new' is treated as a keyword, not an identifier.

TokenAnnotator::spaceRequiredBefore() already handled the case where
r_paren came before an identifier, so this diff extends it to
handle r_paren before 'new'.

Test Plan: New tests added. Ran tests with:

% make -j12 FormatTests && ./tools/clang/unittests/Format/FormatTests

Reviewers: djasper, jolesiak, stephanemoore

Reviewed By: djasper, jolesiak, stephanemoore

Subscribers: stephanemoore, klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D44692

Details

Committed
benhamiltonMar 21 2018, 8:23 PM
Reviewer
djasper
Differential Revision
D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl
Parents
rC328173: Improve -Winfinite-recursion
Branches
Unknown
Tags
Unknown