HomePhabricator

Again reverting an attempt to convert the DeclSpec enums into scoped enums.

Description

Again reverting an attempt to convert the DeclSpec enums into scoped enums.

  • reverts r321622, r321625, and r321626.
  • the use of bit-fields is still resulting in warnings - even though we can use static-asserts to harden the code and ensure the bit-fields are wide enough. The bots still complain of warnings being seen.
  • to silence the warnings requires specifying the bit-fields with the underlying enum type (as opposed to the enum type itself), which then requires lots of unnecessary static casts of each enumerator within DeclSpec to the underlying-type, which even though could be seen as implementation details, it does hamper readability - and given the additional litterings, makes me question the value of the change.

So in short - I give up (for now at least).

Sorry about the noise.

Details

Committed
faisalvJan 1 2018, 10:23 AM
Branches
Unknown
Tags
Unknown