HomePhabricator

[Sema] Fix a crash-on-invalid when a template parameter list has a class

Description

[Sema] Fix a crash-on-invalid when a template parameter list has a class
definition or non-reference class type.

The crash occurs when there is a template parameter list in a class that
is missing the closing angle bracket followed by a definition of a
struct. For example:

class C0 {
public:

template<typename T, typename T1 = T // missing closing angle bracket
struct S0 {};

C0() : m(new S0<int>) {}
S0<int> *m;

};

This happens because the parsed struct is added to the scope of the
enclosing class without having its access specifier set, which results
in an assertion failure in SemaAccess.cpp later.

This commit fixes the crash by adding the parsed struct to the enclosing
file scope and marking structs as invalid if they are defined in
template parameter lists.

rdar://problem/31783961
rdar://problem/19570630

Differential Revision: https://reviews.llvm.org/D33606

Details

Committed
ahatanakJun 26 2017, 11:46 AM
Differential Revision
D33606: [Sema] Fix a crash-on-invalid when a template parameter list has a class definition or non-reference class type
Branches
Unknown
Tags
Unknown