HomePhabricator

[X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic…

Description

[X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

D20859 and D20860 attempted to replace the SSE (V)CVTTPS2DQ and VCVTTPD2DQ truncating conversions with generic IR instead.

It turns out that the behaviour of these intrinsics is different enough from generic IR that this will cause problems, INF/NAN/out of range values are guaranteed to result in a 0x80000000 value - which plays havoc with constant folding which converts them to either zero or UNDEF. This is also an issue with the scalar implementations (which were already generic IR and what I was trying to match).

This patch changes both scalar and packed versions back to using x86-specific builtins.

It also deals with the other scalar conversion cases that are runtime rounding mode dependent and can have similar issues with constant folding.

Differential Revision: https://reviews.llvm.org/D22105

Details

Committed
RKSimonJul 20 2016, 3:18 AM
Differential Revision
D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR
Branches
Unknown
Tags
Unknown