Page MenuHomePhabricator

debug-infoProject
ActivePublic

Recent Activity

Today

markus added inline comments to D56587: Introduce DW_OP_LLVM_convert.
Tue, Feb 19, 2:30 AM · debug-info
markus added inline comments to D56587: Introduce DW_OP_LLVM_convert.
Tue, Feb 19, 1:38 AM · debug-info
djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Tue, Feb 19, 12:15 AM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.
  • Adjust documentation
Tue, Feb 19, 12:05 AM · debug-info

Yesterday

aprantl added inline comments to D56587: Introduce DW_OP_LLVM_convert.
Mon, Feb 18, 10:13 AM · debug-info
aprantl accepted D58224: [DebugInfo] Adjust fragment offset for big endian targets when splitting alloca in SROA.

LGTM with update to testcase.

Mon, Feb 18, 9:47 AM · debug-info, Restricted Project
aprantl added inline comments to D58034: [IR/DIVar] Add flag for params that have unchanged values.
Mon, Feb 18, 9:22 AM · debug-info
alexey.lapshin updated the diff for D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

deleted LLD test as it was requested. Modified llvm-objdump test to not to use clang.

Mon, Feb 18, 6:17 AM · debug-info, Restricted Project
dstenb added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Feb 18, 5:08 AM · debug-info
markus updated the diff for D56587: Introduce DW_OP_LLVM_convert.
  • Did some cleanup
  • Added tests
  • Emit DW_OP_convert for Dwarf5
  • Emit legacy shift and mask expression for Dwarf4 and lower
  • Added llc option -generate-typed-dwarf5-expr to force emission regardless of targeted Dwarf version
Mon, Feb 18, 2:35 AM · debug-info
Ka-Ka added inline comments to D58224: [DebugInfo] Adjust fragment offset for big endian targets when splitting alloca in SROA.
Mon, Feb 18, 2:16 AM · debug-info, Restricted Project
alexey.lapshin added a reviewer for D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces.: dblaikie.
Mon, Feb 18, 2:03 AM · debug-info, Restricted Project

Sun, Feb 17

djtodoro updated the diff for D58044: [DwarfDebug] Dump call site debug info into DWARF.
  • Change a comment for isDescribedByReg()
  • Remove a dead code
Sun, Feb 17, 10:45 PM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.
  • Use isEntryValue() from DIExpression
Sun, Feb 17, 10:45 PM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

@aprantl I just updated the diff with documentation. Please let me know what do you think.

Sun, Feb 17, 10:40 PM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.
  • Add documentation for the flag
Sun, Feb 17, 10:36 PM · debug-info
grimar added a comment to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

Ok. I debugged this a little and think that:

Sun, Feb 17, 6:07 AM · debug-info, Restricted Project

Fri, Feb 15

alexey.lapshin added a comment to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

George, I added test for LLD. But.... It already pass for LLD without this fix. The reason for that is following quickfix :

Fri, Feb 15, 1:51 PM · debug-info, Restricted Project
alexey.lapshin updated the diff for D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

added test for LLD. did all what was requested in comments.

Fri, Feb 15, 1:41 PM · debug-info, Restricted Project
aprantl added inline comments to D58224: [DebugInfo] Adjust fragment offset for big endian targets when splitting alloca in SROA.
Fri, Feb 15, 8:25 AM · debug-info, Restricted Project
markus updated the diff for D56587: Introduce DW_OP_LLVM_convert.

Addressed the inlined location expressions.

Fri, Feb 15, 7:36 AM · debug-info
Ka-Ka added inline comments to D58224: [DebugInfo] Adjust fragment offset for big endian targets when splitting alloca in SROA.
Fri, Feb 15, 4:58 AM · debug-info, Restricted Project

Thu, Feb 14

aprantl added inline comments to D58224: [DebugInfo] Adjust fragment offset for big endian targets when splitting alloca in SROA.
Thu, Feb 14, 8:35 AM · debug-info, Restricted Project
alexey.lapshin updated the diff for D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

Addressed most of the comments. test for LLD is in progress yet.

Thu, Feb 14, 7:52 AM · debug-info, Restricted Project
alexey.lapshin added inline comments to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..
Thu, Feb 14, 7:03 AM · debug-info, Restricted Project
Ka-Ka added a project to D58224: [DebugInfo] Adjust fragment offset for big endian targets when splitting alloca in SROA: debug-info.
Thu, Feb 14, 3:42 AM · debug-info, Restricted Project
djtodoro added inline comments to D58044: [DwarfDebug] Dump call site debug info into DWARF.
Thu, Feb 14, 3:42 AM · debug-info
NikolaPrica added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Feb 14, 3:05 AM · debug-info
alexey.lapshin added a comment to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

Hi George, Thank you for comments. I will address them. According to the questions ;

Thu, Feb 14, 2:58 AM · debug-info, Restricted Project
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

LGTM. One last request: Could you please add (either to >the doxygen comment of isArgNotModified or to >LangRef.rst or SourceLevelDebugging.rst) an >explanation of the semantics of the flag. Ie.: What it is >used for and under what conditions a frontend should >generate it?

Thu, Feb 14, 2:50 AM · debug-info
grimar added a comment to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

My comments about LLD side are below.

Thu, Feb 14, 12:04 AM · debug-info, Restricted Project

Wed, Feb 13

dstenb added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Wed, Feb 13, 1:19 PM · debug-info
alexey.lapshin added a comment to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

David, thank you for the review. I would address all points. two major points ;

Wed, Feb 13, 1:18 PM · debug-info, Restricted Project
dblaikie added a comment to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces..

This has some relatively extensive changes to some of the llvm tools (like sancov, for instance) that aren't tested - perhaps it'd be better to leave those tools usage unmodified (adding the undef section value as a fix to the API change, but nothing more) with fixits and/or followup patches that implement the improved functionality possible with the new API, along with tests?

Wed, Feb 13, 12:31 PM · debug-info, Restricted Project
aprantl added a project to D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces.: debug-info.
Wed, Feb 13, 10:37 AM · debug-info, Restricted Project
aprantl accepted D58034: [IR/DIVar] Add flag for params that have unchanged values.

LGTM. One last request: Could you please add (either to the doxygen comment of isArgNotModified or to LangRef.rst or SourceLevelDebugging.rst) an explanation of the semantics of the flag. Ie.: What it is used for and under what conditions a frontend should generate it?

Wed, Feb 13, 8:56 AM · debug-info
dstenb added inline comments to D58044: [DwarfDebug] Dump call site debug info into DWARF.
Wed, Feb 13, 8:27 AM · debug-info
ABataev added a comment to D56587: Introduce DW_OP_LLVM_convert.

NVPTX supports only DWARF2 and does not know anything about DWARF5 operations. Also, it does not support any type of the expression in the DWARF sections, except for <section_name>+-<int_offset>.

Isn't the latter a rather restrictive limitation that should be addressed in the NVPTX assembler?

Wed, Feb 13, 8:09 AM · debug-info
markus added a comment to D56587: Introduce DW_OP_LLVM_convert.

NVPTX supports only DWARF2 and does not know anything about DWARF5 operations. Also, it does not support any type of the expression in the DWARF sections, except for <section_name>+-<int_offset>.

Wed, Feb 13, 7:11 AM · debug-info
ABataev added a comment to D56587: Introduce DW_OP_LLVM_convert.

+ @ABataev re the question whether NVPTX runs into the situation described in this review.

The Sony debugger guys are okay with using the GCC operator in a pre-v5 expression. So, tentatively, for all debugger tunings, we can emit that instead of the more complicated expression. That way we are emitting compliant expressions, and the info doesn't just disappear sometimes (a much worse outcome IMO). The only remaining question is my hypothetical about NVPTX.

Re branch operators, I thought Adrian was throwing that out there as a general concern; yes branch operators exist, and yes we don't use them currently. As David says, the assembler knows how to convert a label difference into a ULEB and it will all Just Work. If/when we ever need it to.

Wed, Feb 13, 6:47 AM · debug-info
markus added a comment to D56587: Introduce DW_OP_LLVM_convert.

I see now that the inlined places i.e. these:

git grep addBlock.*DW_AT_location lib/CodeGen/AsmPrinter
lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:    addBlock(*VariableDIE, dwarf::DW_AT_location, DwarfExpr->finalize());
lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:        addBlock(*VariableDie, dwarf::DW_AT_location, DwarfExpr.finalize());
lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:  addBlock(*VariableDie, dwarf::DW_AT_location, DwarfExpr.finalize());
lib/CodeGen/AsmPrinter/DwarfUnit.cpp:        addBlock(ParamDIE, dwarf::DW_AT_location, Loc);

work quite differently and that will need some additional work.

Wed, Feb 13, 6:40 AM · debug-info
uabelho added a watcher for debug-info: uabelho.
Wed, Feb 13, 6:19 AM
probinson updated subscribers of D56587: Introduce DW_OP_LLVM_convert.

+ @ABataev re the question whether NVPTX runs into the situation described in this review.

Wed, Feb 13, 6:19 AM · debug-info
djtodoro updated the diff for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
  • Use MBB.instrs()
Wed, Feb 13, 4:55 AM · debug-info
djtodoro added a comment to D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.

@dstenb Thanks for comments!

Wed, Feb 13, 4:55 AM · debug-info
dstenb added inline comments to D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Wed, Feb 13, 3:08 AM · debug-info
dstenb added inline comments to D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Wed, Feb 13, 3:08 AM · debug-info
djtodoro updated the diff for D58046: [VirtRegMap] Salvage DBG_CALLSITEPARAM identities.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor test cases
Wed, Feb 13, 2:51 AM · debug-info
djtodoro added a comment to D58044: [DwarfDebug] Dump call site debug info into DWARF.

If we wanted to support the DWARF 5 variants are there any semantic differences, or do we just need to rename the attributes?

@aprantl Yes, it will take only DWARF symbols (tag, attributes, operand) renaming.

Wed, Feb 13, 2:51 AM · debug-info
djtodoro updated the diff for D58044: [DwarfDebug] Dump call site debug info into DWARF.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor test cases
Wed, Feb 13, 2:51 AM · debug-info