Page MenuHomePhabricator

lldProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

LLVM Linker

Recent Activity

Fri, Dec 6

MaskRay added inline comments to D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Fri, Dec 6, 12:52 PM · Restricted Project, lld
sidneym created D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Fri, Dec 6, 12:34 PM · Restricted Project, lld

Tue, Dec 3

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Can you help me merge this? I don't have commit access.

Tue, Dec 3, 1:58 PM · Restricted Project, lld
blackhole12 added a comment to D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

After further testing, this actually doesn't work, but only if you are loading an associated PDB file. I have no idea what's going on, because I don't understand the internals of TypeServerSource, but it's throwing an assertion error at DebugTypes.cpp:191

Tue, Dec 3, 9:18 AM · lld, Restricted Project

Mon, Dec 2

blackhole12 updated the diff for D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

Update with full context

Mon, Dec 2, 10:43 PM · lld, Restricted Project
MaskRay added a comment to D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

@blackhole12 https://llvm.org/docs/GettingStarted.html#sending-patches

Mon, Dec 2, 10:12 PM · lld, Restricted Project
blackhole12 updated the diff for D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

Moved the clear commands to where @ruiu suggested. I was unable to upload a full context diff because the web interface refuses to work properly.

Mon, Dec 2, 10:03 PM · lld, Restricted Project
MaskRay updated subscribers of D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).
Mon, Dec 2, 1:30 PM · Restricted Project, Restricted Project, lld
MaskRay added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

If we could get this patch merged, we could build and link the whole LLVM with lld on NetBSD and it would increase the productivity of the bot (better build times). Right now we need to maintain hacks to link at most with 2/3 cores, while 5/6 ones are idling doing nothing due to enormous RAM consumption of GNU ld.

Mon, Dec 2, 1:15 PM · Restricted Project, Restricted Project, lld

Sat, Nov 30

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Sat, Nov 30, 6:13 AM · Restricted Project, Restricted Project, lld

Fri, Nov 29

saudi added inline comments to D70557: [lld][COFF] Add support for /map.
Fri, Nov 29, 11:11 AM · Restricted Project, lld
saudi updated the diff for D70557: [lld][COFF] Add support for /map.

I changed the code quite a bit.

  • Better match the map file format (added "entry point" line, separate list for static symbols, made header addresses relative to the section instead of absolute)
  • Optimized (parallel sort of symbols etc...), added timers for feedback with /time option
  • Applied fixes previously asked by Rui Ueyama (renaming mapFileMS to mapFile, ...)
Fri, Nov 29, 10:49 AM · Restricted Project, lld

Thu, Nov 28

amilendra created D70831: [LLD][Doxygen]Add doxygen-lld build target.
Thu, Nov 28, 10:02 AM · Restricted Project, lld

Wed, Nov 27

ruiu added inline comments to D70606: LLD: CET shadow stack support on Windows.
Wed, Nov 27, 7:41 PM · Restricted Project, lld
penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Thank you!

Wed, Nov 27, 4:35 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Incorporate review feedback

Wed, Nov 27, 4:26 PM · Restricted Project, lld

Tue, Nov 26

ruiu accepted D70606: LLD: CET shadow stack support on Windows.

LGTM with these fixes.

Tue, Nov 26, 8:23 PM · Restricted Project, lld
penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Tue, Nov 26, 1:44 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Remove unused MinGW flag

Tue, Nov 26, 12:43 PM · Restricted Project, lld

Mon, Nov 25

mstorsjo added inline comments to D70606: LLD: CET shadow stack support on Windows.
Mon, Nov 25, 11:02 PM · Restricted Project, lld
ruiu added inline comments to D70606: LLD: CET shadow stack support on Windows.
Mon, Nov 25, 6:36 PM · Restricted Project, lld
penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Mon, Nov 25, 6:10 PM · Restricted Project, lld

Sun, Nov 24

ruiu added inline comments to D70606: LLD: CET shadow stack support on Windows.
Sun, Nov 24, 4:59 PM · Restricted Project, lld

Fri, Nov 22

mstorsjo added inline comments to D70606: LLD: CET shadow stack support on Windows.
Fri, Nov 22, 3:01 PM · Restricted Project, lld
penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Fri, Nov 22, 2:43 PM · Restricted Project, lld
mstorsjo added inline comments to D70606: LLD: CET shadow stack support on Windows.
Fri, Nov 22, 2:15 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Full(er) patch for the same change.

Fri, Nov 22, 2:06 PM · Restricted Project, lld
craig.topper added a comment to D70606: LLD: CET shadow stack support on Windows.

Can you reupload the patch with full context. Using -U999999 on your diff command

Fri, Nov 22, 10:52 AM · Restricted Project, lld
penzn created D70606: LLD: CET shadow stack support on Windows.
Fri, Nov 22, 10:43 AM · Restricted Project, lld
blackhole12 abandoned D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

Addressed by https://reviews.llvm.org/D70292

Fri, Nov 22, 2:42 AM · Restricted Project, lld
thopre abandoned D70507: Fix PR44093: use of stale error stream when linking.

James Knight has submitted a very similar change to fix the problem.

Fri, Nov 22, 2:10 AM · Restricted Project, lld

Thu, Nov 21

ruiu added a comment to D70507: Fix PR44093: use of stale error stream when linking.

James Knight has submitted a very similar change to fix the problem.

Thu, Nov 21, 8:33 PM · Restricted Project, lld
ruiu added a comment to D70557: [lld][COFF] Add support for /map.

Thank you for the patch. Overall, I think it is a good thing to add link.exe-compatible /map file output to lld.

Thu, Nov 21, 8:33 PM · Restricted Project, lld
saudi created D70557: [lld][COFF] Add support for /map.
Thu, Nov 21, 12:22 PM · Restricted Project, lld
thopre updated the summary of D70507: Fix PR44093: use of stale error stream when linking.
Thu, Nov 21, 3:11 AM · Restricted Project, lld
thopre updated the diff for D70507: Fix PR44093: use of stale error stream when linking.

Remove enableColors and replace calls to it by the underlying enable_colors()

Thu, Nov 21, 3:11 AM · Restricted Project, lld

Wed, Nov 20

ruiu added inline comments to D70507: Fix PR44093: use of stale error stream when linking.
Wed, Nov 20, 3:58 PM · Restricted Project, lld
thopre edited projects for D70507: Fix PR44093: use of stale error stream when linking, added: lld; removed Restricted Project.
Wed, Nov 20, 1:47 PM · Restricted Project, lld

Tue, Nov 19

krytarowski added a reviewer for D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld): chandlerc.

We are in the process of switching our buildbot to newer NetBSD snapshot (-8 to -9) and we keep waiting for this patch to land.

Tue, Nov 19, 6:25 AM · Restricted Project, Restricted Project, lld

Mon, Nov 18

ruiu added a comment to D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

I share your concern and I'm sorry about leaving so many global variables as uninitialized in the second run of the linker in the same process. But I'd like to find and fix the problems without abolishing global variables in lld, as I don't actually dislike them. One thing we could do is initializing global variables with invalid data -- like -1 or {nullptr} so that you'd get an error even on the first run if you do not reset them before use. I'll create a patch and send it to you.

Mon, Nov 18, 9:40 PM · lld, Restricted Project
smeenai added reviewers for D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link(): ruiu, rnk.

It's recommended to uploaded patches with full context (e.g. by using git diff -U9999 when uploading a patch using the web interface).

Mon, Nov 18, 6:53 PM · lld, Restricted Project
blackhole12 created D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().
Mon, Nov 18, 1:33 AM · lld, Restricted Project
grimar added a comment to D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

Unfortunately, I can't submit any additional patches. I have another patch for LLD that fixes a cleanup error, but https://reviews.llvm.org/differential/diff/create/ returns Unhandled Exception ("Exception") no matter how many times I log out, clear the cache, or use another browser. I tried using the command-line arcanist tool, but that doesn't seem to like my patch either. I've tried asking on IRC, but nobody seems able to help and I have no idea who to contact about this issue.

Mon, Nov 18, 12:28 AM · Restricted Project, lld

Thu, Nov 14

ruiu added a comment to D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

I don't know what is going on with your Phabricator account, but I can help you solve your problem. I'll make a patch to add a new parameter to the link() functions so that you can pass not only stderr but also stdout to the functions.

Thu, Nov 14, 10:25 PM · Restricted Project, lld
blackhole12 added a comment to D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

Yes, I am calling lld::elf::link from my program, which statically links LLD as a library. I can create a change that adds a diag stream to all the linker calls, but this would touch quite a lot of files. It may be more appropriate to close this change and to create a new change for adding a new stream.

Thu, Nov 14, 8:27 PM · Restricted Project, lld
ruiu added a comment to D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

I am calling LLD from within another command line application, and I only want to display output from LLD if there is an actual error, or the user has enabled verbose logging, but several places in LLD use message() during the linking process even if it succeeds, which will output directly to stdout with no way for me to portably redirect it (unless I use freopen, which permanently redirects it to a file, forever, and cannot be restored afterwards). If there needs to be a separate stream for non-error messages, then there should be a way to pass that into the link() function as well, instead of bypassing everything and outputting directly to stdout.

Thu, Nov 14, 7:40 PM · Restricted Project, lld
blackhole12 added a comment to D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

I am calling LLD from within another command line application, and I only want to display output from LLD if there is an actual error, or the user has enabled verbose logging, but several places in LLD use message() during the linking process even if it succeeds, which will output directly to stdout with no way for me to portably redirect it (unless I use freopen, which permanently redirects it to a file, forever, and cannot be restored afterwards). If there needs to be a separate stream for non-error messages, then there should be a way to pass that into the link() function as well, instead of bypassing everything and outputting directly to stdout.

Thu, Nov 14, 6:53 PM · Restricted Project, lld
ruiu added a comment to D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

I think this is intended because what message() prints out is not an error message (if it were, you should have used error()) instead.

Thu, Nov 14, 6:44 PM · Restricted Project, lld
blackhole12 retitled D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler from Fix Incorrect Stream in LLD ErrorHandler to [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.
Thu, Nov 14, 6:27 PM · Restricted Project, lld
blackhole12 created D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.
Thu, Nov 14, 6:26 PM · Restricted Project, lld