Page MenuHomePhabricator

lldProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

LLVM Linker

Recent Activity

Thu, Sep 12

avl updated the summary of D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting..
Thu, Sep 12, 7:37 AM · debug-info, lld, Restricted Project

Wed, Sep 11

avl added projects to D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting.: lld, debug-info.
Wed, Sep 11, 11:15 PM · debug-info, lld, Restricted Project

Tue, Sep 10

ruiu closed D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .
Tue, Sep 10, 4:49 AM · Restricted Project, lld
zero9178 added a comment to D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Friendly after a week ping.

Tue, Sep 10, 1:04 AM · Restricted Project, lld

Tue, Sep 3

zero9178 updated the diff for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Changed memberOffset to memberIndex as suggested by reviwer. Would need someone to commit this for me

Tue, Sep 3, 5:08 AM · Restricted Project, lld

Mon, Sep 2

ruiu accepted D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

LGTM with this change.

Mon, Sep 2, 1:12 AM · Restricted Project, lld

Fri, Aug 30

zero9178 updated the diff for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Changed index from std::uint64_t to int. Made test accept both kinds of slashes

Fri, Aug 30, 3:56 AM · Restricted Project, lld

Wed, Aug 28

ruiu added a comment to D66260: [lld][Hexagon] Add GOTREL relocations.

Where can we find a psABI describing these relocation types?

You can find it here: https://developer.qualcomm.com/download/hexagon/hexagon-application-binary-interface-specification.zip?referrer=node/6116
but there is a click-through license and registration.

Wed, Aug 28, 2:50 AM · Restricted Project, lld
MaskRay added a comment to D66260: [lld][Hexagon] Add GOTREL relocations.

Still having trouble to access this.

Wed, Aug 28, 2:25 AM · Restricted Project, lld

Aug 19 2019

sidneym closed D66260: [lld][Hexagon] Add GOTREL relocations.
Aug 19 2019, 6:32 AM · Restricted Project, lld
ruiu added inline comments to D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .
Aug 19 2019, 4:39 AM · Restricted Project, lld
MaskRay closed D39324: [lld] Support TLS in RISC-V.
Aug 19 2019, 2:57 AM · lld
ruiu added a comment to D39324: [lld] Support TLS in RISC-V.

This has been merged on July 2 as http://reviews.llvm.org/rL364813

Aug 19 2019, 2:48 AM · lld
ruiu added a comment to D66105: Support HEX_32 when building shared objects.

LGTM

Aug 19 2019, 1:06 AM · Restricted Project, lld

Aug 18 2019

ruiu accepted D66260: [lld][Hexagon] Add GOTREL relocations.

LGTM

Aug 18 2019, 11:43 PM · Restricted Project, lld

Aug 16 2019

MaskRay accepted D66260: [lld][Hexagon] Add GOTREL relocations.
Aug 16 2019, 6:54 PM · Restricted Project, lld
sidneym closed D66105: Support HEX_32 when building shared objects.
Aug 16 2019, 8:35 AM · Restricted Project, lld

Aug 15 2019

sidneym added a comment to D66260: [lld][Hexagon] Add GOTREL relocations.

Where can we find a psABI describing these relocation types?

Aug 15 2019, 8:03 AM · Restricted Project, lld
sidneym updated the diff for D66260: [lld][Hexagon] Add GOTREL relocations.

Update filenames in testcase.

Aug 15 2019, 7:16 AM · Restricted Project, lld
MaskRay closed D39323: [lld] Support dynamic linking in RISC-V.

Am I correct in thinking that this functionality has already been upstreamed into LLD, and that this patch can now been abandoned?

Aug 15 2019, 3:14 AM · Restricted Project, lld
lenary added a comment to D39323: [lld] Support dynamic linking in RISC-V.

Am I correct in thinking that this functionality has already been upstreamed into LLD, and that this patch can now been abandoned?

Aug 15 2019, 2:52 AM · Restricted Project, lld
lenary added a comment to D39324: [lld] Support TLS in RISC-V.

Am I correct in thinking that this functionality has already been upstreamed into LLD, and that this patch can now been abandoned?

Aug 15 2019, 2:52 AM · lld

Aug 14 2019

MaskRay added inline comments to D66260: [lld][Hexagon] Add GOTREL relocations.
Aug 14 2019, 11:04 PM · Restricted Project, lld
MaskRay added a reviewer for D66260: [lld][Hexagon] Add GOTREL relocations: MaskRay.
Aug 14 2019, 9:16 PM · Restricted Project, lld
MaskRay added a comment to D66260: [lld][Hexagon] Add GOTREL relocations.

Where can we find a psABI describing these relocation types?

Aug 14 2019, 9:16 PM · Restricted Project, lld
sidneym created D66260: [lld][Hexagon] Add GOTREL relocations.
Aug 14 2019, 4:16 PM · Restricted Project, lld
zero9178 added a reviewer for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive : pcc.
Aug 14 2019, 2:01 PM · Restricted Project, lld
zero9178 updated the diff for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Fixed test to show regression and verify output

Aug 14 2019, 1:15 PM · Restricted Project, lld
zero9178 edited projects for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive , added: lld; removed Restricted Project.
Aug 14 2019, 12:38 PM · Restricted Project, lld
bcain accepted D66105: Support HEX_32 when building shared objects.
Aug 14 2019, 7:00 AM · Restricted Project, lld

Aug 13 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Folks, I would like to ask a question related to this review and DWARF standard:

Aug 13 2019, 8:37 AM · lld, Restricted Project

Aug 12 2019

sidneym added a reviewer for D66105: Support HEX_32 when building shared objects: shankare.
Aug 12 2019, 12:45 PM · Restricted Project, lld
sidneym created D66105: Support HEX_32 when building shared objects.
Aug 12 2019, 12:41 PM · Restricted Project, lld

Aug 9 2019

ikudrin closed D65875: [ELF] For VS-style diagnostics, prefer using the full path..
Aug 9 2019, 1:28 AM · Restricted Project, lld
ruiu accepted D65875: [ELF] For VS-style diagnostics, prefer using the full path..

I confirmed that these tests are not affected by the actual path on a machine running the tests. I missed the part that you added .line directive in this patch. Thank you for doing this.

Aug 9 2019, 12:25 AM · Restricted Project, lld

Aug 8 2019

ikudrin added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

Well, I have checked the patch on Windows. All tests pass.

Aug 8 2019, 6:31 AM · Restricted Project, lld
ikudrin added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

We had that issue with D65810 (rL368153), windows build bots complained about different path separators. That was fixed in rL368169. Thus, I made similar adjustments in this patch.

Aug 8 2019, 3:39 AM · Restricted Project, lld
ruiu added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

Generally looking good, but do these tests pass on Windows on which a path separator is \? It seems like you hardcoded / as a path separator in the tests.

Aug 8 2019, 2:58 AM · Restricted Project, lld

Aug 7 2019

ikudrin created D65875: [ELF] For VS-style diagnostics, prefer using the full path..
Aug 7 2019, 7:53 AM · Restricted Project, lld
ikudrin closed D65810: [ELF] Fix splitting messages for duplicate symbols..
Aug 7 2019, 4:33 AM · Restricted Project, lld
MaskRay accepted D65810: [ELF] Fix splitting messages for duplicate symbols..
Aug 7 2019, 3:09 AM · Restricted Project, lld
ruiu accepted D65810: [ELF] Fix splitting messages for duplicate symbols..

LGTM

Aug 7 2019, 2:12 AM · Restricted Project, lld

Aug 6 2019

ikudrin updated the diff for D65810: [ELF] Fix splitting messages for duplicate symbols..
  • Removed Inputs/vs-diagnostics-duplicate-split.s
  • Updated the test accordingly.
Aug 6 2019, 11:56 PM · Restricted Project, lld
MaskRay added inline comments to D65810: [ELF] Fix splitting messages for duplicate symbols..
Aug 6 2019, 9:55 PM · Restricted Project, lld
ikudrin created D65810: [ELF] Fix splitting messages for duplicate symbols..
Aug 6 2019, 8:36 AM · Restricted Project, lld
ikudrin closed D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Aug 6 2019, 6:36 AM · Restricted Project, lld

Aug 2 2019

ruiu accepted D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).

LGTM

Aug 2 2019, 2:36 AM · Restricted Project, lld
ikudrin added a child revision for D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5): D65641: Remove support for 32-bit offsets in utility classes (5/5).
Aug 2 2019, 2:15 AM · Restricted Project, lld
ikudrin added a parent revision for D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5): D65638: Switch LLVM to use 64-bit offsets (2/5).
Aug 2 2019, 2:07 AM · Restricted Project, lld
ikudrin created D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Aug 2 2019, 2:07 AM · Restricted Project, lld