Page MenuHomePhabricator

zyounan (Younan Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2022, 8:38 AM (28 w, 1 d)

Recent Activity

Fri, Mar 17

zyounan committed rG138adb098032: [clangd] Refine logic on $0 in completion snippets (authored by zyounan).
[clangd] Refine logic on $0 in completion snippets
Fri, Mar 17, 2:57 AM · Restricted Project, Restricted Project
zyounan closed D145319: [clangd] Refine logic on $0 in completion snippets.
Fri, Mar 17, 2:57 AM · Restricted Project, Restricted Project
zyounan added inline comments to D145319: [clangd] Refine logic on $0 in completion snippets.
Fri, Mar 17, 1:25 AM · Restricted Project, Restricted Project
zyounan updated the diff for D145319: [clangd] Refine logic on $0 in completion snippets.

Add description to shouldPatchPlaceholder0

Fri, Mar 17, 1:24 AM · Restricted Project, Restricted Project

Wed, Mar 15

zyounan added a comment to D145319: [clangd] Refine logic on $0 in completion snippets.

Updated now. Thank you again for your patient review. :)

Wed, Mar 15, 3:01 AM · Restricted Project, Restricted Project
zyounan updated the diff for D145319: [clangd] Refine logic on $0 in completion snippets.

Address comments

Wed, Mar 15, 3:01 AM · Restricted Project, Restricted Project

Mon, Mar 13

zyounan added inline comments to D145319: [clangd] Refine logic on $0 in completion snippets.
Mon, Mar 13, 11:23 PM · Restricted Project, Restricted Project
zyounan updated the diff for D145319: [clangd] Refine logic on $0 in completion snippets.

Update doxygen comments

Mon, Mar 13, 11:23 PM · Restricted Project, Restricted Project
zyounan added inline comments to D145319: [clangd] Refine logic on $0 in completion snippets.
Mon, Mar 13, 11:13 PM · Restricted Project, Restricted Project
zyounan updated the diff for D145319: [clangd] Refine logic on $0 in completion snippets.

Address the comments. Revise parameters of getSignature to avoid passing CCR

Mon, Mar 13, 11:12 PM · Restricted Project, Restricted Project

Thu, Mar 9

zyounan added a comment to D145319: [clangd] Refine logic on $0 in completion snippets.

Ping :)

Thu, Mar 9, 5:47 PM · Restricted Project, Restricted Project

Sun, Mar 5

zyounan published D145319: [clangd] Refine logic on $0 in completion snippets for review.
Sun, Mar 5, 4:24 AM · Restricted Project, Restricted Project

Sun, Feb 26

zyounan committed rGcb2d04d41e47: [clangd] Hide inlay hints when using a macro as a calling argument that with a… (authored by zyounan).
[clangd] Hide inlay hints when using a macro as a calling argument that with a…
Sun, Feb 26, 3:07 AM · Restricted Project, Restricted Project
zyounan closed D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment.
Sun, Feb 26, 3:06 AM · Restricted Project, Restricted Project

Sat, Feb 25

zyounan updated the diff for D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment.

Update

Sat, Feb 25, 1:09 AM · Restricted Project, Restricted Project
zyounan added inline comments to D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment.
Sat, Feb 25, 1:06 AM · Restricted Project, Restricted Project
zyounan updated the diff for D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment.

Address the comments

Sat, Feb 25, 1:05 AM · Restricted Project, Restricted Project

Wed, Feb 22

zyounan updated the diff for D143319: [clangd] Support iwyu pragma: no_include.

Move parsing logic to Record.cpp

Wed, Feb 22, 1:54 AM · Restricted Project, Restricted Project

Tue, Feb 21

zyounan added a comment to D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment.

Ping

Tue, Feb 21, 6:24 PM · Restricted Project, Restricted Project

Feb 15 2023

zyounan published D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment for review.
Feb 15 2023, 5:51 AM · Restricted Project, Restricted Project

Feb 13 2023

zyounan committed rGd4021ed3d79d: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem` (authored by zyounan).
[Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`
Feb 13 2023, 9:08 AM · Restricted Project, Restricted Project
zyounan closed D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Feb 13 2023, 9:08 AM · Restricted Project, Restricted Project, Restricted Project
zyounan retitled D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem` from [clangd] Add symbol mappings for `std::experimental::filesystem` to [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Feb 13 2023, 8:48 AM · Restricted Project, Restricted Project, Restricted Project
zyounan updated the diff for D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Apply clang-format to StandardLibrary.cpp to fix pipeline failure

Feb 13 2023, 7:23 AM · Restricted Project, Restricted Project, Restricted Project
zyounan added inline comments to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Feb 13 2023, 7:20 AM · Restricted Project, Restricted Project, Restricted Project
zyounan added a comment to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Thank you for your detailed explanation and sorry again for my dumb mistake before. :)

Feb 13 2023, 7:16 AM · Restricted Project, Restricted Project, Restricted Project
zyounan added inline comments to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Feb 13 2023, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
zyounan added inline comments to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Feb 13 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project
zyounan updated the diff for D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Revise

Feb 13 2023, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
zyounan added inline comments to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Feb 13 2023, 6:01 AM · Restricted Project, Restricted Project, Restricted Project
zyounan updated the diff for D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Rebase to main && Move tests to clang/Tooling

Feb 13 2023, 4:51 AM · Restricted Project, Restricted Project, Restricted Project
zyounan added a comment to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Sorry for the late update, I'm rebasing my branch now.

Feb 13 2023, 3:22 AM · Restricted Project, Restricted Project, Restricted Project
zyounan added a reviewer for D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`: kadircet.
Feb 13 2023, 1:59 AM · Restricted Project, Restricted Project, Restricted Project
zyounan updated the summary of D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Feb 13 2023, 1:58 AM · Restricted Project, Restricted Project, Restricted Project
zyounan updated the diff for D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Revise symbols from N4100

Feb 13 2023, 1:56 AM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2023

zyounan added a comment to D143319: [clangd] Support iwyu pragma: no_include.

thanks a lot for the patch!

we're migrating IWYU related functionality in clangd to make use of include-cleaner library nowadays. so can you actually move the IWYU no_include pragma handling logic into https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/include-cleaner/lib/Record.cpp?
This won't have affect on clangd regarding the particular problem you're facing immediately, but we're going to merge the logic inside include-cleaner and clangd soon and such discrepancies should disappear then.

in the meanwhile regarding the particular problem you're facing for experimental symbols. sorry for shutting down D142836, but that actually made us re-evaluate the approach of hand-curated lists and we've decided to introduce such mappings. so if you can revamp D142836 and put TsStdSymbolMap.inc in https://github.com/llvm/llvm-project/tree/main/clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc we can land it and make sure it work as intended inside clangd, even before we merge the IWYU pragma handling logic. Happy to do that myself if you don't feel like doing it, sorry for creating some confusion here :(

Feb 9 2023, 7:49 PM · Restricted Project, Restricted Project

Feb 7 2023

zyounan added a comment to D143319: [clangd] Support iwyu pragma: no_include.

Ping

Feb 7 2023, 6:09 PM · Restricted Project, Restricted Project

Feb 5 2023

zyounan updated the diff for D143319: [clangd] Support iwyu pragma: no_include.

Fix test on windows

Feb 5 2023, 8:16 AM · Restricted Project, Restricted Project
zyounan updated the diff for D143319: [clangd] Support iwyu pragma: no_include.

Update tests && Use Preprocessor.LookupFile

Feb 5 2023, 7:25 AM · Restricted Project, Restricted Project

Feb 4 2023

zyounan published D143319: [clangd] Support iwyu pragma: no_include for review.
Feb 4 2023, 5:30 AM · Restricted Project, Restricted Project

Jan 29 2023

zyounan abandoned D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Jan 29 2023, 11:23 PM · Restricted Project, Restricted Project, Restricted Project
zyounan added a comment to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

we're already having some efforts right now to improve our cppreference parsing and get to a more complete set of symbols (@VitaNuo for visibility, who drives these efforts)..

Jan 29 2023, 11:13 PM · Restricted Project, Restricted Project, Restricted Project
zyounan added a comment to D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.
Jan 29 2023, 11:06 PM · Restricted Project, Restricted Project, Restricted Project
zyounan updated the diff for D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Format

Jan 29 2023, 9:00 PM · Restricted Project, Restricted Project, Restricted Project
zyounan updated the diff for D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`.

Do not format inc file

Jan 29 2023, 2:51 AM · Restricted Project, Restricted Project, Restricted Project
zyounan published D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem` for review.
Jan 29 2023, 1:56 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

zyounan updated subscribers of D141352: [ADT] Fix circular include dependency by using std::array. NFC.

Can anyone else help me to commit this PR? I mean we should land this patch ASAP, as many of PRs are now depending on llvm::ArrayRef without including ADT/ArrayRef.h but ADT/STLExtras.h, which would make it extremely harder to resolve this circular dependency later.

Jan 20 2023, 8:28 PM · Restricted Project, Restricted Project
zyounan updated the diff for D141352: [ADT] Fix circular include dependency by using std::array. NFC.

Fix issue

Jan 20 2023, 8:28 PM · Restricted Project, Restricted Project

Jan 17 2023

zyounan added a comment to D141352: [ADT] Fix circular include dependency by using std::array. NFC.

Ping again. Sorry I don't have commit access to main branch.

Jan 17 2023, 6:06 PM · Restricted Project, Restricted Project

Jan 13 2023

zyounan added a comment to D141352: [ADT] Fix circular include dependency by using std::array. NFC.

LGTM

Jan 13 2023, 7:41 PM · Restricted Project, Restricted Project

Jan 12 2023

zyounan added a comment to D141352: [ADT] Fix circular include dependency by using std::array. NFC.

Ping. Is this OK for trunk?

Jan 12 2023, 7:37 PM · Restricted Project, Restricted Project

Jan 9 2023

zyounan updated the diff for D141352: [ADT] Fix circular include dependency by using std::array. NFC.

Add header llvm/ADT/Hashing.h, which is included by ArrayRef.h before. This header may be dependent by some TUs indirectly.

Jan 9 2023, 10:33 PM · Restricted Project, Restricted Project
zyounan added a comment to D141352: [ADT] Fix circular include dependency by using std::array. NFC.

Pipeline failed due to missing include header llvm/ADT/Hashing.h

In file included from /var/lib/buildkite-agent/builds/llvm-project/clang-tools-extra/clangd/Config.cpp:9:
/var/lib/buildkite-agent/builds/llvm-project/clang-tools-extra/clangd/Config.h:158:18: error: no member named 'hash_combine' in namespace 'llvm'
    return llvm::hash_combine(Val.Kind, Val.Location, Val.MountPoint);
Jan 9 2023, 10:25 PM · Restricted Project, Restricted Project
zyounan requested review of D141352: [ADT] Fix circular include dependency by using std::array. NFC.
Jan 9 2023, 9:31 PM · Restricted Project, Restricted Project