Page MenuHomePhabricator

ztamas (Tamás Zolnai)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 5 2018, 9:46 AM (78 w, 3 d)

Recent Activity

Sat, Apr 4

ztamas committed rG0f9e1e3ae750: [clang-tidy]: fix false positive of cert-oop54-cpp check. (authored by ztamas).
[clang-tidy]: fix false positive of cert-oop54-cpp check.
Sat, Apr 4, 9:00 AM
ztamas closed D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..
Sat, Apr 4, 9:00 AM · Restricted Project, Restricted Project
ztamas updated the diff for D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..

Add suggested test case and rebase.

Sat, Apr 4, 8:28 AM · Restricted Project, Restricted Project

Sun, Mar 29

ztamas updated the diff for D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..

Remove false TODO comment.

Sun, Mar 29, 11:13 AM · Restricted Project, Restricted Project
ztamas added a comment to D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..

I'm not entirely sure this is where the fix needs to be for this. The test case code is whacky as hell, but from what I can see clang should always emit a BinaryOperator for dependent type operators. No idea why it is spewing out a CXXOperatorCallExpr instead. Would need someone with more knowledge on Sema to confirm(or deny) this though.

Sun, Mar 29, 5:50 AM · Restricted Project, Restricted Project
ztamas updated the diff for D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..

Rebase, TODO comment, remove unrelated change.

Sun, Mar 29, 5:50 AM · Restricted Project, Restricted Project

Sat, Mar 28

ztamas updated the diff for D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..

Run clang-format on test code.

Sat, Mar 28, 9:40 AM · Restricted Project, Restricted Project
ztamas created D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..
Sat, Mar 28, 8:36 AM · Restricted Project, Restricted Project
ztamas added a reviewer for D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.: aaron.ballman.
Sat, Mar 28, 8:36 AM · Restricted Project, Restricted Project
ztamas updated the summary of D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check..
Sat, Mar 28, 8:36 AM · Restricted Project, Restricted Project

Sat, Mar 14

ztamas committed rG04410c565aa0: [clang-tidy] extend bugprone-signed-char-misuse check. (authored by ztamas).
[clang-tidy] extend bugprone-signed-char-misuse check.
Sat, Mar 14, 12:21 PM
ztamas closed D75749: [clang-tidy] extend bugprone-signed-char-misuse check..
Sat, Mar 14, 12:20 PM · Restricted Project, Restricted Project
ztamas added a comment to D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

LGTM

However, how does this handle cases when the type is written as char. They can be signed/unsigned based on what platform is being targeted. But on a platform where char is signed, comparison to an unsigned char is dangerous and the complimented case is the same. Surely any char comparison to signed char or unsigned char should be warned. But I'm not sure if that's in the scope of this check.

Sat, Mar 14, 12:20 PM · Restricted Project, Restricted Project

Mar 7 2020

ztamas updated the diff for D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

Update code based on reviewer comments.

Mar 7 2020, 2:42 AM · Restricted Project, Restricted Project
ztamas updated the diff for D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

Use quotes in warning message.

Mar 7 2020, 1:38 AM · Restricted Project, Restricted Project
ztamas added inline comments to D75749: [clang-tidy] extend bugprone-signed-char-misuse check..
Mar 7 2020, 1:38 AM · Restricted Project, Restricted Project
ztamas updated the diff for D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

One more unneeded allOf and clang-format

Mar 7 2020, 1:38 AM · Restricted Project, Restricted Project
ztamas updated the diff for D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

Changed code based on reviewer comments.

Mar 7 2020, 1:06 AM · Restricted Project, Restricted Project
ztamas updated the diff for D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

Fix pre-merge check error

Mar 7 2020, 1:06 AM · Restricted Project, Restricted Project

Mar 6 2020

ztamas added a comment to D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

In the LibreOffice codebase, I found 8 catches:
https://gist.github.com/tzolnai/2b22492c0cf79f5dba577f6a878657e3

Mar 6 2020, 8:13 AM · Restricted Project, Restricted Project
ztamas added a comment to D75749: [clang-tidy] extend bugprone-signed-char-misuse check..

I run the check on LLVM code and found only one catch of suspicious comparison:

Mar 6 2020, 8:13 AM · Restricted Project, Restricted Project
ztamas added a reviewer for D75749: [clang-tidy] extend bugprone-signed-char-misuse check.: aaron.ballman.
Mar 6 2020, 8:13 AM · Restricted Project, Restricted Project
ztamas created D75749: [clang-tidy] extend bugprone-signed-char-misuse check..
Mar 6 2020, 8:13 AM · Restricted Project, Restricted Project

Jan 14 2020

ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I run the new check on LibreOffice codebase with the option CharTypdefsToIgnore = "sal_Int8".
The check produced 32 findings.

Interesting. It found 31 issues on the Firefox code base!
I can share the list if you are interested!

Jan 14 2020, 4:58 AM · Restricted Project, Restricted Project

Jan 12 2020

ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

A little bit late to the party, but still.
I'm honestly wondering if this should be a proper clang static analyzer data-flow aware check.
This is basically diagnosing every signed char -> signed int promotion, regardless of whether
the char is used as an ASCII char or not. It really seems like a wrong, noise-filled approach..

Jan 12 2020, 4:08 AM · Restricted Project, Restricted Project

Jan 6 2020

ztamas committed rG350da402ef6b: [clang-tidy] new check: bugprone-signed-char-misuse (authored by ztamas).
[clang-tidy] new check: bugprone-signed-char-misuse
Jan 6 2020, 9:27 AM
ztamas closed D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Jan 6 2020, 9:27 AM · Restricted Project, Restricted Project

Jan 4 2020

ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Thanks for the review!
I applied for the renewal of my commit access. I had commit access only for the SVN repo. After I get access to the GitHub repo I'll push this change.

Jan 4 2020, 5:51 AM · Restricted Project, Restricted Project

Jan 1 2020

ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Update warning message in test files and rebase patch.

Jan 1 2020, 11:45 AM · Restricted Project, Restricted Project
ztamas added inline comments to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Jan 1 2020, 8:03 AM · Restricted Project, Restricted Project
ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Update docs / warning message, according to reviewer comments.

Jan 1 2020, 7:39 AM · Restricted Project, Restricted Project

Dec 28 2019

ztamas added inline comments to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Dec 28 2019, 2:42 AM · Restricted Project, Restricted Project
ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Rebase patch.

Dec 28 2019, 2:42 AM · Restricted Project, Restricted Project

Dec 27 2019

ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I added the above comments two weeks ago, I just forget to push the submit button.

Dec 27 2019, 11:47 PM · Restricted Project, Restricted Project
ztamas added inline comments to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Dec 27 2019, 11:47 PM · Restricted Project, Restricted Project

Dec 12 2019

ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Add newlines to the end of the files.

Dec 12 2019, 9:28 AM · Restricted Project, Restricted Project
ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Update code based on reviewer comments.

Dec 12 2019, 9:18 AM · Restricted Project, Restricted Project

Dec 9 2019

ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Remove anonymus namespace

Dec 9 2019, 7:19 AM · Restricted Project, Restricted Project
ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Fixes small things mentioned by reviewer commments.

Dec 9 2019, 4:59 AM · Restricted Project, Restricted Project

Dec 8 2019

ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I run the new check on LLVM codebase with the option CharTypdefsToIgnore = "int8_t".
The check produced 12 findings.

Dec 8 2019, 6:04 AM · Restricted Project, Restricted Project
ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I run the new check on LibreOffice codebase with the option CharTypdefsToIgnore = "sal_Int8".
The check produced 32 findings.

Dec 8 2019, 5:55 AM · Restricted Project, Restricted Project
ztamas created D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Dec 8 2019, 5:22 AM · Restricted Project, Restricted Project

May 23 2019

ztamas committed rGdab31924e9c7: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment (authored by ztamas).
[clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment
May 23 2019, 1:28 PM
ztamas committed rL361550: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
[clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment
May 23 2019, 1:28 PM
ztamas committed rCTE361550: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
[clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment
May 23 2019, 1:28 PM
ztamas closed D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
May 23 2019, 1:27 PM · Restricted Project

May 22 2019

ztamas updated the diff for D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.

Link burprone module to cert module

May 22 2019, 9:16 AM · Restricted Project
ztamas updated the diff for D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.

Fixed docs.

May 22 2019, 5:51 AM · Restricted Project

May 21 2019

ztamas added a reviewer for D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment: aaron.ballman.
May 21 2019, 6:03 AM · Restricted Project
ztamas created D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
May 21 2019, 6:00 AM · Restricted Project

May 20 2019

ztamas committed rG11fa0ee8f401: [clang-tidy] Sort this list alphabetically (authored by ztamas).
[clang-tidy] Sort this list alphabetically
May 20 2019, 3:37 AM
ztamas committed rL361138: [clang-tidy] Sort this list alphabetically.
[clang-tidy] Sort this list alphabetically
May 20 2019, 3:37 AM
ztamas committed rCTE361138: [clang-tidy] Sort this list alphabetically.
[clang-tidy] Sort this list alphabetically
May 20 2019, 3:37 AM

May 12 2019

ztamas committed rCTE360540: [clang-tidy] new check: bugprone-unhandled-self-assignment.
[clang-tidy] new check: bugprone-unhandled-self-assignment
May 12 2019, 5:26 AM
ztamas committed rGde7a30cb0a0f: [clang-tidy] new check: bugprone-unhandled-self-assignment (authored by ztamas).
[clang-tidy] new check: bugprone-unhandled-self-assignment
May 12 2019, 5:24 AM
ztamas committed rL360540: [clang-tidy] new check: bugprone-unhandled-self-assignment.
[clang-tidy] new check: bugprone-unhandled-self-assignment
May 12 2019, 5:24 AM
ztamas closed D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
May 12 2019, 5:23 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

I definitely want to see the diagnostic text changed away from "might be" -- that's too noncommittal for my tastes. I'd also like to see the additional test case (I suspect it will just work out of the box, but if it doesn't, it would be good to know about it). The CERT alias is a bit more of a grey area -- I'd like to insist on it being added because it's trivial, it improves the behavior of this check by introducing an option some users will want, and checks conforming to coding standards are always more compelling than one-off checks. However, you seem very resistant to that and I don't want to add to your work load if you are opposed to doing it, so I don't insist on the change.

May 9 2019, 4:36 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

copy operator -> copy assignment operator

May 9 2019, 4:27 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Changed "might not" to "does not" in the warning message.
Added the requested test case with the swapped template arguments.

May 9 2019, 4:26 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Ping.
Is it good to go or is there anything else I need to include in this patch?
Among the lots of idea, I'm not sure which is just brainstorming and which is a change request.
The check seems to work (has useful catches and does not produce too many false positives), however, it does not conform with the corresponding cert rule. I expect that a cert alias with an option can be added in a follow-up patch (option to ignore ThisHasSuspiciousField pattern). The bugprone-* check would have the same default behavior as it has now in this patch. So adding the cert alias would not change this behavior, right? In this case, this code change can be added in a separate patch I guess.

May 5 2019, 5:05 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Better handling of template and non-template self-copy

Apr 28 2019, 3:17 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Ok, is there anything else should be included in this patch?
I saw more ideas about how to extend the functionality (custom pointers, fix-it, etc). I interpreted these ideas as nice-to-have things for the future.

Apr 25 2019, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
ztamas abandoned D60664: [git-svn] Add a username option for push command.
Apr 25 2019, 9:20 AM · Restricted Project

Apr 24 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Remove outdated comment from docs.

Apr 24 2019, 3:27 AM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Mark some comments Done, which were handled some way.

Apr 23 2019, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

I also reformatted the code with clang-format.

Apr 23 2019, 11:53 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Make the check to work with templates too

Apr 23 2019, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 11:15 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Ok, so I removed the alias from cert module and added CERT rule link as a "see also".
So I think we solved the problem that things do not conform with the CERT requirements and can focus on the actual problem.

Apr 23 2019, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Added missing fullstop
Added a new test cases making sure that HasNoSelfCheck works correctly
Added template instantiation to tests
Remove the alias from cert module and add the CERT link as a see also

Apr 23 2019, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 8:31 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Add false positive test cases.
Added a note about template related limitation to the docs.

Apr 22 2019, 6:55 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60664: [git-svn] Add a username option for push command.

Should we (either instead or as well) make the default username try git config llvm.username before falling back to the local user? That way people can set it with git config llvm.username xyz or, if they work with a lot of llvm checkouts, git config --global llvm.username xyz instead of having to specify it every time.

Apr 22 2019, 5:02 AM · Restricted Project

Apr 16 2019

ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 16 2019, 8:17 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 16 2019, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Update patch based on reviewer comments.

Apr 16 2019, 7:47 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2019

ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 14 2019, 7:19 AM · Restricted Project, Restricted Project, Restricted Project
ztamas retitled D60664: [git-svn] Add a username option for push command from [git-svn] Add a username option for puch command to [git-svn] Add a username option for push command.
Apr 14 2019, 6:08 AM · Restricted Project
ztamas updated the diff for D60664: [git-svn] Add a username option for push command.

Fixed commit message

Apr 14 2019, 6:07 AM · Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Missed to syncronize ReleasNotes with the corresponding doc.

Apr 14 2019, 6:05 AM · Restricted Project, Restricted Project, Restricted Project
ztamas created D60664: [git-svn] Add a username option for push command.
Apr 14 2019, 5:57 AM · Restricted Project
ztamas committed rG065480daf2e9: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop… (authored by ztamas).
[clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop…
Apr 14 2019, 5:49 AM
ztamas committed rCTE358356: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop….
[clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop…
Apr 14 2019, 5:48 AM
ztamas committed rL358356: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop….
[clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop…
Apr 14 2019, 5:48 AM
ztamas closed D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Apr 14 2019, 5:48 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2019

ztamas added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

In the meantime, I've got the commit access, so I'll give it a try to push this myself.

Apr 13 2019, 7:39 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to rL358333: [clang-tidy] Use back-tick here.

It was my first commit, to see whether everything works.

Apr 13 2019, 7:39 AM
ztamas committed rG4dbcc3cf7430: [clang-tidy] Use back-tick here (authored by ztamas).
[clang-tidy] Use back-tick here
Apr 13 2019, 7:31 AM
ztamas committed rCTE358333: [clang-tidy] Use back-tick here.
[clang-tidy] Use back-tick here
Apr 13 2019, 7:31 AM
ztamas committed rL358333: [clang-tidy] Use back-tick here.
[clang-tidy] Use back-tick here
Apr 13 2019, 7:31 AM

Apr 12 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Documentation fixes.

Apr 12 2019, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 12 2019, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Updated the code based on reviewer comments:

  • Alphabetical order in BugproneTidyModule.cpp
  • Handling of auto_ptr
  • Test cases for template classes (I made the check ignore these case otherwise this can lead to false positives)
  • Added cert alias
  • Simplified the matcher as requested (hasAnyName(), has(ignoringParenCasts(cxxThisExpr())
  • Remove empty lines and synchronized the corresponding comment with the Release Notes.
Apr 12 2019, 11:18 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

I'll update the patch based on the comments.
Just a note about the false positive ratio. In LibreOffice we run other static analyzers too, that's why there were less positive catches there than false positives. For example, PVS studio also catches unprotected copy assignment operators. Some of these issues were already fixed before I run this new check on the code:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e5e0cc68f70d35e1849aeaf21c0ce68afd6a1f59

Apr 11 2019, 12:48 PM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2019

ztamas added a reviewer for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment: JonasToth.
Apr 10 2019, 5:43 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

On LibreOffice source code I found 36 catches with this check.
16 of them was worth to fix because in those cases the object state was changed in some way after a self-assignment:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3a5d78365dd172881c16c03e67f2d170ffc6d7d4

Apr 10 2019, 5:37 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

On llvm source code the check finds three suspicious methods:

/home/zolnai/libreoffice/clang/llvm-project/clang/lib/AST/NestedNameSpecifier.cpp:534:1: warning: operator=() might not handle self-assignment properly [bugprone-unhandled-self-assignment]
operator=(const NestedNameSpecifierLocBuilder &Other) {
Apr 10 2019, 5:28 AM · Restricted Project, Restricted Project, Restricted Project