Page MenuHomePhabricator

ztamas (Tamás Zolnai)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 5 2018, 9:46 AM (61 w, 6 d)

Recent Activity

Today

ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Add newlines to the end of the files.

Thu, Dec 12, 9:28 AM · Restricted Project, Restricted Project
ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Update code based on reviewer comments.

Thu, Dec 12, 9:18 AM · Restricted Project, Restricted Project

Mon, Dec 9

ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Remove anonymus namespace

Mon, Dec 9, 7:19 AM · Restricted Project, Restricted Project
ztamas updated the diff for D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

Fixes small things mentioned by reviewer commments.

Mon, Dec 9, 4:59 AM · Restricted Project, Restricted Project

Sun, Dec 8

ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I run the new check on LLVM codebase with the option CharTypdefsToIgnore = "int8_t".
The check produced 12 findings.

Sun, Dec 8, 6:04 AM · Restricted Project, Restricted Project
ztamas added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I run the new check on LibreOffice codebase with the option CharTypdefsToIgnore = "sal_Int8".
The check produced 32 findings.

Sun, Dec 8, 5:55 AM · Restricted Project, Restricted Project
ztamas created D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Sun, Dec 8, 5:22 AM · Restricted Project, Restricted Project

May 23 2019

ztamas committed rGdab31924e9c7: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment (authored by ztamas).
[clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment
May 23 2019, 1:28 PM
ztamas committed rL361550: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
[clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment
May 23 2019, 1:28 PM
ztamas committed rCTE361550: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
[clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment
May 23 2019, 1:28 PM
ztamas closed D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
May 23 2019, 1:27 PM · Restricted Project

May 22 2019

ztamas updated the diff for D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.

Link burprone module to cert module

May 22 2019, 9:16 AM · Restricted Project
ztamas updated the diff for D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.

Fixed docs.

May 22 2019, 5:51 AM · Restricted Project

May 21 2019

ztamas added a reviewer for D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment: aaron.ballman.
May 21 2019, 6:03 AM · Restricted Project
ztamas created D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.
May 21 2019, 6:00 AM · Restricted Project

May 20 2019

ztamas committed rG11fa0ee8f401: [clang-tidy] Sort this list alphabetically (authored by ztamas).
[clang-tidy] Sort this list alphabetically
May 20 2019, 3:37 AM
ztamas committed rL361138: [clang-tidy] Sort this list alphabetically.
[clang-tidy] Sort this list alphabetically
May 20 2019, 3:37 AM
ztamas committed rCTE361138: [clang-tidy] Sort this list alphabetically.
[clang-tidy] Sort this list alphabetically
May 20 2019, 3:37 AM

May 12 2019

ztamas committed rCTE360540: [clang-tidy] new check: bugprone-unhandled-self-assignment.
[clang-tidy] new check: bugprone-unhandled-self-assignment
May 12 2019, 5:26 AM
ztamas committed rGde7a30cb0a0f: [clang-tidy] new check: bugprone-unhandled-self-assignment (authored by ztamas).
[clang-tidy] new check: bugprone-unhandled-self-assignment
May 12 2019, 5:24 AM
ztamas committed rL360540: [clang-tidy] new check: bugprone-unhandled-self-assignment.
[clang-tidy] new check: bugprone-unhandled-self-assignment
May 12 2019, 5:24 AM
ztamas closed D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
May 12 2019, 5:23 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

I definitely want to see the diagnostic text changed away from "might be" -- that's too noncommittal for my tastes. I'd also like to see the additional test case (I suspect it will just work out of the box, but if it doesn't, it would be good to know about it). The CERT alias is a bit more of a grey area -- I'd like to insist on it being added because it's trivial, it improves the behavior of this check by introducing an option some users will want, and checks conforming to coding standards are always more compelling than one-off checks. However, you seem very resistant to that and I don't want to add to your work load if you are opposed to doing it, so I don't insist on the change.

May 9 2019, 4:36 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

copy operator -> copy assignment operator

May 9 2019, 4:27 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Changed "might not" to "does not" in the warning message.
Added the requested test case with the swapped template arguments.

May 9 2019, 4:26 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Ping.
Is it good to go or is there anything else I need to include in this patch?
Among the lots of idea, I'm not sure which is just brainstorming and which is a change request.
The check seems to work (has useful catches and does not produce too many false positives), however, it does not conform with the corresponding cert rule. I expect that a cert alias with an option can be added in a follow-up patch (option to ignore ThisHasSuspiciousField pattern). The bugprone-* check would have the same default behavior as it has now in this patch. So adding the cert alias would not change this behavior, right? In this case, this code change can be added in a separate patch I guess.

May 5 2019, 5:05 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Better handling of template and non-template self-copy

Apr 28 2019, 3:17 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Ok, is there anything else should be included in this patch?
I saw more ideas about how to extend the functionality (custom pointers, fix-it, etc). I interpreted these ideas as nice-to-have things for the future.

Apr 25 2019, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
ztamas abandoned D60664: [git-svn] Add a username option for push command.
Apr 25 2019, 9:20 AM · Restricted Project

Apr 24 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Remove outdated comment from docs.

Apr 24 2019, 3:27 AM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Mark some comments Done, which were handled some way.

Apr 23 2019, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

I also reformatted the code with clang-format.

Apr 23 2019, 11:53 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Make the check to work with templates too

Apr 23 2019, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 11:15 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Ok, so I removed the alias from cert module and added CERT rule link as a "see also".
So I think we solved the problem that things do not conform with the CERT requirements and can focus on the actual problem.

Apr 23 2019, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Added missing fullstop
Added a new test cases making sure that HasNoSelfCheck works correctly
Added template instantiation to tests
Remove the alias from cert module and add the CERT link as a see also

Apr 23 2019, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 23 2019, 8:31 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Add false positive test cases.
Added a note about template related limitation to the docs.

Apr 22 2019, 6:55 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60664: [git-svn] Add a username option for push command.

Should we (either instead or as well) make the default username try git config llvm.username before falling back to the local user? That way people can set it with git config llvm.username xyz or, if they work with a lot of llvm checkouts, git config --global llvm.username xyz instead of having to specify it every time.

Apr 22 2019, 5:02 AM · Restricted Project

Apr 16 2019

ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 16 2019, 8:17 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 16 2019, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Update patch based on reviewer comments.

Apr 16 2019, 7:47 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2019

ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 14 2019, 7:19 AM · Restricted Project, Restricted Project, Restricted Project
ztamas retitled D60664: [git-svn] Add a username option for push command from [git-svn] Add a username option for puch command to [git-svn] Add a username option for push command.
Apr 14 2019, 6:08 AM · Restricted Project
ztamas updated the diff for D60664: [git-svn] Add a username option for push command.

Fixed commit message

Apr 14 2019, 6:07 AM · Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Missed to syncronize ReleasNotes with the corresponding doc.

Apr 14 2019, 6:05 AM · Restricted Project, Restricted Project, Restricted Project
ztamas created D60664: [git-svn] Add a username option for push command.
Apr 14 2019, 5:57 AM · Restricted Project
ztamas committed rG065480daf2e9: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop… (authored by ztamas).
[clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop…
Apr 14 2019, 5:49 AM
ztamas committed rCTE358356: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop….
[clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop…
Apr 14 2019, 5:48 AM
ztamas committed rL358356: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop….
[clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop…
Apr 14 2019, 5:48 AM
ztamas closed D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Apr 14 2019, 5:48 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2019

ztamas added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

In the meantime, I've got the commit access, so I'll give it a try to push this myself.

Apr 13 2019, 7:39 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to rL358333: [clang-tidy] Use back-tick here.

It was my first commit, to see whether everything works.

Apr 13 2019, 7:39 AM
ztamas committed rG4dbcc3cf7430: [clang-tidy] Use back-tick here (authored by ztamas).
[clang-tidy] Use back-tick here
Apr 13 2019, 7:31 AM
ztamas committed rCTE358333: [clang-tidy] Use back-tick here.
[clang-tidy] Use back-tick here
Apr 13 2019, 7:31 AM
ztamas committed rL358333: [clang-tidy] Use back-tick here.
[clang-tidy] Use back-tick here
Apr 13 2019, 7:31 AM

Apr 12 2019

ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Documentation fixes.

Apr 12 2019, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 12 2019, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

Updated the code based on reviewer comments:

  • Alphabetical order in BugproneTidyModule.cpp
  • Handling of auto_ptr
  • Test cases for template classes (I made the check ignore these case otherwise this can lead to false positives)
  • Added cert alias
  • Simplified the matcher as requested (hasAnyName(), has(ignoringParenCasts(cxxThisExpr())
  • Remove empty lines and synchronized the corresponding comment with the Release Notes.
Apr 12 2019, 11:18 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2019

ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

I'll update the patch based on the comments.
Just a note about the false positive ratio. In LibreOffice we run other static analyzers too, that's why there were less positive catches there than false positives. For example, PVS studio also catches unprotected copy assignment operators. Some of these issues were already fixed before I run this new check on the code:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e5e0cc68f70d35e1849aeaf21c0ce68afd6a1f59

Apr 11 2019, 12:48 PM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2019

ztamas added a reviewer for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment: JonasToth.
Apr 10 2019, 5:43 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

On LibreOffice source code I found 36 catches with this check.
16 of them was worth to fix because in those cases the object state was changed in some way after a self-assignment:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3a5d78365dd172881c16c03e67f2d170ffc6d7d4

Apr 10 2019, 5:37 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.

On llvm source code the check finds three suspicious methods:

/home/zolnai/libreoffice/clang/llvm-project/clang/lib/AST/NestedNameSpecifier.cpp:534:1: warning: operator=() might not handle self-assignment properly [bugprone-unhandled-self-assignment]
operator=(const NestedNameSpecifierLocBuilder &Other) {
Apr 10 2019, 5:28 AM · Restricted Project, Restricted Project, Restricted Project
ztamas created D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 10 2019, 5:22 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2019

ztamas added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

Ok, I just fixed a remaining typo and rebased the patch to have it work with a more recent version of the code base, so I guess this patch is ready for commit.
Jonas, can you commit this change for me? I still don't have commit access, I just applied for it some days ago.

Apr 9 2019, 1:24 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

Fixed a typo in release notes.
Rebased the patch withh git pull -r.

Apr 9 2019, 1:15 AM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2019

ztamas added inline comments to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Apr 2 2019, 6:33 AM · Restricted Project, Restricted Project, Restricted Project
ztamas updated the diff for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

Fixed typo.
Mentioned the default value in release notes.

Apr 2 2019, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 31 2019

ztamas updated the diff for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

Make 16 the default value of MagnitudeBitsUpperLimit option.

Mar 31 2019, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I think it's the easiest way to specify the bits of the ineteger type to limit the catches. In real life, I met with this overflow / infinite loop problem with 16-bit short type, so I think the real use cases are 8 and 16 bit integers. It seems intuitive to me to use the size of the loop variable's type to separate those catches which can lead broken functionality in practice from those use cases which are just integer incompatibilities.

Given your experience and the false positive rate in some projects, should we maybe default to 16 for that option?

Mar 31 2019, 6:20 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2019

ztamas updated the diff for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

Rebased patch on https://github.com/llvm/llvm-project.git repo.
Updated the docs based on review comments.

Mar 28 2019, 2:15 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2019

ztamas added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I think in general this is a good direction. What do you think about other heuristics?
E.g. one could say that a vector will not contain more then X GB or similar. That is probably more complicated to figure out though.

Mar 27 2019, 11:34 PM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I found a project where the bugprone-too-small-loop-variable was used:
https://github.com/openMSX/openMSX/commit/55006063daffa90941d4c3f9b0034e494d9cf45a

Mar 27 2019, 2:38 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a reviewer for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable: JonasToth.
Mar 27 2019, 1:54 AM · Restricted Project, Restricted Project, Restricted Project
ztamas added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I run the check with and without the option on llvm source code. Without the option I found 370 catches, while setting MagnitudeBitsUpperLimit to 30 I found only two catches:

Mar 27 2019, 1:47 AM · Restricted Project, Restricted Project, Restricted Project
ztamas created D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Mar 27 2019, 1:43 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2018

ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

Thank you very much for the patch!

Nov 12 2018, 9:32 AM · Restricted Project

Nov 11 2018

ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

Agree. I think this check is good to go.

I would commit this check tomorrow if that is ok with you.

Nov 11 2018, 12:57 PM · Restricted Project
ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
  • Add requested test case
Nov 11 2018, 12:55 PM · Restricted Project
ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

I would be very interested why these false positives are created. Is there a way to avoid them and maybe it makes sense to already add FIXME at the possible places the check needs improvements.

voidForLoopFalsePositive() and voidForLoopFalsePositive2() test cases covers most of the false positives found in LibreOffice.

I would not consider them as full false positives, the constants that are created allow to filter more, but type-based the diagnostics are correct. So I think that is fine. If the constants would be a big value, the check does find a real problem.

Nov 11 2018, 10:42 AM · Restricted Project
ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
  • Fix comment
Nov 11 2018, 8:40 AM · Restricted Project
ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

Also found some new false positives related to macros. The number of all false positives is around 38, which is still seems good to me.

I would be very interested why these false positives are created. Is there a way to avoid them and maybe it makes sense to already add FIXME at the possible places the check needs improvements.

Nov 11 2018, 8:36 AM · Restricted Project
ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
  • Add new test cases based on findings in LibreOffice code base
Nov 11 2018, 8:30 AM · Restricted Project

Nov 10 2018

ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

I also tested on LLVm code.
The output is here:
https://gist.github.com/tzolnai/fe4f23031d3f9fdbdbf1ee38abda00a4

Nov 10 2018, 2:42 PM · Restricted Project
ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

I have the result after running the current version if the check.

Nov 10 2018, 2:17 PM · Restricted Project

Nov 9 2018

ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

LGTM.
Did you run this check in its final form against a bigger project? These results would be interesting.

Nov 9 2018, 3:11 PM · Restricted Project
ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
  • Make local functions static
Nov 9 2018, 10:05 AM · Restricted Project

Nov 7 2018

ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
  • no else after return
  • static constexpr llvm::StringLiteral
  • CamelCase variable names
  • Remove unneeded isIntegerType() check
  • Better terminology: not terminating condition, but iteration's upper bound.
Nov 7 2018, 6:08 AM · Restricted Project

Nov 5 2018

ztamas added inline comments to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
Nov 5 2018, 1:26 PM · Restricted Project
ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
  • Add a range-based loop test case
  • Restructure test cases a bit
  • Fix-up comments, position, punctuation
Nov 5 2018, 12:35 PM · Restricted Project
ztamas added inline comments to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
Nov 5 2018, 12:25 PM · Restricted Project
ztamas added inline comments to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
Nov 5 2018, 12:25 PM · Restricted Project

Nov 4 2018

ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

Mark all handled inline comments as Done.

Nov 4 2018, 2:17 AM · Restricted Project

Nov 3 2018

ztamas added a comment to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

Hmm, i thought Clang has some warning for this, but I was wrong... Did you think to implement this check as Clang warning?

That is an interesting point actually -- maybe it'd be worth doing that, and if more powerful analysis is required, Static Analyzer would be the next step. I haven't actually implemented any 'regular' clang warning, so I'm not sure.

Nov 3 2018, 12:54 AM · Restricted Project
ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.

Update docs based on reviewer comment

Nov 3 2018, 12:30 AM · Restricted Project
ztamas added inline comments to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
Nov 3 2018, 12:28 AM · Restricted Project
ztamas updated the diff for D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
  • Analyze template dependant for loops too (add some test cases)
  • Use double backticks for marking code in docs
Nov 3 2018, 12:19 AM · Restricted Project

Nov 2 2018

ztamas added inline comments to D53974: [clang-tidy] new check: bugprone-too-small-loop-variable.
Nov 2 2018, 2:37 PM · Restricted Project