Page MenuHomePhabricator

zhizhouy (Zhizhou Yang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:18 PM (187 w, 5 d)

Recent Activity

Jun 5 2019

zhizhouy added a comment to D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on.

Friendly ping :)

Jun 5 2019, 2:09 PM · Restricted Project

May 29 2019

zhizhouy added inline comments to D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on.
May 29 2019, 2:49 PM · Restricted Project
zhizhouy updated the diff for D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on.

Fixed comment.

May 29 2019, 2:49 PM · Restricted Project
zhizhouy updated the summary of D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on.
May 29 2019, 2:40 PM · Restricted Project
zhizhouy updated the diff for D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on.

Renaming the opt.

May 29 2019, 2:34 PM · Restricted Project
zhizhouy added a comment to D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on.

IIUC, user will always call clang to pass integrated as flag. Actually I also used to consider checking UseIntegratedAS-ish in PassBuilder,
but looking for a codegen options in PassBuilder seems going to break the integrity. Solutions for this is appreciated.

May 29 2019, 2:33 PM · Restricted Project
zhizhouy created D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on.
May 29 2019, 1:56 PM · Restricted Project

Nov 29 2018

zhizhouy committed rL347897: set default max-page-size to 4KB in lld for Android Aarch64.
set default max-page-size to 4KB in lld for Android Aarch64
Nov 29 2018, 10:55 AM
zhizhouy committed rC347897: set default max-page-size to 4KB in lld for Android Aarch64.
set default max-page-size to 4KB in lld for Android Aarch64
Nov 29 2018, 10:55 AM
zhizhouy closed D55029: set default max-page-size to 4KB in lld for Android Aarch64.
Nov 29 2018, 10:55 AM
zhizhouy added a comment to D55029: set default max-page-size to 4KB in lld for Android Aarch64.

Thanks for the review and comments!

Nov 29 2018, 10:43 AM

Nov 28 2018

zhizhouy created D55029: set default max-page-size to 4KB in lld for Android Aarch64.
Nov 28 2018, 2:28 PM

Nov 12 2018

zhizhouy committed rL346720: Introduce DebugCounter into ConstProp pass.
Introduce DebugCounter into ConstProp pass
Nov 12 2018, 4:34 PM
zhizhouy closed D50094: Introduce DebugCounter into ConstProp pass.
Nov 12 2018, 4:34 PM

Nov 10 2018

zhizhouy added a comment to D50094: Introduce DebugCounter into ConstProp pass.

Thanks for the heads up. Sorry for the delay, I will commit it soon.

Nov 10 2018, 9:54 PM

Oct 23 2018

zhizhouy committed rL345085: Print out DebugCounter info with -print-debug-counter.
Print out DebugCounter info with -print-debug-counter
Oct 23 2018, 2:54 PM
zhizhouy closed D50031: Add pass to print out DebugCounter info.
Oct 23 2018, 2:54 PM

Oct 2 2018

zhizhouy added a comment to D50031: Add pass to print out DebugCounter info.

Thanks for reviewing.

Oct 2 2018, 6:36 PM

Sep 26 2018

zhizhouy added a comment to D52314: Document bisect-skip-count.

LGTM.

Sep 26 2018, 1:46 PM
zhizhouy added a reviewer for D50031: Add pass to print out DebugCounter info: greened.
Sep 26 2018, 1:38 PM

Sep 19 2018

zhizhouy updated the diff for D50094: Introduce DebugCounter into ConstProp pass.

Using another vector to deal with newly added instructions. Thanks!

Sep 19 2018, 6:31 PM

Sep 12 2018

zhizhouy added a comment to D50031: Add pass to print out DebugCounter info.

Ping for suggestion, thanks!

Sep 12 2018, 2:11 PM

Sep 5 2018

zhizhouy added a comment to D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

The counter name seems too long, how about dropping 'transform'.

Sep 5 2018, 5:40 PM
zhizhouy added a comment to D50031: Add pass to print out DebugCounter info.

Thanks for reviewing.

Sep 5 2018, 2:16 PM

Aug 15 2018

zhizhouy added a reviewer for D50210: Introduce DebugCounter into MergedLoadStoreMotion pass: davide.
Aug 15 2018, 5:43 PM
zhizhouy added a comment to D50094: Introduce DebugCounter into ConstProp pass.

ping for reviewing... thanks!

Aug 15 2018, 5:43 PM
zhizhouy added a comment to D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

ping for reviewing... thanks!

Aug 15 2018, 5:43 PM
zhizhouy added a comment to D50092: Introduce DebugCounter into DCE pass.

ping for reviewing... thanks!

Aug 15 2018, 5:43 PM
zhizhouy added a comment to D50031: Add pass to print out DebugCounter info.

Ping for the updated approach...

Aug 15 2018, 3:41 PM

Aug 8 2018

zhizhouy updated the diff for D50031: Add pass to print out DebugCounter info.

Just noticed that calling print() function at destructor (like what Statistic class did) when option is set will be more straight forward.

Aug 8 2018, 4:07 PM

Aug 2 2018

zhizhouy created D50210: Introduce DebugCounter into MergedLoadStoreMotion pass.
Aug 2 2018, 6:38 PM
zhizhouy updated subscribers of D50031: Add pass to print out DebugCounter info.
Aug 2 2018, 4:16 PM
zhizhouy updated subscribers of D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.
Aug 2 2018, 4:13 PM
zhizhouy updated subscribers of D50092: Introduce DebugCounter into DCE pass.
Aug 2 2018, 4:12 PM
zhizhouy updated the diff for D50092: Introduce DebugCounter into DCE pass.

Add REQUIRES to test.

Aug 2 2018, 1:16 PM

Aug 1 2018

zhizhouy updated the diff for D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

Put test under X86/ directory, as -mtriple specified.

Aug 1 2018, 2:19 PM
zhizhouy updated the diff for D50094: Introduce DebugCounter into ConstProp pass.

Sorry for misunderstanding, comments fixed.

Aug 1 2018, 1:48 PM
zhizhouy updated the diff for D50094: Introduce DebugCounter into ConstProp pass.

Comments fixed.

Aug 1 2018, 12:16 PM

Jul 31 2018

zhizhouy updated the diff for D50094: Introduce DebugCounter into ConstProp pass.

Use a vector to ensure worklist iterated in stable order.

Jul 31 2018, 6:28 PM
zhizhouy created D50094: Introduce DebugCounter into ConstProp pass.
Jul 31 2018, 11:29 AM
zhizhouy created D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.
Jul 31 2018, 11:26 AM
zhizhouy created D50092: Introduce DebugCounter into DCE pass.
Jul 31 2018, 11:23 AM
zhizhouy added a comment to D50033: Introduce DebugCounter into DevRemPairs pass.

Thanks for reviewing.

Jul 31 2018, 11:06 AM
zhizhouy added a comment to D50033: Introduce DebugCounter into DevRemPairs pass.

Can you add a comment to the test file to explain what is happening there? I think we've specified that we will skip the 1st test, perform the transform on the 2nd test, and then perform no other transforms? Should there be a 4th function to verify that last case?

Jul 31 2018, 10:45 AM
zhizhouy updated the diff for D50033: Introduce DebugCounter into DevRemPairs pass.
Jul 31 2018, 10:45 AM

Jul 30 2018

zhizhouy updated the diff for D50031: Add pass to print out DebugCounter info.

Thanks for reviewing. Comments fixed.

Jul 30 2018, 10:08 PM
zhizhouy created D50033: Introduce DebugCounter into DevRemPairs pass.
Jul 30 2018, 5:58 PM
zhizhouy created D50031: Add pass to print out DebugCounter info.
Jul 30 2018, 5:48 PM

Jul 23 2018

zhizhouy updated the diff for D49560: Add support to track total counts for DebugCounter.

Fixed the failure issue.

Jul 23 2018, 1:19 PM

Jul 20 2018

zhizhouy updated the diff for D49560: Add support to track total counts for DebugCounter.

Fix CodeGen/AMDGPU test failures, by adding Counters only when skip/count is set.
I believe this will save many memory when skip/count is not set, thus fixing the problem.

Jul 20 2018, 6:20 PM
zhizhouy added a comment to D49560: Add support to track total counts for DebugCounter.

Running ninja check-llvm after applying this on top of r337631, I see many test failures in CodeGen/AMDGPU. Are you seeing these, as well?

Jul 20 2018, 5:16 PM
zhizhouy added inline comments to D49560: Add support to track total counts for DebugCounter.
Jul 20 2018, 2:20 PM
zhizhouy updated the diff for D49560: Add support to track total counts for DebugCounter.
Jul 20 2018, 2:20 PM
zhizhouy added inline comments to D49560: Add support to track total counts for DebugCounter.
Jul 20 2018, 1:39 PM
zhizhouy updated the diff for D49560: Add support to track total counts for DebugCounter.

Added a unit test for the change.

Jul 20 2018, 1:38 PM

Jul 19 2018

zhizhouy created D49560: Add support to track total counts for DebugCounter.
Jul 19 2018, 10:46 AM

Mar 29 2017

zhizhouy updated the diff for D30760: Record command lines in objects built by clang, Clang part.

Added testcase for recording other useful options.

Mar 29 2017, 1:14 PM
zhizhouy updated the diff for D31315: Record command lines in objects built by clang, LLVM part.

Moved test into test/DebugInfo/X86.

Mar 29 2017, 1:06 PM
zhizhouy updated the diff for D30760: Record command lines in objects built by clang, Clang part.

Added two more testcases, one is options with both grecord-gcc-switches and gno-record-gcc-switches; the other one is testing if "-o -" is omitted correctly.

Mar 29 2017, 1:05 PM

Mar 24 2017

zhizhouy updated the diff for D30760: Record command lines in objects built by clang, Clang part.

Added tests into test/Driver/debug-options.c. Thanks.

Mar 24 2017, 2:25 PM
zhizhouy updated the diff for D30760: Record command lines in objects built by clang, Clang part.

Checked both grecord-gcc-swtiches and gno-record-gcc-switches.

Mar 24 2017, 1:57 PM
zhizhouy updated the diff for D31315: Record command lines in objects built by clang, LLVM part.

Fixed StringRef related problem.

Mar 24 2017, 1:55 PM

Mar 23 2017

zhizhouy updated the diff for D30760: Record command lines in objects built by clang, Clang part.

I am reusing the DwarfDebugFlags to try to solve this bug now.

Mar 23 2017, 5:43 PM
zhizhouy created D31315: Record command lines in objects built by clang, LLVM part.
Mar 23 2017, 5:42 PM

Mar 21 2017

zhizhouy added a comment to D30760: Record command lines in objects built by clang, Clang part.

Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it seems that it really did the same work of recording command line options.

Mar 21 2017, 5:50 PM
zhizhouy updated the diff for D30760: Record command lines in objects built by clang, Clang part.

Fixed George's comments.

Mar 21 2017, 2:31 PM

Mar 20 2017

zhizhouy added reviewers for D30760: Record command lines in objects built by clang, Clang part: llozano, echristo.
Mar 20 2017, 6:23 PM
zhizhouy updated the diff for D30760: Record command lines in objects built by clang, Clang part.

Re-implemented the the patch: reusing -grecord-gcc-switches from gcc instead of passing arguments to DiagnosticsEngine.

Mar 20 2017, 6:08 PM

Mar 8 2017

zhizhouy removed rL LLVM as the repository for D30760: Record command lines in objects built by clang, Clang part.
Mar 8 2017, 3:39 PM
zhizhouy updated the summary of D30760: Record command lines in objects built by clang, Clang part.
Mar 8 2017, 2:57 PM
zhizhouy edited reviewers for D30760: Record command lines in objects built by clang, Clang part, added: george.burgess.iv; removed: gbiv.
Mar 8 2017, 2:54 PM
zhizhouy created D30760: Record command lines in objects built by clang, Clang part.
Mar 8 2017, 2:48 PM

May 25 2016

zhizhouy added a comment to D20002: Fix Bug 11740: Turn off -g when there are directive file debug info.

Hi David,

May 25 2016, 12:43 PM

May 20 2016

zhizhouy updated the diff for D20002: Fix Bug 11740: Turn off -g when there are directive file debug info.

Updated the test file, removed the useless test command,
and added some description about the test case.

May 20 2016, 1:21 PM

May 16 2016

zhizhouy added inline comments to D20002: Fix Bug 11740: Turn off -g when there are directive file debug info.
May 16 2016, 3:02 PM

May 5 2016

zhizhouy added a comment to D20002: Fix Bug 11740: Turn off -g when there are directive file debug info.

I think the turning off of the GenDwarfForAssembly at the parsing stage
will lead to emitting no new debug info by the assembler at emitting stage.
So this still works for other debug info.

May 5 2016, 5:07 PM
zhizhouy retitled D20002: Fix Bug 11740: Turn off -g when there are directive file debug info from to Fix Bug 11740: Turn off -g when there are directive file debug info.
May 5 2016, 4:28 PM