Page MenuHomePhabricator

zhaoqin (Qin Zhao)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2013, 8:03 AM (316 w, 15 h)

Recent Activity

Oct 7 2016

zhaoqin committed rL283598: [esan] Fix ESan test failure on Debian Sid bot.
[esan] Fix ESan test failure on Debian Sid bot
Oct 7 2016, 2:02 PM
zhaoqin closed D25380: [esan] Fix ESan test failure on Debian Sid bot by committing rL283598: [esan] Fix ESan test failure on Debian Sid bot.
Oct 7 2016, 2:02 PM
zhaoqin retitled D25380: [esan] Fix ESan test failure on Debian Sid bot from to [esan] Fix ESan test failure on Debian Sid bot.
Oct 7 2016, 1:57 PM

Oct 4 2016

zhaoqin committed rL283139: [esan] Fix ESan test failure on Debian Sid bot.
[esan] Fix ESan test failure on Debian Sid bot
Oct 4 2016, 1:06 AM
zhaoqin closed D25193: [esan] Fix ESan test failure on Debian Sid bot by committing rL283139: [esan] Fix ESan test failure on Debian Sid bot.
Oct 4 2016, 1:06 AM

Oct 3 2016

zhaoqin updated the diff for D25193: [esan] Fix ESan test failure on Debian Sid bot.

remove prefix k_

Oct 3 2016, 12:06 PM
zhaoqin updated the diff for D25193: [esan] Fix ESan test failure on Debian Sid bot.

PTAL

Oct 3 2016, 11:47 AM
zhaoqin updated D25193: [esan] Fix ESan test failure on Debian Sid bot.
Oct 3 2016, 9:32 AM
zhaoqin added a comment to D25193: [esan] Fix ESan test failure on Debian Sid bot.

Update the commit message.

Oct 3 2016, 9:32 AM
zhaoqin updated D25193: [esan] Fix ESan test failure on Debian Sid bot.
Oct 3 2016, 9:32 AM
zhaoqin updated subscribers of D25193: [esan] Fix ESan test failure on Debian Sid bot.
Oct 3 2016, 9:11 AM
zhaoqin retitled D25193: [esan] Fix ESan test failure on Debian Sid bot from to [esan] Fix ESan test failure on Debian Sid bot.
Oct 3 2016, 9:10 AM

Sep 23 2016

zhaoqin accepted D23799: [ESan][MIPS] Adds support for MIPS64.

LGTM

Sep 23 2016, 8:09 AM · Restricted Project

Sep 21 2016

zhaoqin accepted D24335: [ESan] [MIPS] Fix tests mmap-shadow-conflict.c and struct-simple.cpp on MIPS.

Please update the commit message, because I do not see any fix related to mmap-shadow-conflict.c

Sep 21 2016, 1:49 PM · Restricted Project
zhaoqin added a comment to D23799: [ESan][MIPS] Adds support for MIPS64.

A few questions.
Nothing major, but better to have another round.

Sep 21 2016, 1:44 PM · Restricted Project
zhaoqin accepted D24334: [EfficiencySanitizer] Using '$' instead of '#' for struct counter name.

LGTM with nits
Please test before commit.

Sep 21 2016, 12:20 PM · Restricted Project

Sep 14 2016

zhaoqin requested changes to D23799: [ESan][MIPS] Adds support for MIPS64.

I am not sure this CL can be build on non-mips64.
Could you please test on a non-mips64 (e.g. x86_64) so we can avoid unnecessary bot failure?

Sep 14 2016, 12:30 PM · Restricted Project

Sep 8 2016

zhaoqin requested changes to D24334: [EfficiencySanitizer] Using '$' instead of '#' for struct counter name.

We use '#' to make the name less likely to conflict with user defined variables.
Can we use some other char that cannot be used by program variables e.g., '+' or '-' instead of '_'.
Also, you also need update names in test/Instrumentation/EfficiencySanitizer/ and runtime tests.

Sep 8 2016, 9:39 AM · Restricted Project
zhaoqin committed rL280954: Revert "[ESan][MIPS] Adds support for MIPS64".
Revert "[ESan][MIPS] Adds support for MIPS64"
Sep 8 2016, 9:18 AM
zhaoqin closed D24350: Revert "[ESan][MIPS] Adds support for MIPS64" by committing rL280954: Revert "[ESan][MIPS] Adds support for MIPS64".
Sep 8 2016, 9:18 AM
zhaoqin added a comment to D24350: Revert "[ESan][MIPS] Adds support for MIPS64".

Just a pure revert, right?

Sep 8 2016, 9:17 AM
zhaoqin updated D24350: Revert "[ESan][MIPS] Adds support for MIPS64".
Sep 8 2016, 9:13 AM
zhaoqin added a reviewer for D24350: Revert "[ESan][MIPS] Adds support for MIPS64": slthakur.
Sep 8 2016, 9:10 AM
zhaoqin retitled D24350: Revert "[ESan][MIPS] Adds support for MIPS64" from to Revert "[ESan][MIPS] Adds support for MIPS64".
Sep 8 2016, 9:03 AM

Jul 6 2016

zhaoqin committed rL274727: [esan|cfrag] Handle binaries built with -esan-aux-field-info=false.
[esan|cfrag] Handle binaries built with -esan-aux-field-info=false
Jul 6 2016, 8:27 PM
zhaoqin closed D22020: [esan|cfrag] Handle binaries built with -esan-small-binary by committing rL274727: [esan|cfrag] Handle binaries built with -esan-aux-field-info=false.
Jul 6 2016, 8:27 PM
zhaoqin committed rL274726: [esan:cfrag] Add option -esan-aux-field-info.
[esan:cfrag] Add option -esan-aux-field-info
Jul 6 2016, 8:27 PM
zhaoqin closed D22019: [esan:cfrag] Add option -esan-small-binary by committing rL274726: [esan:cfrag] Add option -esan-aux-field-info.
Jul 6 2016, 8:27 PM
zhaoqin updated D22020: [esan|cfrag] Handle binaries built with -esan-small-binary.
Jul 6 2016, 8:11 PM
zhaoqin updated D22019: [esan:cfrag] Add option -esan-small-binary.
Jul 6 2016, 8:11 PM
zhaoqin updated the diff for D22020: [esan|cfrag] Handle binaries built with -esan-small-binary.

rename -esan-small-binary to -esan-aux-field-info

Jul 6 2016, 8:08 PM
zhaoqin updated the diff for D22019: [esan:cfrag] Add option -esan-small-binary.

rename -esan-small-binar to -esan-aux-field-info

Jul 6 2016, 8:07 PM
zhaoqin added a comment to D22019: [esan:cfrag] Add option -esan-small-binary.

I wonder if this flag could be named differently.
"small binary" sounds awfully generic and non-descriptive.

Jul 6 2016, 7:40 PM
zhaoqin updated the diff for D22019: [esan:cfrag] Add option -esan-small-binary.

adjust indentation

Jul 6 2016, 12:38 PM
zhaoqin added a comment to D22020: [esan|cfrag] Handle binaries built with -esan-small-binary.
Jul 6 2016, 12:33 PM
zhaoqin updated the diff for D22019: [esan:cfrag] Add option -esan-small-binary.

add comment
move createCacheFragAuxGV invocation point to avoid test output changes

Jul 6 2016, 12:32 PM
zhaoqin updated the diff for D22020: [esan|cfrag] Handle binaries built with -esan-small-binary.

add comment and hasAuxFieldInfo method

Jul 6 2016, 12:31 PM

Jul 5 2016

zhaoqin retitled D22020: [esan|cfrag] Handle binaries built with -esan-small-binary from to [esan|cfrag] Handle binaries built with -esan-small-binary.
Jul 5 2016, 2:46 PM
zhaoqin retitled D22019: [esan:cfrag] Add option -esan-small-binary from to [esan:cfrag] Add option -esan-small-binary.
Jul 5 2016, 2:46 PM

Jul 1 2016

zhaoqin committed rL274421: [esan|cfrag] Add struct array access report.
[esan|cfrag] Add struct array access report
Jul 1 2016, 8:33 PM
zhaoqin closed D21595: [esan|cfrag] Add struct array access report by committing rL274421: [esan|cfrag] Add struct array access report.
Jul 1 2016, 8:33 PM
zhaoqin committed rL274420: [esan|cfrag] Add counters for struct array accesses.
[esan|cfrag] Add counters for struct array accesses
Jul 1 2016, 8:32 PM
zhaoqin closed D21594: [esan|cfrag] Add counters for struct array accesses by committing rL274420: [esan|cfrag] Add counters for struct array accesses.
Jul 1 2016, 8:32 PM
zhaoqin added a comment to D21594: [esan|cfrag] Add counters for struct array accesses.

Even without esan instrumentation, the same error.

Jul 1 2016, 3:45 PM
zhaoqin added a comment to D21594: [esan|cfrag] Add counters for struct array accesses.

You are right. What will happen is it will not look like a structure field
access, and will use i8 or something so it can do the calculation.
I'll paste a clang generated example in a bit

Jul 1 2016, 3:34 PM
zhaoqin added a comment to D21594: [esan|cfrag] Add counters for struct array accesses.

I do not think a negative index for struct field indexing is valid.

You are incorrect :)

Jul 1 2016, 11:13 AM
zhaoqin updated the diff for D21594: [esan|cfrag] Add counters for struct array accesses.

use getSExtValue instead of getZExtValue for GetElementPtr instr.

Jul 1 2016, 11:06 AM
zhaoqin updated the diff for D21595: [esan|cfrag] Add struct array access report.

change StructInfo

Jul 1 2016, 8:30 AM
zhaoqin updated the diff for D21594: [esan|cfrag] Add counters for struct array accesses.

refact StructInfo

Jul 1 2016, 8:30 AM
zhaoqin added a comment to D21594: [esan|cfrag] Add counters for struct array accesses.
Jul 1 2016, 8:29 AM
zhaoqin added inline comments to D21594: [esan|cfrag] Add counters for struct array accesses.
Jul 1 2016, 8:29 AM
zhaoqin updated D21594: [esan|cfrag] Add counters for struct array accesses.
Jul 1 2016, 8:26 AM

Jun 24 2016

zhaoqin added inline comments to D21594: [esan|cfrag] Add counters for struct array accesses.
Jun 24 2016, 9:20 AM

Jun 23 2016

zhaoqin added inline comments to D21594: [esan|cfrag] Add counters for struct array accesses.
Jun 23 2016, 6:42 PM

Jun 22 2016

zhaoqin updated the diff for D21595: [esan|cfrag] Add struct array access report.

Rename FieldCounters to Counters

Jun 22 2016, 8:43 AM
zhaoqin updated the diff for D21594: [esan|cfrag] Add counters for struct array accesses.

Rename FieldCounters to Counters

Jun 22 2016, 8:42 AM

Jun 21 2016

zhaoqin updated the diff for D21594: [esan|cfrag] Add counters for struct array accesses.

update comment to explain why we append the counter array.

Jun 21 2016, 8:53 PM
zhaoqin retitled D21595: [esan|cfrag] Add struct array access report from to [esan|cfrag] Add struct array access report.
Jun 21 2016, 8:32 PM
zhaoqin retitled D21594: [esan|cfrag] Add counters for struct array accesses from to [esan|cfrag] Add counters for struct array accesses.
Jun 21 2016, 8:26 PM

Jun 16 2016

zhaoqin committed rL272989: [esan|cfrag] Add the struct field size array in StructInfo.
[esan|cfrag] Add the struct field size array in StructInfo
Jun 16 2016, 9:57 PM
zhaoqin committed rL272988: [esan|cfrag] Add the struct field size array in StructInfo.
[esan|cfrag] Add the struct field size array in StructInfo
Jun 16 2016, 9:57 PM
zhaoqin closed D21341: [esan|cfrag] Add the struct field size array in StructInfo by committing rL272989: [esan|cfrag] Add the struct field size array in StructInfo.
Jun 16 2016, 9:57 PM
zhaoqin closed D21342: [esan|cfrag] Add the struct field size array in StructInfo by committing rL272988: [esan|cfrag] Add the struct field size array in StructInfo.
Jun 16 2016, 9:57 PM

Jun 15 2016

zhaoqin committed rL272810: [esan|cfrag] Minor cfrag report adjustment.
[esan|cfrag] Minor cfrag report adjustment
Jun 15 2016, 10:34 AM
zhaoqin closed D21351: [esan|cfrag] Minor cfrag report adjustment by committing rL272810: [esan|cfrag] Minor cfrag report adjustment.
Jun 15 2016, 10:34 AM
zhaoqin updated the diff for D21351: [esan|cfrag] Minor cfrag report adjustment.

PTAL

Jun 15 2016, 7:47 AM

Jun 14 2016

zhaoqin updated the diff for D21351: [esan|cfrag] Minor cfrag report adjustment.

add type printing size limit

Jun 14 2016, 3:14 PM
zhaoqin retitled D21351: [esan|cfrag] Minor cfrag report adjustment from [esan|cfrag] Report the struct info only if it has been used to [esan|cfrag] Minor cfrag report adjustment.
Jun 14 2016, 3:14 PM
zhaoqin retitled D21351: [esan|cfrag] Minor cfrag report adjustment from to [esan|cfrag] Report the struct info only if it has been used.
Jun 14 2016, 2:36 PM
zhaoqin retitled D21342: [esan|cfrag] Add the struct field size array in StructInfo from to [esan|cfrag] Add the struct field size array in StructInfo.
Jun 14 2016, 1:57 PM
zhaoqin retitled D21341: [esan|cfrag] Add the struct field size array in StructInfo from to [esan|cfrag] Add the struct field size array in StructInfo.
Jun 14 2016, 1:56 PM

Jun 10 2016

zhaoqin committed rL272442: [esan|cfrag] Handle complex GEP instr in the cfrag tool.
[esan|cfrag] Handle complex GEP instr in the cfrag tool
Jun 10 2016, 3:35 PM
zhaoqin closed D21242: [esan|cfrag] Handle complex GEP instr in the cfrag tool by committing rL272442: [esan|cfrag] Handle complex GEP instr in the cfrag tool.
Jun 10 2016, 3:35 PM
zhaoqin updated D21242: [esan|cfrag] Handle complex GEP instr in the cfrag tool.
Jun 10 2016, 2:24 PM
zhaoqin retitled D21242: [esan|cfrag] Handle complex GEP instr in the cfrag tool from to [esan|cfrag] Handle complex GEP instr in the cfrag tool.
Jun 10 2016, 1:53 PM

Jun 9 2016

zhaoqin committed rL272363: [esan|cfrag] Add the struct field offset array in StructInfo.
[esan|cfrag] Add the struct field offset array in StructInfo
Jun 9 2016, 7:17 PM
zhaoqin closed D21191: [esan|cfrag] Add the struct field offset array in StructInfo by committing rL272363: [esan|cfrag] Add the struct field offset array in StructInfo.
Jun 9 2016, 7:17 PM
zhaoqin committed rL272362: [esan|cfrag] Add the struct field offset array in StructInfo.
[esan|cfrag] Add the struct field offset array in StructInfo
Jun 9 2016, 7:16 PM
zhaoqin closed D21192: [esan|cfrag] Add the struct field offset array in StructInfo by committing rL272362: [esan|cfrag] Add the struct field offset array in StructInfo.
Jun 9 2016, 7:16 PM
zhaoqin committed rL272355: [esan|cfrag] Disable load/store instrumentation for cfrag.
[esan|cfrag] Disable load/store instrumentation for cfrag
Jun 9 2016, 5:55 PM
zhaoqin closed D21079: [esan|cfrag] Disable load/store instrumentation for cfrag by committing rL272355: [esan|cfrag] Disable load/store instrumentation for cfrag.
Jun 9 2016, 5:55 PM
zhaoqin retitled D21192: [esan|cfrag] Add the struct field offset array in StructInfo from to [esan|cfrag] Add the struct field offset array in StructInfo.
Jun 9 2016, 11:17 AM
zhaoqin retitled D21191: [esan|cfrag] Add the struct field offset array in StructInfo from to [esan|cfrag] Add the struct field offset array in StructInfo.
Jun 9 2016, 11:16 AM
zhaoqin added a comment to D21079: [esan|cfrag] Disable load/store instrumentation for cfrag.

Since I am not sure how to change Cl options to meet both reviews. I implement a different way to skip load/store instrumentation without changing options.
PTAL.

Jun 9 2016, 8:43 AM
zhaoqin updated the diff for D21079: [esan|cfrag] Disable load/store instrumentation for cfrag.

revert changes on options.

Jun 9 2016, 8:39 AM
zhaoqin retitled D21079: [esan|cfrag] Disable load/store instrumentation for cfrag from [esan|cfrag] Disable load/store/memintrinsic instrumentation for cfrag to [esan|cfrag] Disable load/store instrumentation for cfrag.
Jun 9 2016, 8:19 AM

Jun 8 2016

zhaoqin added inline comments to D21079: [esan|cfrag] Disable load/store instrumentation for cfrag.
Jun 8 2016, 11:24 AM
zhaoqin updated the diff for D21079: [esan|cfrag] Disable load/store instrumentation for cfrag.

Adds instrumentation control in Options

Jun 8 2016, 10:22 AM
zhaoqin added a comment to D21079: [esan|cfrag] Disable load/store instrumentation for cfrag.
Jun 8 2016, 10:21 AM
zhaoqin retitled D21079: [esan|cfrag] Disable load/store instrumentation for cfrag from [esan|cfrag] Disable load/store/memintrinsic instrumentation to [esan|cfrag] Disable load/store/memintrinsic instrumentation for cfrag.
Jun 8 2016, 10:21 AM

Jun 7 2016

zhaoqin retitled D21079: [esan|cfrag] Disable load/store instrumentation for cfrag from to [esan|cfrag] Disable load/store/memintrinsic instrumentation.
Jun 7 2016, 8:51 AM

Jun 3 2016

zhaoqin committed rL271734: [esan|cfrag] Compute the struct field access difference ratio.
[esan|cfrag] Compute the struct field access difference ratio
Jun 3 2016, 1:54 PM
zhaoqin closed D20914: [esan|cfrag] Compute the struct field access difference ratio by committing rL271734: [esan|cfrag] Compute the struct field access difference ratio.
Jun 3 2016, 1:54 PM
zhaoqin updated the diff for D20914: [esan|cfrag] Compute the struct field access difference ratio.

update the comment about computing the difference ratio.

Jun 3 2016, 12:20 PM
zhaoqin updated the diff for D20914: [esan|cfrag] Compute the struct field access difference ratio.

PTAL

Jun 3 2016, 12:15 PM
zhaoqin retitled D20914: [esan|cfrag] Compute the struct field access difference ratio from [esan|cfrag] Compute the struct field access variance to [esan|cfrag] Compute the struct field access difference ratio.
Jun 3 2016, 12:14 PM
zhaoqin updated D20914: [esan|cfrag] Compute the struct field access difference ratio.
Jun 3 2016, 12:14 PM
zhaoqin added a comment to D20914: [esan|cfrag] Compute the struct field access difference ratio.
Jun 3 2016, 12:11 PM
zhaoqin added inline comments to D20914: [esan|cfrag] Compute the struct field access difference ratio.
Jun 3 2016, 12:11 PM
zhaoqin updated the diff for D20914: [esan|cfrag] Compute the struct field access difference ratio.

Use v1/v2/base to calculate the difference score.

Jun 3 2016, 9:21 AM