Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People zetafunction

zetafunction (Daniel Cheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Fri, Aug 25, 8:35 PM (4 w, 15 h)

Recent Activity
View All

Fri, Sep 1

zetafunction abandoned D158922: [libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly..
Fri, Sep 1, 12:34 PM · Restricted Project, Restricted Project
zetafunction added a comment to D158922: [libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly..
In D158922#4635027, @philnik wrote:
In D158922#4634975, @zetafunction wrote:

Is there updated documentation for best practices for doing that? I was following https://libcxx.llvm.org/Contributing.html.

We have just started the move, so I don't think there is any documentation yet. You should be able to just fork the llvm-project and then open a PR against the main repo.

Fri, Sep 1, 12:00 PM · Restricted Project, Restricted Project
zetafunction added a comment to D158922: [libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly..

Is there updated documentation for best practices for doing that? I was following https://libcxx.llvm.org/Contributing.html.

Fri, Sep 1, 11:21 AM · Restricted Project, Restricted Project

Sat, Aug 26

zetafunction updated the diff for D158922: [libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly..

Use {} for aggregate init for compat with older compilers.

Sat, Aug 26, 8:36 AM · Restricted Project, Restricted Project
zetafunction updated the diff for D158922: [libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly..

Make sure pointer_traits.h is C++03-compatible.

Sat, Aug 26, 12:22 AM · Restricted Project, Restricted Project

Fri, Aug 25

zetafunction requested review of D158922: [libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly..
Fri, Aug 25, 11:48 PM · Restricted Project, Restricted Project