Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People yzhang93

yzhang93 (Vivian Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 25 2023, 2:08 PM (17 w, 4 d)

Recent Activity
View All

Mon, Aug 28

yzhang93 updated the diff for D158757: Add narrow type emulation pattern for vector.transfer_read.
Mon, Aug 28, 4:53 PM · Restricted Project, Restricted Project
yzhang93 added inline comments to D158757: Add narrow type emulation pattern for vector.transfer_read.
Mon, Aug 28, 2:47 PM · Restricted Project, Restricted Project
yzhang93 requested review of D158757: Add narrow type emulation pattern for vector.transfer_read.
Mon, Aug 28, 2:46 PM · Restricted Project, Restricted Project

Aug 24 2023

yzhang93 added reviewers for D158757: Add narrow type emulation pattern for vector.transfer_read: mravishankar, hanchung.
Aug 24 2023, 10:39 AM · Restricted Project, Restricted Project
yzhang93 requested review of D158757: Add narrow type emulation pattern for vector.transfer_read.
Aug 24 2023, 10:36 AM · Restricted Project, Restricted Project

Aug 16 2023

yzhang93 accepted D158125: [mlir] Revamp implementation of sub-byte load/store emulation..

Thanks for refactoring the codes and fixing the bug! Overall looks good to me.

Aug 16 2023, 4:40 PM · Restricted Project, Restricted Project

Jun 30 2023

yzhang93 requested review of D154178: [mlir] Narrow bitwidth emulation for vector.load.
Jun 30 2023, 10:29 PM · Restricted Project, Restricted Project

Jun 29 2023

yzhang93 edited reviewers for D154178: [mlir] Narrow bitwidth emulation for vector.load, added: hanchung, mravishankar; removed: aartbik, dcaballe.
Jun 29 2023, 8:47 PM · Restricted Project, Restricted Project
yzhang93 requested review of D154178: [mlir] Narrow bitwidth emulation for vector.load.
Jun 29 2023, 8:41 PM · Restricted Project, Restricted Project

Jun 26 2023

yzhang93 updated the diff for D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 26 2023, 10:56 AM · Restricted Project, Restricted Project

Jun 22 2023

yzhang93 added inline comments to D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 22 2023, 4:58 PM · Restricted Project, Restricted Project
yzhang93 updated the diff for D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 22 2023, 4:38 PM · Restricted Project, Restricted Project

Jun 13 2023

yzhang93 added inline comments to D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 13 2023, 10:36 AM · Restricted Project, Restricted Project
yzhang93 requested review of D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 13 2023, 10:30 AM · Restricted Project, Restricted Project

Jun 8 2023

yzhang93 added inline comments to D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 8 2023, 12:24 PM · Restricted Project, Restricted Project
yzhang93 requested review of D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 8 2023, 12:20 PM · Restricted Project, Restricted Project

Jun 5 2023

yzhang93 added inline comments to D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 5 2023, 4:06 PM · Restricted Project, Restricted Project
yzhang93 requested review of D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 5 2023, 4:05 PM · Restricted Project, Restricted Project

Jun 2 2023

yzhang93 updated the diff for D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 2 2023, 3:25 PM · Restricted Project, Restricted Project
yzhang93 added inline comments to D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 2 2023, 2:52 PM · Restricted Project, Restricted Project
yzhang93 updated the diff for D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 2 2023, 2:50 PM · Restricted Project, Restricted Project

Jun 1 2023

yzhang93 requested review of D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 1 2023, 10:59 PM · Restricted Project, Restricted Project
yzhang93 updated the diff for D151519: [mlir] Narrow bitwidth emulation for MemRef load.
Jun 1 2023, 10:26 AM · Restricted Project, Restricted Project

May 31 2023

yzhang93 updated the diff for D151519: [mlir] Narrow bitwidth emulation for MemRef load.
May 31 2023, 8:32 PM · Restricted Project, Restricted Project
yzhang93 abandoned D151827: Make arith converter configurable by user.
May 31 2023, 1:06 PM · Restricted Project, Restricted Project
yzhang93 abandoned D151826: [mlir] Narrow bitwidth emulation for MemRef load.
May 31 2023, 1:06 PM · Restricted Project, Restricted Project
yzhang93 added a comment to D151519: [mlir] Narrow bitwidth emulation for MemRef load.
In D151519#4376791, @hanchung wrote:

Nice work! I dropped few comments inline. :)

Inspired by IREE project patch, I found that some people would like to emulate f16 computation on f32 domain: https://github.com/openxla/iree/pull/13808

I think we can rename the EmulateNarrowInt to EmulateNarrowType or EmulateNarrowNumerics, and they can add such patterns to it later.

May 31 2023, 1:05 PM · Restricted Project, Restricted Project
yzhang93 requested review of D151519: [mlir] Narrow bitwidth emulation for MemRef load.
May 31 2023, 12:45 PM · Restricted Project, Restricted Project
yzhang93 requested review of D151827: Make arith converter configurable by user.
May 31 2023, 11:57 AM · Restricted Project, Restricted Project
yzhang93 requested review of D151826: [mlir] Narrow bitwidth emulation for MemRef load.
May 31 2023, 11:57 AM · Restricted Project, Restricted Project

May 25 2023

yzhang93 requested review of D151519: [mlir] Narrow bitwidth emulation for MemRef load.
May 25 2023, 4:41 PM · Restricted Project, Restricted Project