Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People yuntaopan

yuntaopan (panyuntao)
User

Projects

User does not belong to any projects.

User Details

User Since: Feb 22 2022, 1:45 AM (84 w, 14 h)

Recent Activity
View All

Aug 31 2023

yuntaopan added a comment to D159331: [ADT][NFC] Remove some redundant code.

In D159331#4633457, @MaskRay wrote:

In D159331#4633453, @yuntaopan wrote:

@MaskRay is_one_of and are_base_of have been defined in llvm/include/llvm/ADT/STLExtras.h lines 210 to 218, so delete the duplicate code starting at line 1487

So we have llvm::detail::are_base_of and llvm::are_base_of. The use in llvm/include/llvm/IR/DerivedTypes.h is llvm::are_base_of which you are removing?

Aug 31 2023, 11:44 PM · Restricted Project, Restricted Project

yuntaopan added a comment to D159331: [ADT][NFC] Remove some redundant code.

@MaskRay is_one_of and are_base_of have been defined in llvm/include/llvm/ADT/STLExtras.h lines 210 to 218, so delete the duplicate code starting at line 1487

Aug 31 2023, 11:27 PM · Restricted Project, Restricted Project

yuntaopan added reviewers for D159331: [ADT][NFC] Remove some redundant code: MaskRay, dblaikie.

Aug 31 2023, 8:24 PM · Restricted Project, Restricted Project

yuntaopan requested review of D159331: [ADT][NFC] Remove some redundant code.

Aug 31 2023, 8:08 PM · Restricted Project, Restricted Project

Aug 17 2023

yuntaopan abandoned D121085: [AArch64][GlobalISel] Implement G_SELECT translate to min/max/abs.

Related optimizations have been done in InstCombine Pass, so there is no need to support such optimizations here

Aug 17 2023, 8:11 PM · Restricted Project, Restricted Project

Mar 20 2023

yuntaopan added reviewers for D146416: [MC] avoid create MCFillFragment when bytes is 0: t.p.northover, sepavloff.

Mar 20 2023, 4:50 AM · Restricted Project, Restricted Project

yuntaopan updated the summary of D146416: [MC] avoid create MCFillFragment when bytes is 0.

Mar 20 2023, 4:46 AM · Restricted Project, Restricted Project

yuntaopan requested review of D146416: [MC] avoid create MCFillFragment when bytes is 0.

Mar 20 2023, 4:40 AM · Restricted Project, Restricted Project

Mar 9 2022

yuntaopan added a comment to D121085: [AArch64][GlobalISel] Implement G_SELECT translate to min/max/abs.

In D121085#3366519, @foad wrote:

In D121085#3365851, @aemerson wrote:

Thanks for the patch. Unfortunately I see the code that this was ported from in SelectionDAGBuilder does the optimization there because it relies on ValueTracking's matchSelectPattern() infrastructure. @arsenm @foad do you think it's worth it here to replicate that functionality for generic MIR so we can avoid adding this to the IRTranslator?

Shouldn't the select -> min/max/abs be done in IR, so there would be no need for this patch? See D98152 for example.