Page MenuHomePhabricator

yshui (yshui)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 2:23 AM (104 w, 1 d)

Recent Activity

Wed, Jun 9

yshui added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

@jmorse Ping.

Wed, Jun 9, 3:24 AM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Rebasing, no new test changes.

Wed, Jun 9, 3:23 AM · Restricted Project

Fri, Jun 4

yshui added a reviewer for D98659: [MachineCopyPropagation] Do more backward copy propagations: MaskRay.
Fri, Jun 4, 6:40 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.
  • Rebasing
  • More affected tests:
    • CodeGen/RISCV/rvv/vselect-fp-rv64.ll
    • CodeGen/RISCV/rvv/vselect-fp-rv32.ll
Fri, Jun 4, 6:36 PM · Restricted Project

Wed, Jun 2

yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Rebasing

Wed, Jun 2, 6:49 AM · Restricted Project

Sat, May 29

yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.
  • Rebase
  • Add an example of the new copy propagation in the top comments
  • Style fixes
Sat, May 29, 9:56 AM · Restricted Project

Apr 18 2021

yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Apr 18 2021, 3:50 PM · Restricted Project
yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Apr 18 2021, 6:07 AM · Restricted Project

Apr 15 2021

yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Apr 15 2021, 2:58 AM · Restricted Project

Apr 5 2021

yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Add tests suggested by @jmorse

Apr 5 2021, 9:57 PM · Restricted Project

Apr 2 2021

yshui added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

The simplest and easiest fix for that, is to have the function ignore debug-info instructions by adding a "if (MI.isDebugInstr()) continue;" statement in the loop before interpreting its register-reads.

Apr 2 2021, 2:07 PM · Restricted Project

Mar 27 2021

yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Uh, I just figured out how mir tests work. Guess nobody wanted to point out how dumb I am. 😅

Mar 27 2021, 2:03 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Rebasing

Mar 27 2021, 12:47 PM · Restricted Project

Mar 24 2021

yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Thanks @jmorse for the review.

Mar 24 2021, 8:14 PM · Restricted Project
yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Mar 24 2021, 6:39 PM · Restricted Project
yshui added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

There isn't a lot of difference to how debug-info is updated, as far as I can see, but the summary says a fault is resolved. Is this patch just masking the debug-info issue by doing more propagation? (I might have missed something in the implementation).

Mar 24 2021, 6:36 PM · Restricted Project

Mar 18 2021

yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Style fixes.

Mar 18 2021, 5:10 AM · Restricted Project
yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Mar 18 2021, 5:08 AM · Restricted Project
yshui added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Thanks for your review. There is a test case in https://reviews.llvm.org/D98401, which is quite big. I wasn't able to reduce it further, is it OK to just include that as test case?

Have you tried using bugpoint to reduce it further, or writing MIR test manually?

Mar 18 2021, 5:01 AM · Restricted Project
yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Mar 18 2021, 4:07 AM · Restricted Project
yshui added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Since this patch already changed output of many test cases, do we still need a test case specifically for this patch?

You'd better add some mir tests to demonstrate the idea, w/o -g.

Mar 18 2021, 3:39 AM · Restricted Project

Mar 17 2021

yshui added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Since this patch already changed output of many test cases, do we still need a test case specifically for this patch?

Mar 17 2021, 1:50 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Update Mips tests.

Mar 17 2021, 5:20 AM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Include full context in the patch

Mar 17 2021, 3:46 AM · Restricted Project

Mar 16 2021

yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

I reviewed the changes in CodeGen tests to the best of my ability, and they look fine to me. If someone else could review and confirm, that would be appreciated.

Mar 16 2021, 3:16 PM · Restricted Project
yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Mar 16 2021, 6:35 AM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Strengthen the invariant maintained by the CopyTracker.

Mar 16 2021, 6:34 AM · Restricted Project
yshui added inline comments to D98659: [MachineCopyPropagation] Do more backward copy propagations.
Mar 16 2021, 4:56 AM · Restricted Project

Mar 15 2021

yshui updated subscribers of D98659: [MachineCopyPropagation] Do more backward copy propagations.
Mar 15 2021, 4:15 PM · Restricted Project
yshui added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

https://reviews.llvm.org/D98659 could supersede this

Mar 15 2021, 2:54 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Adjust a debug message.

Mar 15 2021, 2:14 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Remove a TODO which is no longer relevant

Mar 15 2021, 2:07 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Adjust how DBG_VALUE is rewritten.

Mar 15 2021, 1:53 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

Fix typos in comments.

Mar 15 2021, 1:31 PM · Restricted Project
yshui added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Things still need to be done:

Mar 15 2021, 1:27 PM · Restricted Project
yshui requested review of D98659: [MachineCopyPropagation] Do more backward copy propagations.
Mar 15 2021, 1:25 PM · Restricted Project
yshui added inline comments to D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 15 2021, 1:01 PM · Restricted Project

Mar 12 2021

yshui added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

I think it might be valuable to extend this to all cases like this:

Mar 12 2021, 10:55 AM · Restricted Project

Mar 11 2021

yshui added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

Because you replaced $rbp with $rbx, surely you would have to replace it everywhere. Removing the DBG_VALUE is potential information loss.

Mar 11 2021, 3:53 AM · Restricted Project
yshui added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.
renamable $rbx = nuw LEA64r %stack.5.agg.tmp.i, 1, $noreg, 8, $noreg
DBG_VALUE $rbp, $noreg, !"this", !DIExpression(), debug-location !293; hot.cpp:0 @[ hot.cpp:84:39 @[ hot.cpp:108:11 ] ] line no:0
Mar 11 2021, 3:05 AM · Restricted Project