yamauchi (Hiroshi Yamauchi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 5:32 PM (29 w, 11 h)

Recent Activity

Dec 12 2017

yamauchi added a comment to D40699: Split IndirectBr critical edges before PGO gen/use passes..

I think it will be an assert failure like before. Like said above, this patch isn't intended to handle that case.

Dec 12 2017, 12:02 PM
yamauchi committed rL320511: Split IndirectBr critical edges before PGO gen/use passes..
Split IndirectBr critical edges before PGO gen/use passes.
Dec 12 2017, 11:08 AM
yamauchi closed D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 12 2017, 11:08 AM
yamauchi updated the diff for D40699: Split IndirectBr critical edges before PGO gen/use passes..

Rebased.

Dec 12 2017, 10:51 AM

Dec 11 2017

yamauchi added inline comments to D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 11 2017, 2:53 PM
yamauchi updated the summary of D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 11 2017, 2:52 PM
yamauchi updated the diff for D40699: Split IndirectBr critical edges before PGO gen/use passes..

Going back to Diff 125662.

Dec 11 2017, 2:50 PM
yamauchi added inline comments to D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 11 2017, 10:47 AM

Dec 7 2017

yamauchi added inline comments to D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 7 2017, 5:41 PM
yamauchi updated the diff for D40699: Split IndirectBr critical edges before PGO gen/use passes..

Detect indirectbr critical non-MST edges in CFGMST and if none, avoid iterating
over the edges in FuncPGOInstrumentation().

Dec 7 2017, 5:26 PM
yamauchi abandoned D38474: Add support for multiple prof metadata on instructions..
Dec 7 2017, 2:56 PM

Dec 6 2017

yamauchi updated the summary of D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 6 2017, 4:49 PM
yamauchi updated the diff for D40699: Split IndirectBr critical edges before PGO gen/use passes..

Split only the IndirectBr critical edges that need to be split rather than
all. This avoids changing the indirectbr.ll test.

Dec 6 2017, 4:27 PM

Dec 5 2017

yamauchi updated the summary of D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 5 2017, 6:06 PM
yamauchi updated the diff for D40699: Split IndirectBr critical edges before PGO gen/use passes..

Split indirectbr critical edges in the PGO gen/use passes.

Dec 5 2017, 6:05 PM

Dec 4 2017

yamauchi updated the summary of D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 4 2017, 3:32 PM
yamauchi updated the summary of D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 4 2017, 3:30 PM
yamauchi updated the diff for D40699: Split IndirectBr critical edges before PGO gen/use passes..

Rebased after D40750.

Dec 4 2017, 3:26 PM
yamauchi committed rL319689: Move splitIndirectCriticalEdges() to BasicBlockUtils.h..
Move splitIndirectCriticalEdges() to BasicBlockUtils.h.
Dec 4 2017, 12:36 PM
yamauchi closed D40750: Move splitIndirectCriticalEdges() to BasicBlockUtils.h..
Dec 4 2017, 12:36 PM
yamauchi added a comment to D40699: Split IndirectBr critical edges before PGO gen/use passes..

Created https://reviews.llvm.org/D40750 for the refactoring part.

Dec 4 2017, 10:45 AM
yamauchi added inline comments to D40699: Split IndirectBr critical edges before PGO gen/use passes..
Dec 4 2017, 10:44 AM

Dec 1 2017

yamauchi created D40750: Move splitIndirectCriticalEdges() to BasicBlockUtils.h..
Dec 1 2017, 1:15 PM
yamauchi added a comment to D40699: Split IndirectBr critical edges before PGO gen/use passes..

The PGO gen/use passes currently fail with an assert failure if there's a critical edge whose source is an IndirectBr instruction.

findIBRPredecessor will fail for blocks with multiple multiple indirectbr predecessors. And then you're back at square one, with an assertion failure.

Dec 1 2017, 11:38 AM

Nov 30 2017

yamauchi added a reviewer for D40699: Split IndirectBr critical edges before PGO gen/use passes.: xur.
Nov 30 2017, 6:15 PM
yamauchi created D40699: Split IndirectBr critical edges before PGO gen/use passes..
Nov 30 2017, 6:12 PM

Nov 20 2017

yamauchi committed rL318696: Fix a lld-x86_64-darwin13 build error..
Fix a lld-x86_64-darwin13 build error.
Nov 20 2017, 1:39 PM
yamauchi closed D40266: Fix a lld-x86_64-darwin13 build error..
Nov 20 2017, 1:38 PM
yamauchi created D40266: Fix a lld-x86_64-darwin13 build error..
Nov 20 2017, 1:27 PM
yamauchi committed rL318693: Add heuristics for irreducible loop metadata under PGO.
Add heuristics for irreducible loop metadata under PGO
Nov 20 2017, 1:05 PM
yamauchi closed D39980: Add heuristics for irreducible loop metadata under PGO.
Nov 20 2017, 1:04 PM

Nov 14 2017

yamauchi updated the diff for D39980: Add heuristics for irreducible loop metadata under PGO.

Updated comment.

Nov 14 2017, 4:28 PM
yamauchi updated the summary of D39980: Add heuristics for irreducible loop metadata under PGO.
Nov 14 2017, 3:18 PM
yamauchi added inline comments to D39980: Add heuristics for irreducible loop metadata under PGO.
Nov 14 2017, 3:18 PM
yamauchi updated the diff for D39980: Add heuristics for irreducible loop metadata under PGO.

Rebased and addressed comments.

Nov 14 2017, 3:18 PM
yamauchi committed rL318182: Simplify irreducible loop metadata test code..
Simplify irreducible loop metadata test code.
Nov 14 2017, 11:49 AM
yamauchi closed D40043: Simplify irreducible loop metadata test code..
Nov 14 2017, 11:49 AM
yamauchi created D40043: Simplify irreducible loop metadata test code..
Nov 14 2017, 11:14 AM

Nov 13 2017

yamauchi updated the summary of D39980: Add heuristics for irreducible loop metadata under PGO.
Nov 13 2017, 2:12 PM
yamauchi created D39980: Add heuristics for irreducible loop metadata under PGO.
Nov 13 2017, 2:01 PM

Nov 2 2017

yamauchi committed rL317278: Irreducible loop metadata for more accurate block frequency under PGO..
Irreducible loop metadata for more accurate block frequency under PGO.
Nov 2 2017, 3:27 PM
yamauchi closed D39028: Irreducible loop metadata for more accurate block frequency under PGO..
Nov 2 2017, 3:27 PM
yamauchi updated the diff for D39028: Irreducible loop metadata for more accurate block frequency under PGO..

Rebased.

Nov 2 2017, 3:26 PM

Oct 27 2017

yamauchi added inline comments to D39028: Irreducible loop metadata for more accurate block frequency under PGO..
Oct 27 2017, 3:31 PM
yamauchi updated the diff for D39028: Irreducible loop metadata for more accurate block frequency under PGO..

Addressed comments.

Oct 27 2017, 3:30 PM

Oct 25 2017

yamauchi updated the diff for D39028: Irreducible loop metadata for more accurate block frequency under PGO..

Changed the metadata name.
Added the metadata to the doc.

Oct 25 2017, 3:51 PM

Oct 20 2017

yamauchi added inline comments to D39028: Irreducible loop metadata for more accurate block frequency under PGO..
Oct 20 2017, 6:10 PM
yamauchi updated the diff for D39028: Irreducible loop metadata for more accurate block frequency under PGO..

Addressed comments.

Oct 20 2017, 6:09 PM

Oct 17 2017

yamauchi created D39028: Irreducible loop metadata for more accurate block frequency under PGO..
Oct 17 2017, 5:42 PM

Oct 6 2017

yamauchi added a comment to D38474: Add support for multiple prof metadata on instructions..

To give more context, the motivating issue for us is the block frequency propagation of irreducible loops under PGO.

Oct 6 2017, 11:42 AM
yamauchi added a comment to D38474: Add support for multiple prof metadata on instructions..

This does not look like backward compatible IR change. For the purpose of annotating irreducible loop headers, it might be better to introduce a new type of metadata.

Oct 6 2017, 11:04 AM

Oct 2 2017

yamauchi updated the diff for D38474: Add support for multiple prof metadata on instructions..

A bit of cleanup and added an assert.

Oct 2 2017, 4:43 PM
yamauchi created D38474: Add support for multiple prof metadata on instructions..
Oct 2 2017, 11:49 AM

Sep 13 2017

yamauchi committed rL313220: Add optional profile counts to block frequency dump..
Add optional profile counts to block frequency dump.
Sep 13 2017, 5:22 PM
yamauchi closed D37835: Add optional profile counts to block frequency dump..
Sep 13 2017, 5:21 PM
yamauchi added a comment to D37835: Add optional profile counts to block frequency dump..

The last note is that, as I suspect, we don't include a header in CodeGen/ into a file under Analysis/ which prevents the overload idea from working.

Sep 13 2017, 5:14 PM
yamauchi added inline comments to D37835: Add optional profile counts to block frequency dump..
Sep 13 2017, 4:44 PM
yamauchi created D37835: Add optional profile counts to block frequency dump..
Sep 13 2017, 4:30 PM
yamauchi committed rL313159: Add options to dump PGO counts in text..
Add options to dump PGO counts in text.
Sep 13 2017, 10:22 AM
yamauchi closed D37776: Add options to dump PGO counts in text..
Sep 13 2017, 10:21 AM

Sep 12 2017

yamauchi updated the summary of D37776: Add options to dump PGO counts in text..
Sep 12 2017, 5:43 PM
yamauchi updated the diff for D37776: Add options to dump PGO counts in text..

Addressed the comment.

Sep 12 2017, 5:41 PM
yamauchi created D37776: Add options to dump PGO counts in text..
Sep 12 2017, 3:34 PM

Sep 11 2017

yamauchi committed rL312930: Unmerge GEPs to reduce register pressure on IndirectBr edges..
Unmerge GEPs to reduce register pressure on IndirectBr edges.
Sep 11 2017, 10:53 AM
yamauchi closed D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..
Sep 11 2017, 10:53 AM
yamauchi added a comment to D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

Thanks, Hal.

Sep 11 2017, 10:52 AM
yamauchi updated the diff for D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

Rebased.

Sep 11 2017, 10:52 AM

Sep 7 2017

yamauchi updated the diff for D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

Addressed a comment.

Sep 7 2017, 11:59 AM

Sep 6 2017

yamauchi added inline comments to D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..
Sep 6 2017, 3:23 PM
yamauchi updated the diff for D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

One comment addressed and another needs clarification.

Sep 6 2017, 3:22 PM

Aug 28 2017

yamauchi updated the diff for D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

Noted the tradeoff between register pressures and critical path in the comment.

Aug 28 2017, 12:44 PM
yamauchi added a comment to D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

As this patch can affect ARM targets I am doing some benchmarking.
I've got the LNT benchmarks results for AArch64 (Cortex-A57). There is no difference in performance. I'll have got more results soon.
It's interesting to see what benchmarks has been used to measure the improvements.

Aug 28 2017, 11:06 AM

Aug 25 2017

yamauchi committed rL311822: Add options to dump block frequency/branch probability info in text..
Add options to dump block frequency/branch probability info in text.
Aug 25 2017, 5:32 PM
yamauchi closed D37165: Add options to dump block frequency/branch probability info in text..
Aug 25 2017, 5:32 PM
yamauchi added a reviewer for D37165: Add options to dump block frequency/branch probability info in text.: davidxl.
Aug 25 2017, 2:59 PM
yamauchi created D37165: Add options to dump block frequency/branch probability info in text..
Aug 25 2017, 1:58 PM

Aug 24 2017

yamauchi updated the diff for D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

Added getIntImmCost checks. Please take another look.

Aug 24 2017, 5:01 PM

Aug 23 2017

yamauchi added a comment to D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..

Sorry for a delay.

Aug 23 2017, 1:41 PM

Aug 21 2017

yamauchi added a reviewer for D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges.: hfinkel.

Hi Hal, would you take a look at this change?

Aug 21 2017, 5:04 PM
yamauchi abandoned D35445: [InstCombine] Simplify pointer difference subtractions (GEP-GEP) where GEPs have other uses and one non-constant index.

Replaced by https://reviews.llvm.org/D35499

Aug 21 2017, 4:59 PM

Aug 15 2017

yamauchi created D36772: Unmerge GEPs to reduce register pressure on IndirectBr edges..
Aug 15 2017, 3:47 PM

Aug 9 2017

yamauchi committed rL310545: [LVI] Fix LVI compile time regression around constantFoldUser().
[LVI] Fix LVI compile time regression around constantFoldUser()
Aug 9 2017, 7:24 PM
yamauchi closed D36552: [LVI] Fix LVI compile time regression around constantFoldUser().
Aug 9 2017, 7:24 PM
yamauchi updated the diff for D36552: [LVI] Fix LVI compile time regression around constantFoldUser().

Done.

Aug 9 2017, 7:23 PM
yamauchi updated the diff for D36552: [LVI] Fix LVI compile time regression around constantFoldUser().

Addressed comment.

Aug 9 2017, 5:12 PM
yamauchi updated the diff for D36552: [LVI] Fix LVI compile time regression around constantFoldUser().

Addressed comments.

Aug 9 2017, 3:56 PM
yamauchi updated the diff for D36552: [LVI] Fix LVI compile time regression around constantFoldUser().

Cleaned up.

Aug 9 2017, 2:46 PM
yamauchi created D36552: [LVI] Fix LVI compile time regression around constantFoldUser().
Aug 9 2017, 2:30 PM

Aug 3 2017

yamauchi committed rL309986: [LVI] Constant-propagate a zero extension of the switch condition value through….
[LVI] Constant-propagate a zero extension of the switch condition value through…
Aug 3 2017, 2:12 PM
yamauchi closed D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.
Aug 3 2017, 2:12 PM
yamauchi added inline comments to D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.
Aug 3 2017, 1:49 PM
yamauchi updated the diff for D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.

Addressed the comment.

Aug 3 2017, 1:49 PM
yamauchi added a comment to D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.

Addressed the inline comments.

Aug 3 2017, 12:03 PM
yamauchi updated the diff for D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.

Agreed on the phrasing and that there are cases where we could do the propagation/transformation.

Aug 3 2017, 12:03 PM

Aug 2 2017

yamauchi added a comment to D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.

This is ready for review.

Aug 2 2017, 4:09 PM
yamauchi added a comment to D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.

The issue with D34822 was that it is not correct to propagate the constant range of the value that's derived from the switch condition to the *default* edge.

Aug 2 2017, 4:03 PM
yamauchi updated the diff for D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.

This second diff is the new one that fixes the bug (see test20).

Aug 2 2017, 4:00 PM
yamauchi added a comment to D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.

The first diff is the same as the reverted https://reviews.llvm.org/D34822.

Aug 2 2017, 3:53 PM
yamauchi created D36247: [LVI] Constant-propagate a zero extension of the switch condition value through case edges.
Aug 2 2017, 3:52 PM

Jul 28 2017

yamauchi committed rL309415: [LVI] Constant-propagate a zero extension of the switch condition value through….
[LVI] Constant-propagate a zero extension of the switch condition value through…
Jul 28 2017, 11:36 AM