Page MenuHomePhabricator

yamauchi (Hiroshi Yamauchi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 5:32 PM (197 w, 5 d)

Recent Activity

Mar 11 2021

yamauchi committed rG365b225d4618: [PGO] Fix two issues in PGOMemOPSizeOpt. (authored by yamauchi).
[PGO] Fix two issues in PGOMemOPSizeOpt.
Mar 11 2021, 9:53 AM
yamauchi closed D97592: [PGO] Fix two issues in PGOMemOPSizeOpt..
Mar 11 2021, 9:53 AM · Restricted Project, Restricted Project

Mar 4 2021

yamauchi updated the diff for D97592: [PGO] Fix two issues in PGOMemOPSizeOpt..

Address comment.

Mar 4 2021, 11:06 AM · Restricted Project, Restricted Project

Mar 1 2021

yamauchi added a comment to D97592: [PGO] Fix two issues in PGOMemOPSizeOpt..

Okay added a new test.

Mar 1 2021, 4:13 PM · Restricted Project, Restricted Project
yamauchi updated the diff for D97592: [PGO] Fix two issues in PGOMemOPSizeOpt..

Address comment.

Mar 1 2021, 4:13 PM · Restricted Project, Restricted Project
yamauchi added a comment to D97592: [PGO] Fix two issues in PGOMemOPSizeOpt..

Perhaps add a test case showing that up to 3 ranges can be promoted?

Mar 1 2021, 10:49 AM · Restricted Project, Restricted Project

Feb 26 2021

yamauchi requested review of D97592: [PGO] Fix two issues in PGOMemOPSizeOpt..
Feb 26 2021, 3:23 PM · Restricted Project, Restricted Project

Jan 14 2021

yamauchi committed rG202d359753d1: [X86] Add the FSRM feature (Fast Short Rep Mov) to Zen3. (authored by yamauchi).
[X86] Add the FSRM feature (Fast Short Rep Mov) to Zen3.
Jan 14 2021, 10:48 AM
yamauchi closed D94436: [X86] Add the FSRM feature (Fast Short Rep Mov) to Zen3..
Jan 14 2021, 10:47 AM · Restricted Project

Jan 11 2021

yamauchi requested review of D94436: [X86] Add the FSRM feature (Fast Short Rep Mov) to Zen3..
Jan 11 2021, 11:06 AM · Restricted Project

Jan 7 2021

yamauchi committed rGcf5415c727dd: [PGO][PGSO] Let unroll hints take precedence over PGSO. (authored by yamauchi).
[PGO][PGSO] Let unroll hints take precedence over PGSO.
Jan 7 2021, 10:11 AM
yamauchi closed D94199: [PGO][PGSO] Let unroll hints take precedence over PGSO..
Jan 7 2021, 10:10 AM · Restricted Project

Jan 6 2021

yamauchi requested review of D94199: [PGO][PGSO] Let unroll hints take precedence over PGSO..
Jan 6 2021, 2:44 PM · Restricted Project

Dec 15 2020

yamauchi added a comment to D92669: [PGO] Adjust -vp-counters-per-site..

D93281 looks good to me.

Dec 15 2020, 8:33 AM · Restricted Project
yamauchi accepted D93281: [PGO] Allow overriding -vp-counters-per-site.
Dec 15 2020, 8:31 AM · Restricted Project

Dec 14 2020

yamauchi updated subscribers of D92669: [PGO] Adjust -vp-counters-per-site..

I can add "cl::ZeroOrMore" to "-vp-counters-per-site". Would it be good?

Dec 14 2020, 12:06 PM · Restricted Project

Dec 11 2020

yamauchi committed rGa5f5612263ca: [PGO] Adjust -vp-counters-per-site under dynamic linking. (authored by yamauchi).
[PGO] Adjust -vp-counters-per-site under dynamic linking.
Dec 11 2020, 9:43 AM
yamauchi closed D92669: [PGO] Adjust -vp-counters-per-site..
Dec 11 2020, 9:43 AM · Restricted Project

Dec 10 2020

yamauchi added inline comments to D92669: [PGO] Adjust -vp-counters-per-site..
Dec 10 2020, 1:38 PM · Restricted Project

Dec 9 2020

yamauchi added a comment to D92669: [PGO] Adjust -vp-counters-per-site..

The size increase is significant. It is likely that some very large apps may run into size limit issue at link time with this change.

Dec 9 2020, 3:31 PM · Restricted Project
yamauchi updated the diff for D92669: [PGO] Adjust -vp-counters-per-site..

Adjust only for dynamic linking mode. Rebase.

Dec 9 2020, 3:29 PM · Restricted Project

Dec 7 2020

yamauchi added a comment to D92669: [PGO] Adjust -vp-counters-per-site..

how much size increase is in clang instrumented build?

Dec 7 2020, 9:27 AM · Restricted Project

Dec 4 2020

yamauchi committed rGf9c3954a6ec5: Fix for Bug 48055. (authored by yamauchi).
Fix for Bug 48055.
Dec 4 2020, 11:06 AM
yamauchi closed D92599: Fix for Bug 48055..
Dec 4 2020, 11:06 AM · Restricted Project
yamauchi updated the diff for D92599: Fix for Bug 48055..

Address comment.

Dec 4 2020, 10:29 AM · Restricted Project
yamauchi added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

https://reviews.llvm.org/D92669 should fix the issue.

Dec 4 2020, 9:59 AM · Restricted Project, Restricted Project
yamauchi requested review of D92669: [PGO] Adjust -vp-counters-per-site..
Dec 4 2020, 9:57 AM · Restricted Project
yamauchi added a comment to D60793: [Evaluator] Walk initial elements when handling load through bitcast.

Uploaded https://reviews.llvm.org/D92599

Dec 4 2020, 9:34 AM · Restricted Project
yamauchi updated the summary of D92599: Fix for Bug 48055..
Dec 4 2020, 9:31 AM · Restricted Project

Dec 3 2020

yamauchi requested review of D92599: Fix for Bug 48055..
Dec 3 2020, 12:22 PM · Restricted Project

Dec 2 2020

yamauchi added a comment to D60793: [Evaluator] Walk initial elements when handling load through bitcast.

Hi, we encountered this issue https://bugs.llvm.org/show_bug.cgi?id=48055 which reverting this patch seems to make it go away.

Dec 2 2020, 2:08 PM · Restricted Project

Oct 15 2020

yamauchi committed rG1ebee7adf896: [PGO] Remove the old memop value profiling buckets. (authored by yamauchi).
[PGO] Remove the old memop value profiling buckets.
Oct 15 2020, 10:10 AM
yamauchi closed D88838: [PGO] Remove the old memop value profiling buckets..
Oct 15 2020, 10:10 AM · Restricted Project, Restricted Project

Oct 14 2020

yamauchi added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

This is with clang trying to PGO itself. Build with -DLLVM_BUILD_INSTRUMENTED=IR -DLLVM_BUILD_RUNTIME=No and use the result to build the LLVM tree again.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318445929&repo=ash&lineNumber=17322

Oct 14 2020, 3:50 PM · Restricted Project, Restricted Project
yamauchi added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

The re-landing of this patch in 4a539faf74b9b4c25ee3b880e4007564bd5139b0 causes our PGO build of clang to have thousands of

LLVM Profile Warning: Unable to track new values: Running out of static counters.  Consider using option -mllvm -vp-counters-per-site=<n> to allocate more value profile counters at compile time.

Is that expected? Should the cmake set a higher value of -vp-counters-per-site in self-hosted PGO builds?

This has been reverted for now. There was a related issue.

Our build bots still show lots of this warning, is that expected?

Oct 14 2020, 8:33 AM · Restricted Project, Restricted Project

Oct 5 2020

yamauchi updated the summary of D88838: [PGO] Remove the old memop value profiling buckets..
Oct 5 2020, 9:57 AM · Restricted Project, Restricted Project
yamauchi updated the diff for D88838: [PGO] Remove the old memop value profiling buckets..

Update the patch description.

Oct 5 2020, 9:57 AM · Restricted Project, Restricted Project
yamauchi requested review of D88838: [PGO] Remove the old memop value profiling buckets..
Oct 5 2020, 9:54 AM · Restricted Project, Restricted Project

Sep 14 2020

yamauchi added a comment to D86890: [compiler-rt] Remove copy of InstrProfData.inc.

I'm not familiar with the history of this file well, but I had the same impression: it'd be nice if there's a single copy but since compiler-rt is set up to build without depending on llvm/, it's in the way it is currently.

Sep 14 2020, 9:13 AM · Restricted Project, Restricted Project

Sep 9 2020

yamauchi committed rG0ab6a1569806: [X86] Add support for using fast short rep mov for memcpy lowering. (authored by yamauchi).
[X86] Add support for using fast short rep mov for memcpy lowering.
Sep 9 2020, 12:47 PM
yamauchi closed D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Sep 9 2020, 12:47 PM · Restricted Project
yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Rebase.

Sep 9 2020, 12:44 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Sep 9 2020, 12:26 PM · Restricted Project
yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Address comment.

Sep 9 2020, 12:26 PM · Restricted Project
yamauchi added a comment to D87337: [PGO] De-Optimizing cold functions based on PGO info (PATCH 1/2).

As per https://llvm.org/docs/LangRef.html, deopt term appears to be already coined.

Sep 9 2020, 8:57 AM · Restricted Project
yamauchi added a comment to rG8d09f20798ac: [AssumeBundles] Use operand bundles to encode alignment assumptions.

I think this was reverted by https://reviews.llvm.org/rG7bfaa40086359ed7e41c862ab0a65e0bb1be0aeb

Sep 9 2020, 8:22 AM

Sep 2 2020

yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Address comments.

Sep 2 2020, 2:23 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Sep 2 2020, 2:23 PM · Restricted Project
yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Update to remove the getZExtOrTrunc.

Sep 2 2020, 12:51 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Sep 2 2020, 12:51 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Sep 2 2020, 10:41 AM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Sep 2 2020, 9:49 AM · Restricted Project

Aug 31 2020

yamauchi requested review of D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Aug 31 2020, 10:31 AM · Restricted Project

Aug 19 2020

yamauchi committed rG28ccc52c4045: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer. (authored by yamauchi).
[X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer.
Aug 19 2020, 1:40 PM
yamauchi closed D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 1:40 PM · Restricted Project
yamauchi added inline comments to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 1:18 PM · Restricted Project
yamauchi committed rGab401a8c8a9c: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts. (authored by yamauchi).
[PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts.
Aug 19 2020, 12:34 PM
yamauchi closed D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..
Aug 19 2020, 12:34 PM · Restricted Project
yamauchi added inline comments to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 12:25 PM · Restricted Project
yamauchi added inline comments to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 12:08 PM · Restricted Project

Aug 17 2020

yamauchi added a comment to D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..

If shouldOptimizeForSize is not available for loop analysis, should the check of be removed unconditionally instead of gated upon whether there is a hint?

Aug 17 2020, 1:00 PM · Restricted Project
yamauchi added a comment to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..

Is there another patch coming to call hasFSRM()?

Aug 17 2020, 11:53 AM · Restricted Project

Aug 14 2020

yamauchi requested review of D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 14 2020, 12:38 PM · Restricted Project
yamauchi added a comment to D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..

If shouldOptimizeForSize is not available for loop analysis, should the check of be removed unconditionally instead of gated upon whether there is a hint?

Aug 14 2020, 10:28 AM · Restricted Project

Aug 11 2020

yamauchi requested review of D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..
Aug 11 2020, 2:22 PM · Restricted Project

Aug 3 2020

yamauchi committed rG3e89cbf38e76: [PGO] Enable the extended value profile buckets for mem op sizes. (authored by yamauchi).
[PGO] Enable the extended value profile buckets for mem op sizes.
Aug 3 2020, 12:26 PM
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..
Aug 3 2020, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rGf78f509c7586: [PGO] Extend the value profile buckets for mem op sizes. (authored by yamauchi).
[PGO] Extend the value profile buckets for mem op sizes.
Aug 3 2020, 11:04 AM
yamauchi closed D81682: [PGO] Extend the value profile buckets for mem op sizes..
Aug 3 2020, 11:04 AM · Restricted Project, Restricted Project

Jul 31 2020

yamauchi committed rGdcdc77619e1a: [PGO][test] Add test to check memops changes function hash (authored by yamauchi).
[PGO][test] Add test to check memops changes function hash
Jul 31 2020, 9:44 AM
yamauchi closed D84953: [PGO][test] Add test to check memops changes function hash.
Jul 31 2020, 9:43 AM · Restricted Project

Jul 30 2020

yamauchi added a comment to D84953: [PGO][test] Add test to check memops changes function hash.

I think the test should use profile-gen option to compare generated hash of otherwise identical functions (except for memop).

Jul 30 2020, 11:33 AM · Restricted Project
yamauchi updated the diff for D84953: [PGO][test] Add test to check memops changes function hash.

Address comment. Use -pgo-instr-gen.

Jul 30 2020, 11:33 AM · Restricted Project
yamauchi requested review of D84953: [PGO][test] Add test to check memops changes function hash.
Jul 30 2020, 10:22 AM · Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Yup, -pgo-instr-old-cfg-hashing=true to revert back to the old hashing.

Jul 30 2020, 10:20 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rG3d6f53018f84: [PGO] Include the mem ops into the function hash. (authored by yamauchi).
[PGO] Include the mem ops into the function hash.
Jul 30 2020, 9:26 AM

Jul 29 2020

yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Latest update diff:

Jul 29 2020, 5:18 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Use endian::write64le.

Jul 29 2020, 5:16 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Here's the diff in the latest update:

Jul 29 2020, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Fix the endianness issue.

Jul 29 2020, 4:38 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a reverting change for rG120e66b3418b: [PGO] Include the mem ops into the function hash.: rGae7589e1f100: Revert "[PGO] Include the mem ops into the function hash.".
Jul 29 2020, 3:21 PM
yamauchi committed rGae7589e1f100: Revert "[PGO] Include the mem ops into the function hash." (authored by yamauchi).
Revert "[PGO] Include the mem ops into the function hash."
Jul 29 2020, 3:20 PM
yamauchi added a reverting change for D84782: [PGO] Include the mem ops into the function hash.: rGae7589e1f100: Revert "[PGO] Include the mem ops into the function hash.".
Jul 29 2020, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi reopened D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 3:06 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Builtbot failure: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/51984

Jul 29 2020, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rG120e66b3418b: [PGO] Include the mem ops into the function hash. (authored by yamauchi).
[PGO] Include the mem ops into the function hash.
Jul 29 2020, 2:00 PM
yamauchi closed D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 2:00 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Address comments. PTAL.

Jul 29 2020, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Address comment.

Jul 29 2020, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Rebase past D84865.

Jul 29 2020, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rGcd890944ad34: [PGO] Remove insignificant function hash values from some tests. (authored by yamauchi).
[PGO] Remove insignificant function hash values from some tests.
Jul 29 2020, 10:24 AM
yamauchi closed D84865: [PGO] Remove insignificant function hash values from some tests..
Jul 29 2020, 10:24 AM · Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

changes like in llvm/test/Transforms/PGOProfile/PR41279.ll etc can be independently committed.

Jul 29 2020, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi requested review of D84865: [PGO] Remove insignificant function hash values from some tests..
Jul 29 2020, 9:16 AM · Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 9:02 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Address comment.

Jul 29 2020, 9:02 AM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2020

yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Can you split out the test changes and commit it separately?

Jul 28 2020, 5:23 PM · Restricted Project, Restricted Project, Restricted Project