Page MenuHomePhabricator

yamauchi (Hiroshi Yamauchi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 5:32 PM (99 w, 9 h)

Recent Activity

Yesterday

yamauchi committed rGdfeb79745569: [PGO][CHR] Speed up following long use-def chains. (authored by yamauchi).
[PGO][CHR] Speed up following long use-def chains.
Wed, May 22, 11:36 AM
yamauchi committed rL361416: [PGO][CHR] Speed up following long use-def chains..
[PGO][CHR] Speed up following long use-def chains.
Wed, May 22, 11:34 AM
yamauchi closed D62262: [PGO][CHR] Speed up following long use-def chains..
Wed, May 22, 11:34 AM · Restricted Project
yamauchi added a comment to D62262: [PGO][CHR] Speed up following long use-def chains..

was there a quadratic behavior before ? It seems linear before and after the patch -- but just cut the computation by a factor of 2 . Do you need an option to control the max chain length?

Wed, May 22, 11:29 AM · Restricted Project
yamauchi created D62262: [PGO][CHR] Speed up following long use-def chains..
Wed, May 22, 9:54 AM · Restricted Project

Wed, May 15

yamauchi committed rG7dfd087a9a59: [JumpThreading] A bug fix for stale loop info after unfold select (authored by yamauchi).
[JumpThreading] A bug fix for stale loop info after unfold select
Wed, May 15, 8:13 AM
yamauchi committed rL360780: [JumpThreading] A bug fix for stale loop info after unfold select.
[JumpThreading] A bug fix for stale loop info after unfold select
Wed, May 15, 8:12 AM
yamauchi closed D61920: [JumpThreading] A bug fix for stale loop info after unfold select.
Wed, May 15, 8:12 AM · Restricted Project

Tue, May 14

yamauchi updated the diff for D61920: [JumpThreading] A bug fix for stale loop info after unfold select.

Use 'verify<loops>' instead.

Tue, May 14, 4:01 PM · Restricted Project
yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

It looked like a latent bug in jump threading. Uploaded a fix https://reviews.llvm.org/D61920

Tue, May 14, 3:23 PM · Restricted Project
yamauchi created D61920: [JumpThreading] A bug fix for stale loop info after unfold select.
Tue, May 14, 3:19 PM · Restricted Project
yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

Thanks.

Tue, May 14, 11:21 AM · Restricted Project

Tue, May 7

yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

Yes, please send a reproducer.

Tue, May 7, 8:16 AM · Restricted Project

Wed, May 1

yamauchi committed rG16201040344e: [PGO][CHR] A bug fix. (authored by yamauchi).
[PGO][CHR] A bug fix.
Wed, May 1, 3:48 PM
yamauchi committed rL359736: [PGO][CHR] A bug fix..
[PGO][CHR] A bug fix.
Wed, May 1, 3:47 PM
yamauchi closed D61405: [PGO][CHR] A bug fix..
Wed, May 1, 3:47 PM · Restricted Project
yamauchi added inline comments to D61405: [PGO][CHR] A bug fix..
Wed, May 1, 3:18 PM · Restricted Project
yamauchi added inline comments to D61405: [PGO][CHR] A bug fix..
Wed, May 1, 3:13 PM · Restricted Project
yamauchi created D61405: [PGO][CHR] A bug fix..
Wed, May 1, 2:49 PM · Restricted Project

Apr 15 2019

yamauchi committed rG5221532a4eb4: Fix header guard typo and build error. (authored by yamauchi).
Fix header guard typo and build error.
Apr 15 2019, 10:31 AM
yamauchi committed rL358429: Fix header guard typo and build error..
Fix header guard typo and build error.
Apr 15 2019, 10:27 AM
yamauchi committed rG09e539fcaebb: [PGO] Profile guided code size optimization. (authored by yamauchi).
[PGO] Profile guided code size optimization.
Apr 15 2019, 9:48 AM
yamauchi committed rL358422: [PGO] Profile guided code size optimization..
[PGO] Profile guided code size optimization.
Apr 15 2019, 9:47 AM
yamauchi closed D59514: [PGO] Profile guided code size optimization..
Apr 15 2019, 9:47 AM · Restricted Project
yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Rebased.

Apr 15 2019, 9:47 AM · Restricted Project

Apr 12 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Rebased.

Apr 12 2019, 1:45 PM · Restricted Project
yamauchi committed rGc27ff0d32db8: Add options for MaxLoadsPerMemcmp(OptSize). (authored by yamauchi).
Add options for MaxLoadsPerMemcmp(OptSize).
Apr 12 2019, 8:05 AM
yamauchi committed rL358287: Add options for MaxLoadsPerMemcmp(OptSize)..
Add options for MaxLoadsPerMemcmp(OptSize).
Apr 12 2019, 8:04 AM
yamauchi closed D60587: Add options for MaxLoadsPerMemcmp(OptSize)..
Apr 12 2019, 8:04 AM · Restricted Project

Apr 11 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Addressed comments.

Apr 11 2019, 3:05 PM · Restricted Project
yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Apr 11 2019, 3:05 PM · Restricted Project
yamauchi created D60587: Add options for MaxLoadsPerMemcmp(OptSize)..
Apr 11 2019, 2:36 PM · Restricted Project
yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Addressed comments.

Apr 11 2019, 10:37 AM · Restricted Project
yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Apr 11 2019, 10:37 AM · Restricted Project

Apr 5 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Moved the code out of ProfileSummaryInfo to separate files. PTAL.

Apr 5 2019, 12:34 PM · Restricted Project

Apr 3 2019

yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

...it must be somewhere above IR/Analysis/CodeGen yet accessible from Transform/CodeGen....

Apr 3 2019, 11:18 AM · Restricted Project
yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Apr 3 2019, 10:16 AM · Restricted Project

Apr 2 2019

yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

Easwaran and David, more comments?

Apr 2 2019, 8:24 AM · Restricted Project

Mar 26 2019

yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Mar 26 2019, 3:55 PM · Restricted Project
yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

address comments.

Mar 26 2019, 3:52 PM · Restricted Project

Mar 21 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Address comment.

Mar 21 2019, 1:42 PM · Restricted Project

Mar 20 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Addressed comments. Tests added.

Mar 20 2019, 2:47 PM · Restricted Project

Mar 18 2019

yamauchi created D59514: [PGO] Profile guided code size optimization..
Mar 18 2019, 2:23 PM · Restricted Project

Mar 1 2019

yamauchi created D58845: Sketch for getting PSI/BFI from various passes under new pass manager..
Mar 1 2019, 1:34 PM · Restricted Project

Sep 18 2018

yamauchi committed rL342495: [PGO][CHR] Add opt remarks..
[PGO][CHR] Add opt remarks.
Sep 18 2018, 9:51 AM
yamauchi closed D52056: [PGO][CHR] Add opt remarks..
Sep 18 2018, 9:51 AM

Sep 17 2018

yamauchi updated the diff for D52056: [PGO][CHR] Add opt remarks..

Comments addressed.

Sep 17 2018, 11:40 AM

Sep 13 2018

yamauchi created D52056: [PGO][CHR] Add opt remarks..
Sep 13 2018, 1:21 PM

Sep 7 2018

yamauchi accepted D51811: [PGO] Fix some style issue of ControlHeightReduction.

Thanks!

Sep 7 2018, 1:07 PM
yamauchi committed rL341692: [PGO][CHR] Build/warning fix.
[PGO][CHR] Build/warning fix
Sep 7 2018, 11:46 AM
yamauchi committed rL341681: [PGO][CHR] Small cleanup..
[PGO][CHR] Small cleanup.
Sep 7 2018, 11:02 AM
yamauchi closed D51740: [PGO][CHR] Small cleanup..
Sep 7 2018, 11:02 AM
yamauchi added inline comments to D51740: [PGO][CHR] Small cleanup..
Sep 7 2018, 10:00 AM
yamauchi added inline comments to D51740: [PGO][CHR] Small cleanup..
Sep 7 2018, 9:54 AM

Sep 6 2018

yamauchi created D51740: [PGO][CHR] Small cleanup..
Sep 6 2018, 11:07 AM

Sep 5 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Sep 5 2018, 8:42 AM

Sep 4 2018

yamauchi committed rL341412: Fix a memory leak after rL341386..
Fix a memory leak after rL341386.
Sep 4 2018, 2:29 PM
yamauchi closed D51658: Fix a memory leak after rL341386..
Sep 4 2018, 2:29 PM
yamauchi updated the diff for D51658: Fix a memory leak after rL341386..

Rebased.

Sep 4 2018, 2:21 PM
yamauchi created D51658: Fix a memory leak after rL341386..
Sep 4 2018, 2:12 PM
yamauchi committed rL341391: Fix build failures after rL341386..
Fix build failures after rL341386.
Sep 4 2018, 11:14 AM
yamauchi closed D51647: Fix build failures after rL341386..
Sep 4 2018, 11:14 AM
yamauchi created D51647: Fix build failures after rL341386..
Sep 4 2018, 11:08 AM
yamauchi committed rL341386: [PGO] Control Height Reduction.
[PGO] Control Height Reduction
Sep 4 2018, 10:20 AM
yamauchi closed D50591: [PGO] Control Height Reduction.
Sep 4 2018, 10:20 AM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Rebased.

Sep 4 2018, 10:19 AM
yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Sep 4 2018, 10:01 AM

Aug 29 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Aug 29 2018, 3:18 PM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Updated.

Aug 29 2018, 3:18 PM

Aug 27 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Aug 27 2018, 4:05 PM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Addressed comments.

Aug 27 2018, 4:04 PM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Added one more metric to the stats.

Aug 27 2018, 1:52 PM

Aug 24 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Aug 24 2018, 10:16 AM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Addressed comments.

Aug 24 2018, 10:16 AM

Aug 22 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Aug 22 2018, 8:05 AM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Addressed comments.

Aug 22 2018, 8:05 AM

Aug 17 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Aug 17 2018, 4:17 PM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Addressed more comments.

Aug 17 2018, 4:17 PM
yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Aug 17 2018, 12:54 PM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Updated the .cpp file.

Aug 17 2018, 12:53 PM

Aug 15 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Aug 15 2018, 2:04 PM
yamauchi updated the diff for D50591: [PGO] Control Height Reduction.

Updated the test file.

Aug 15 2018, 2:04 PM

Aug 10 2018

yamauchi created D50591: [PGO] Control Height Reduction.
Aug 10 2018, 4:51 PM

Jul 11 2018

yamauchi added inline comments to D49179: [InstCombine] Fold x & (-1 >> y) == x to x u<= (-1 >> y) .
Jul 11 2018, 3:35 PM

May 22 2018

yamauchi added inline comments to D41574: [Transforms] Adding a WeakReassociate pass.
May 22 2018, 10:58 AM

May 9 2018

yamauchi added inline comments to D46595: [InstCombine] Apply SimplifyUsingDistributiveLaws to associative/commutative cases..
May 9 2018, 10:49 AM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

Here's a comparison with D45842 for the 4th test @bit-check-combine-256 (which I understand is a long one, I'll try to see if I can reduce this.)

May 9 2018, 10:08 AM

May 8 2018

yamauchi added a comment to D46595: [InstCombine] Apply SimplifyUsingDistributiveLaws to associative/commutative cases..

After -instcombine with D46336

May 8 2018, 12:16 PM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

D46595 is a simpler but limited version of this. Note the test @bit-check-combine-256() doesn't get folded there as simple as here. But it doesn't modify the run loop and is less complex.

May 8 2018, 12:04 PM
yamauchi added a comment to D46595: [InstCombine] Apply SimplifyUsingDistributiveLaws to associative/commutative cases..

This is a simpler, but limited version of D46336. Note the test @bit-check-combine-256() doesn't get folded as simple as in D46336.

May 8 2018, 12:01 PM
yamauchi created D46595: [InstCombine] Apply SimplifyUsingDistributiveLaws to associative/commutative cases..
May 8 2018, 11:59 AM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

I'd guess something in instcombine does not use commutative matchers.
(I did not analyse this at all yet, just 'saving' it as one comment)
https://rise4fun.com/Alive/PsC

May 8 2018, 10:13 AM

May 7 2018

yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

After -instcombine -reassociate -instcombine -reassociate -instcombine with D45842

May 7 2018, 4:05 PM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

Having looked through D45842, i find this differential rather more complex.
Maybe instcombine shouldn't be doing this..

It would be interesting to know which of these testcase *aren't* handled by D45842.

May 7 2018, 3:49 PM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

Thanks for finding that thread...somehow I find it difficult to search llvm-dev history...

May 7 2018, 3:46 PM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

I think part of this has already landed with:
rL331311

What's 'this'? I am not clear how rL331311 (partially?) helps with the bitcheck combining this patch is aiming for. Do you mean a similar approach could be taken?

I was assuming from the name of this and similar tests:
"bit-check-combine1"
that 'this' was looking for any-bit-set / any-bit-clear / all-bits-set / all-bits-clear. Maybe the patterns you're looking for don't look like what I am matching though? If I run -instcombine on the first test, it is already substantially reduced...and at that point, it just looks like a problem for -reassociation?

define i1 @bit-check-combine1(i32 %a, i32 %b) {
entry:
  %0 = and i32 %b, 8
  %1 = and i32 %b, 16
  %2 = and i32 %b, 32
  %3 = and i32 %a, 7   <--- we got lucky on this one and found the reduction
  %4 = or i32 %3, %0
  %5 = or i32 %4, %1    <--- reassociate the 'or' operands, so we can factor out the mask ops
  %6 = or i32 %5, %2
  %7 = icmp eq i32 %6, 0
  ret i1 %7
}
May 7 2018, 3:34 PM

May 3 2018

yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

Re: bloat, is the consensus that we just don't add to instcombine any more?

May 3 2018, 4:38 PM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

FWIW, a nice thing is that this patch doesn't need to recognize and combine some specific patterns (eg. bitchecks, FoldPHIArgOrIntoPHI (D44626) or and-or-lshr (D45986)) or use some reassociation/canonicalization rules/orders based on some specific patterns (eg. some binops that operate on the same value for bitchecks, a certain definition of “matching pair” like D45842 or the ranking in the reassociate pass) (and those orders might conflict among them).

May 3 2018, 3:12 PM
yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

I think part of this has already landed with:
rL331311

May 3 2018, 2:32 PM

May 2 2018

yamauchi added a comment to D46336: [InstCombine] Apply binary operator simplifications to associative/commutative cases..

I think part of this has already landed with:
rL331311

There are proposals trying to do reassociation in a more complete way outside of instcombine:
D45842 (this would catch the cases that I recently added to and-xor-or.ll)
D41574

This is a response to discussions on llvm-dev that instcombine is already trying to do too much. This patch goes against that idea.

May 2 2018, 3:55 PM