Page MenuHomePhabricator

yamauchi (Hiroshi Yamauchi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 5:32 PM (116 w, 8 h)

Recent Activity

Yesterday

yamauchi updated the diff for D67120: [PGO] Profile guided code size optimization (continued)..

Update to sync with D67377.

Wed, Sep 18, 2:12 PM · Restricted Project
yamauchi added a comment to D67377: [PGO][PGSO] ProfileSummary changes..

PTAL.

Wed, Sep 18, 1:28 PM · Restricted Project
yamauchi updated the diff for D67377: [PGO][PGSO] ProfileSummary changes..

Moved 'PGSO' out of ProfileSummary.

Wed, Sep 18, 1:26 PM · Restricted Project

Wed, Sep 11

yamauchi added a comment to D67377: [PGO][PGSO] ProfileSummary changes..

I don't think we should use 'PGSO' in the profile summary class. Instead, we should differentiate it from 'hot' with other categories like VeryHot, LukeWarm etc ...

Wed, Sep 11, 10:37 AM · Restricted Project

Tue, Sep 10

yamauchi added a comment to D67377: [PGO][PGSO] ProfileSummary changes..

The abbreviation PGSO is used throughout the code but never defined. Suggest defining it in a few places (e.g. on the new data members and function declarations).

Tue, Sep 10, 10:49 AM · Restricted Project
yamauchi added inline comments to D67377: [PGO][PGSO] ProfileSummary changes..
Tue, Sep 10, 10:49 AM · Restricted Project
yamauchi updated the diff for D67377: [PGO][PGSO] ProfileSummary changes..

Update.

Tue, Sep 10, 10:49 AM · Restricted Project
yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Split the PSI changes into https://reviews.llvm.org/D67377.

Tue, Sep 10, 9:53 AM · Restricted Project

Mon, Sep 9

yamauchi created D67377: [PGO][PGSO] ProfileSummary changes..
Mon, Sep 9, 3:38 PM · Restricted Project

Fri, Sep 6

yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Will split.

Fri, Sep 6, 2:42 PM · Restricted Project
yamauchi updated the diff for D67120: [PGO] Profile guided code size optimization (continued)..

Update.

Fri, Sep 6, 2:42 PM · Restricted Project

Thu, Sep 5

yamauchi committed rGd842f2eec4bb: [PGO][CHR] Speed up following long, interlinked use-def chains. (authored by yamauchi).
[PGO][CHR] Speed up following long, interlinked use-def chains.
Thu, Sep 5, 9:58 AM
yamauchi committed rL371086: [PGO][CHR] Speed up following long, interlinked use-def chains..
[PGO][CHR] Speed up following long, interlinked use-def chains.
Thu, Sep 5, 9:55 AM
yamauchi closed D67198: [PGO][CHR] Speed up following long, interlinked use-def chains..
Thu, Sep 5, 9:55 AM · Restricted Project
yamauchi added a comment to D67198: [PGO][CHR] Speed up following long, interlinked use-def chains..

you can probably speed up it a little by using the insert interface, but it may make code less readable. LGTM

Thu, Sep 5, 9:54 AM · Restricted Project
yamauchi updated the diff for D67198: [PGO][CHR] Speed up following long, interlinked use-def chains..

Use insert.

Thu, Sep 5, 9:54 AM · Restricted Project

Wed, Sep 4

yamauchi created D67198: [PGO][CHR] Speed up following long, interlinked use-def chains..
Wed, Sep 4, 3:45 PM · Restricted Project

Tue, Sep 3

yamauchi created D67120: [PGO] Profile guided code size optimization (continued)..
Tue, Sep 3, 11:23 AM · Restricted Project

Tue, Aug 27

yamauchi accepted D66711: [clang] Warning for non-final classes with final destructors.

LGTM.

Tue, Aug 27, 11:01 AM · Restricted Project, Restricted Project

Fri, Aug 23

yamauchi added a comment to D66621: [clang] Devirtualization for classes with destructors marked as 'final'.

This seems subtle, but I believe it is correct.

I wonder whether we should provide a warning for a non-final class has a final destructor, since moving the final from the destructor to the class seems like a more obvious way to present the code (and will likely lead to better code generation in compilers that haven't realized they can do this).

Fri, Aug 23, 8:34 AM · Restricted Project, Restricted Project

Aug 9 2019

yamauchi added a comment to D65975: [NewPM][PassInstrumentation] IR printing support from clang driver.

@fedor.sergeev @yamauchi I saw your discussions over llvm-dev mailing list regarding IR printing with the new pass manager, and though this might be the reason why IR printing is not supported under new PM with clang. I would appreciate if you can take a look.

Aug 9 2019, 9:40 AM · Restricted Project, Restricted Project

Aug 8 2019

yamauchi committed rGcb30590da10b: Recommit Devirtualize destructor of final class. (authored by yamauchi).
Recommit Devirtualize destructor of final class.
Aug 8 2019, 11:01 AM
yamauchi committed rL368323: Recommit Devirtualize destructor of final class..
Recommit Devirtualize destructor of final class.
Aug 8 2019, 11:00 AM

Jul 11 2019

yamauchi closed D63161: Devirtualize destructor of final class..
Jul 11 2019, 8:57 AM · Restricted Project, Restricted Project

Jul 9 2019

yamauchi added a comment to rL364359: Revert Devirtualize destructor of final class..

This revert was reverted as https://reviews.llvm.org/rL365509.

Jul 9 2019, 1:36 PM
yamauchi added a comment to D63161: Devirtualize destructor of final class..

Recommitted as https://reviews.llvm.org/rL365509

Jul 9 2019, 1:34 PM · Restricted Project, Restricted Project
yamauchi committed rGd088720edad9: Revert Revert Devirtualize destructor of final class. (authored by yamauchi).
Revert Revert Devirtualize destructor of final class.
Jul 9 2019, 8:58 AM
yamauchi committed rL365509: Revert Revert Devirtualize destructor of final class..
Revert Revert Devirtualize destructor of final class.
Jul 9 2019, 8:58 AM

Jul 8 2019

yamauchi added a comment to D63161: Devirtualize destructor of final class..

This was reverted due to some internal test failure. But it turned out a false alarm. I'll work on recommitting it.

Jul 8 2019, 9:46 AM · Restricted Project, Restricted Project

Jun 21 2019

yamauchi committed rL364100: Devirtualize destructor of final class..
Devirtualize destructor of final class.
Jun 21 2019, 1:15 PM
yamauchi committed rG405c2b16225f: Devirtualize destructor of final class. (authored by yamauchi).
Devirtualize destructor of final class.
Jun 21 2019, 1:15 PM
yamauchi closed D63161: Devirtualize destructor of final class..
Jun 21 2019, 1:10 PM · Restricted Project, Restricted Project
yamauchi updated the diff for D63161: Devirtualize destructor of final class..

Comments addressed.

Jun 21 2019, 1:01 PM · Restricted Project, Restricted Project

Jun 18 2019

yamauchi updated the diff for D63161: Devirtualize destructor of final class..

Updated.

Jun 18 2019, 9:57 AM · Restricted Project, Restricted Project

Jun 17 2019

yamauchi added inline comments to D63161: Devirtualize destructor of final class..
Jun 17 2019, 3:21 PM · Restricted Project, Restricted Project

Jun 14 2019

yamauchi added inline comments to D63161: Devirtualize destructor of final class..
Jun 14 2019, 2:52 PM · Restricted Project, Restricted Project
yamauchi updated the diff for D63161: Devirtualize destructor of final class..

Addressed comment.

Jun 14 2019, 2:50 PM · Restricted Project, Restricted Project

Jun 12 2019

yamauchi added inline comments to D63161: Devirtualize destructor of final class..
Jun 12 2019, 3:08 PM · Restricted Project, Restricted Project
yamauchi updated the diff for D63161: Devirtualize destructor of final class..

Using getDevirtualizedMethod.

Jun 12 2019, 3:05 PM · Restricted Project, Restricted Project

Jun 11 2019

yamauchi created D63161: Devirtualize destructor of final class..
Jun 11 2019, 1:12 PM · Restricted Project, Restricted Project

May 22 2019

yamauchi committed rGdfeb79745569: [PGO][CHR] Speed up following long use-def chains. (authored by yamauchi).
[PGO][CHR] Speed up following long use-def chains.
May 22 2019, 11:36 AM
yamauchi committed rL361416: [PGO][CHR] Speed up following long use-def chains..
[PGO][CHR] Speed up following long use-def chains.
May 22 2019, 11:34 AM
yamauchi closed D62262: [PGO][CHR] Speed up following long use-def chains..
May 22 2019, 11:34 AM · Restricted Project
yamauchi added a comment to D62262: [PGO][CHR] Speed up following long use-def chains..

was there a quadratic behavior before ? It seems linear before and after the patch -- but just cut the computation by a factor of 2 . Do you need an option to control the max chain length?

May 22 2019, 11:29 AM · Restricted Project
yamauchi created D62262: [PGO][CHR] Speed up following long use-def chains..
May 22 2019, 9:54 AM · Restricted Project

May 15 2019

yamauchi committed rG7dfd087a9a59: [JumpThreading] A bug fix for stale loop info after unfold select (authored by yamauchi).
[JumpThreading] A bug fix for stale loop info after unfold select
May 15 2019, 8:13 AM
yamauchi committed rL360780: [JumpThreading] A bug fix for stale loop info after unfold select.
[JumpThreading] A bug fix for stale loop info after unfold select
May 15 2019, 8:12 AM
yamauchi closed D61920: [JumpThreading] A bug fix for stale loop info after unfold select.
May 15 2019, 8:12 AM · Restricted Project

May 14 2019

yamauchi updated the diff for D61920: [JumpThreading] A bug fix for stale loop info after unfold select.

Use 'verify<loops>' instead.

May 14 2019, 4:01 PM · Restricted Project
yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

It looked like a latent bug in jump threading. Uploaded a fix https://reviews.llvm.org/D61920

May 14 2019, 3:23 PM · Restricted Project
yamauchi created D61920: [JumpThreading] A bug fix for stale loop info after unfold select.
May 14 2019, 3:19 PM · Restricted Project
yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

Thanks.

May 14 2019, 11:21 AM · Restricted Project

May 7 2019

yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

Yes, please send a reproducer.

May 7 2019, 8:16 AM · Restricted Project

May 1 2019

yamauchi committed rG16201040344e: [PGO][CHR] A bug fix. (authored by yamauchi).
[PGO][CHR] A bug fix.
May 1 2019, 3:48 PM
yamauchi committed rL359736: [PGO][CHR] A bug fix..
[PGO][CHR] A bug fix.
May 1 2019, 3:47 PM
yamauchi closed D61405: [PGO][CHR] A bug fix..
May 1 2019, 3:47 PM · Restricted Project
yamauchi added inline comments to D61405: [PGO][CHR] A bug fix..
May 1 2019, 3:18 PM · Restricted Project
yamauchi added inline comments to D61405: [PGO][CHR] A bug fix..
May 1 2019, 3:13 PM · Restricted Project
yamauchi created D61405: [PGO][CHR] A bug fix..
May 1 2019, 2:49 PM · Restricted Project

Apr 15 2019

yamauchi committed rG5221532a4eb4: Fix header guard typo and build error. (authored by yamauchi).
Fix header guard typo and build error.
Apr 15 2019, 10:31 AM
yamauchi committed rL358429: Fix header guard typo and build error..
Fix header guard typo and build error.
Apr 15 2019, 10:27 AM
yamauchi committed rG09e539fcaebb: [PGO] Profile guided code size optimization. (authored by yamauchi).
[PGO] Profile guided code size optimization.
Apr 15 2019, 9:48 AM
yamauchi committed rL358422: [PGO] Profile guided code size optimization..
[PGO] Profile guided code size optimization.
Apr 15 2019, 9:47 AM
yamauchi closed D59514: [PGO] Profile guided code size optimization..
Apr 15 2019, 9:47 AM · Restricted Project
yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Rebased.

Apr 15 2019, 9:47 AM · Restricted Project

Apr 12 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Rebased.

Apr 12 2019, 1:45 PM · Restricted Project
yamauchi committed rGc27ff0d32db8: Add options for MaxLoadsPerMemcmp(OptSize). (authored by yamauchi).
Add options for MaxLoadsPerMemcmp(OptSize).
Apr 12 2019, 8:05 AM
yamauchi committed rL358287: Add options for MaxLoadsPerMemcmp(OptSize)..
Add options for MaxLoadsPerMemcmp(OptSize).
Apr 12 2019, 8:04 AM
yamauchi closed D60587: Add options for MaxLoadsPerMemcmp(OptSize)..
Apr 12 2019, 8:04 AM · Restricted Project

Apr 11 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Addressed comments.

Apr 11 2019, 3:05 PM · Restricted Project
yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Apr 11 2019, 3:05 PM · Restricted Project
yamauchi created D60587: Add options for MaxLoadsPerMemcmp(OptSize)..
Apr 11 2019, 2:36 PM · Restricted Project
yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Addressed comments.

Apr 11 2019, 10:37 AM · Restricted Project
yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Apr 11 2019, 10:37 AM · Restricted Project

Apr 5 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Moved the code out of ProfileSummaryInfo to separate files. PTAL.

Apr 5 2019, 12:34 PM · Restricted Project

Apr 3 2019

yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

...it must be somewhere above IR/Analysis/CodeGen yet accessible from Transform/CodeGen....

Apr 3 2019, 11:18 AM · Restricted Project
yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Apr 3 2019, 10:16 AM · Restricted Project

Apr 2 2019

yamauchi added a comment to D59514: [PGO] Profile guided code size optimization..

Easwaran and David, more comments?

Apr 2 2019, 8:24 AM · Restricted Project

Mar 26 2019

yamauchi added inline comments to D59514: [PGO] Profile guided code size optimization..
Mar 26 2019, 3:55 PM · Restricted Project
yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

address comments.

Mar 26 2019, 3:52 PM · Restricted Project

Mar 21 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Address comment.

Mar 21 2019, 1:42 PM · Restricted Project

Mar 20 2019

yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Addressed comments. Tests added.

Mar 20 2019, 2:47 PM · Restricted Project

Mar 18 2019

yamauchi created D59514: [PGO] Profile guided code size optimization..
Mar 18 2019, 2:23 PM · Restricted Project

Mar 1 2019

yamauchi created D58845: Sketch for getting PSI/BFI from various passes under new pass manager..
Mar 1 2019, 1:34 PM · Restricted Project

Sep 18 2018

yamauchi committed rL342495: [PGO][CHR] Add opt remarks..
[PGO][CHR] Add opt remarks.
Sep 18 2018, 9:51 AM
yamauchi closed D52056: [PGO][CHR] Add opt remarks..
Sep 18 2018, 9:51 AM

Sep 17 2018

yamauchi updated the diff for D52056: [PGO][CHR] Add opt remarks..

Comments addressed.

Sep 17 2018, 11:40 AM

Sep 13 2018

yamauchi created D52056: [PGO][CHR] Add opt remarks..
Sep 13 2018, 1:21 PM

Sep 7 2018

yamauchi accepted D51811: [PGO] Fix some style issue of ControlHeightReduction.

Thanks!

Sep 7 2018, 1:07 PM
yamauchi committed rL341692: [PGO][CHR] Build/warning fix.
[PGO][CHR] Build/warning fix
Sep 7 2018, 11:46 AM
yamauchi committed rL341681: [PGO][CHR] Small cleanup..
[PGO][CHR] Small cleanup.
Sep 7 2018, 11:02 AM
yamauchi closed D51740: [PGO][CHR] Small cleanup..
Sep 7 2018, 11:02 AM
yamauchi added inline comments to D51740: [PGO][CHR] Small cleanup..
Sep 7 2018, 10:00 AM
yamauchi added inline comments to D51740: [PGO][CHR] Small cleanup..
Sep 7 2018, 9:54 AM

Sep 6 2018

yamauchi created D51740: [PGO][CHR] Small cleanup..
Sep 6 2018, 11:07 AM

Sep 5 2018

yamauchi added inline comments to D50591: [PGO] Control Height Reduction.
Sep 5 2018, 8:42 AM

Sep 4 2018

yamauchi committed rL341412: Fix a memory leak after rL341386..
Fix a memory leak after rL341386.
Sep 4 2018, 2:29 PM
yamauchi closed D51658: Fix a memory leak after rL341386..
Sep 4 2018, 2:29 PM
yamauchi updated the diff for D51658: Fix a memory leak after rL341386..

Rebased.

Sep 4 2018, 2:21 PM
yamauchi created D51658: Fix a memory leak after rL341386..
Sep 4 2018, 2:12 PM