Page MenuHomePhabricator

yamauchi (Hiroshi Yamauchi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 5:32 PM (133 w, 2 d)

Recent Activity

Yesterday

yamauchi added a comment to D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

To repeat/expand my question above,..

Fri, Jan 17, 1:07 PM · Restricted Project
yamauchi updated the diff for D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

Address comment. PTAL.

Fri, Jan 17, 11:02 AM · Restricted Project
yamauchi created D72937: [PGO][PGSO] Tune flags for profile guided size optimization..
Fri, Jan 17, 10:13 AM · Restricted Project
yamauchi added a comment to D71308: [CallPromotionUtils] Add tryPromoteCall..

This depends on D71307 and wouldn't work without it. Can you take a look at that again?

Fri, Jan 17, 9:25 AM · Restricted Project

Thu, Jan 16

yamauchi updated the diff for D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration..

Rebase.

Thu, Jan 16, 2:06 PM · Restricted Project
yamauchi added a comment to D71308: [CallPromotionUtils] Add tryPromoteCall..

PTAL.

Thu, Jan 16, 1:55 PM · Restricted Project
yamauchi added inline comments to D71308: [CallPromotionUtils] Add tryPromoteCall..
Thu, Jan 16, 1:55 PM · Restricted Project
yamauchi updated the diff for D71308: [CallPromotionUtils] Add tryPromoteCall..

Address comments and rebase.

Thu, Jan 16, 1:55 PM · Restricted Project
yamauchi updated the diff for D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

Rebased.

Thu, Jan 16, 1:37 PM · Restricted Project

Wed, Jan 15

yamauchi accepted D72790: [SampleFDO] Fix invalid branch profile generated by indirect call promotion.
Wed, Jan 15, 11:09 AM · Restricted Project

Mon, Jan 13

yamauchi committed rG7b9f8e17d15d: [PGO][CHR] Guard against 0-to-0 branch weight and avoid division by zero crash. (authored by yamauchi).
[PGO][CHR] Guard against 0-to-0 branch weight and avoid division by zero crash.
Mon, Jan 13, 2:40 PM
yamauchi closed D72653: [PGO][CHR] Guard against 0-to-0 branch weight and avoid division by zero crash..
Mon, Jan 13, 2:40 PM · Restricted Project
yamauchi created D72653: [PGO][CHR] Guard against 0-to-0 branch weight and avoid division by zero crash..
Mon, Jan 13, 2:22 PM · Restricted Project

Wed, Jan 8

yamauchi added a comment to D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration..

Use AAManager (include/llvm/Analysis/AliasAnalysis.h) by registering only BasicAA ?

Wed, Jan 8, 1:37 PM · Restricted Project

Fri, Dec 20

yamauchi added a comment to D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

I believe if I request AA in Inliner.cpp and pass it down to FindAvailableLoadedValue through tryPromoteCall (D71308), it would work without this patch.

Fri, Dec 20, 9:09 AM · Restricted Project

Thu, Dec 19

yamauchi added a comment to D71308: [CallPromotionUtils] Add tryPromoteCall..

Any comment?

Thu, Dec 19, 3:43 PM · Restricted Project
yamauchi added a comment to D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

Any comment?

Thu, Dec 19, 3:43 PM · Restricted Project

Dec 13 2019

yamauchi committed rGed50e6060b1c: [PGO][PGSO] Enable size optimizations in code gen / target passes for cold code. (authored by yamauchi).
[PGO][PGSO] Enable size optimizations in code gen / target passes for cold code.
Dec 13 2019, 11:10 AM
yamauchi closed D71288: [PGO][PGSO] Enable size optimizations in code gen / target passes for cold code..
Dec 13 2019, 11:10 AM · Restricted Project

Dec 10 2019

yamauchi updated the diff for D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration..

Split the utility code into D71307 and D71308.

Dec 10 2019, 3:29 PM · Restricted Project
yamauchi added a comment to D71308: [CallPromotionUtils] Add tryPromoteCall..

This is split off of D69591.

Dec 10 2019, 3:29 PM · Restricted Project
yamauchi added a comment to D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

This is split off of D69591.

Dec 10 2019, 3:29 PM · Restricted Project
yamauchi created D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..
Dec 10 2019, 3:29 PM · Restricted Project
yamauchi created D71308: [CallPromotionUtils] Add tryPromoteCall..
Dec 10 2019, 3:29 PM · Restricted Project
yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Split into D71288 to enable in the code gen passes for cold code.

Dec 10 2019, 10:46 AM · Restricted Project
yamauchi created D71288: [PGO][PGSO] Enable size optimizations in code gen / target passes for cold code..
Dec 10 2019, 10:46 AM · Restricted Project
yamauchi added a child revision for D71149: [PGO][PGSO] Instrument the code gen / target passes.: D67120: [PGO] Profile guided code size optimization (continued)..
Dec 10 2019, 10:37 AM · Restricted Project
yamauchi updated the summary of D67120: [PGO] Profile guided code size optimization (continued)..
Dec 10 2019, 10:37 AM · Restricted Project

Dec 9 2019

yamauchi committed rGd9ae493937c7: [PGO][PGSO] Instrument the code gen / target passes. (authored by yamauchi).
[PGO][PGSO] Instrument the code gen / target passes.
Dec 9 2019, 12:44 PM
yamauchi added a reverting change for D71072: [PGO][PGSO] Instrument the code gen / target passes.: rGd9ae493937c7: [PGO][PGSO] Instrument the code gen / target passes..
Dec 9 2019, 12:44 PM · Restricted Project
yamauchi closed D71149: [PGO][PGSO] Instrument the code gen / target passes..
Dec 9 2019, 12:44 PM · Restricted Project

Dec 6 2019

yamauchi added a comment to D71149: [PGO][PGSO] Instrument the code gen / target passes..

The diff from D71072 is MachineOptimizationRemarkEmitter.h and AsmPrinter.cpp around line 1694.

Dec 6 2019, 2:15 PM · Restricted Project
yamauchi added a comment to D71072: [PGO][PGSO] Instrument the code gen / target passes..

A fixed version D71072.

Dec 6 2019, 2:07 PM · Restricted Project
yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

D71149 is a replacement for reverted D71072.

Dec 6 2019, 2:07 PM · Restricted Project
yamauchi created D71149: [PGO][PGSO] Instrument the code gen / target passes..
Dec 6 2019, 2:06 PM · Restricted Project
yamauchi added a reverting change for D71072: [PGO][PGSO] Instrument the code gen / target passes.: D71149: [PGO][PGSO] Instrument the code gen / target passes..
Dec 6 2019, 2:06 PM · Restricted Project
yamauchi added a comment to D71072: [PGO][PGSO] Instrument the code gen / target passes..

The issue was that in AsmPrinter ORE also depends on LazyMachineBlockFrequencyInfo and *conditionally* computes MBFI. Trying to compute it twice would delete the first one and causes an access-after-free error in ORE. I think a fix would be to compute MBFI once and share it (use one from ORE if it is available and compute one otherwise.)

Dec 6 2019, 1:48 PM · Restricted Project
yamauchi added a comment to D71072: [PGO][PGSO] Instrument the code gen / target passes..

Locally reproduced the failure

Dec 6 2019, 1:02 PM · Restricted Project
yamauchi added a reverting change for rG9a0b5e14075a: [PGO][PGSO] Instrument the code gen / target passes.: rG2eb30fafa5f9: Revert "[PGO][PGSO] Instrument the code gen / target passes.".
Dec 6 2019, 12:34 PM
yamauchi committed rG2eb30fafa5f9: Revert "[PGO][PGSO] Instrument the code gen / target passes." (authored by yamauchi).
Revert "[PGO][PGSO] Instrument the code gen / target passes."
Dec 6 2019, 12:34 PM
yamauchi added a comment to D71072: [PGO][PGSO] Instrument the code gen / target passes..

Reverted.

Dec 6 2019, 12:34 PM · Restricted Project
yamauchi added a comment to D71072: [PGO][PGSO] Instrument the code gen / target passes..

Working on reverting it.

Dec 6 2019, 12:24 PM · Restricted Project
yamauchi committed rG9a0b5e14075a: [PGO][PGSO] Instrument the code gen / target passes. (authored by yamauchi).
[PGO][PGSO] Instrument the code gen / target passes.
Dec 6 2019, 10:51 AM
yamauchi closed D71072: [PGO][PGSO] Instrument the code gen / target passes..
Dec 6 2019, 10:51 AM · Restricted Project
yamauchi added inline comments to D71072: [PGO][PGSO] Instrument the code gen / target passes..
Dec 6 2019, 9:53 AM · Restricted Project

Dec 5 2019

yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Split the code gen pass instrumentation into D71072.

Dec 5 2019, 9:55 AM · Restricted Project
yamauchi created D71072: [PGO][PGSO] Instrument the code gen / target passes..
Dec 5 2019, 9:55 AM · Restricted Project
yamauchi updated the summary of D67120: [PGO] Profile guided code size optimization (continued)..
Dec 5 2019, 9:37 AM · Restricted Project
yamauchi added a child revision for D70988: [PGO][PGSO] Distinguish queries from unit tests and explicitly enable for the existing IR passes only. NFC.: D67120: [PGO] Profile guided code size optimization (continued)..
Dec 5 2019, 9:36 AM · Restricted Project
yamauchi updated the diff for D67120: [PGO] Profile guided code size optimization (continued)..

Rebase past D70988.

Dec 5 2019, 9:36 AM · Restricted Project

Dec 4 2019

yamauchi committed rG62d429972e50: [PGO][PGSO] Distinguish queries from unit tests and explicitly enable for the… (authored by yamauchi).
[PGO][PGSO] Distinguish queries from unit tests and explicitly enable for the…
Dec 4 2019, 9:42 AM
yamauchi closed D70988: [PGO][PGSO] Distinguish queries from unit tests and explicitly enable for the existing IR passes only. NFC..
Dec 4 2019, 9:42 AM · Restricted Project
yamauchi updated the diff for D70988: [PGO][PGSO] Distinguish queries from unit tests and explicitly enable for the existing IR passes only. NFC..

Rebase.

Dec 4 2019, 9:41 AM · Restricted Project

Dec 3 2019

yamauchi updated the summary of D67120: [PGO] Profile guided code size optimization (continued)..
Dec 3 2019, 3:23 PM · Restricted Project
yamauchi added a child revision for D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize.: D67120: [PGO] Profile guided code size optimization (continued)..
Dec 3 2019, 3:23 PM · Restricted Project
yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Split one more prep step into https://reviews.llvm.org/D70988

Dec 3 2019, 3:14 PM · Restricted Project
yamauchi created D70988: [PGO][PGSO] Distinguish queries from unit tests and explicitly enable for the existing IR passes only. NFC..
Dec 3 2019, 3:14 PM · Restricted Project
yamauchi updated the diff for D67120: [PGO] Profile guided code size optimization (continued)..

Rebased past D67120.

Dec 3 2019, 1:49 PM · Restricted Project
yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Committed D70510.

Dec 3 2019, 1:49 PM · Restricted Project

Dec 2 2019

yamauchi committed rG8cdfdfeee6da: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize. (authored by yamauchi).
[PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize.
Dec 2 2019, 1:58 PM
yamauchi closed D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize..
Dec 2 2019, 1:58 PM · Restricted Project
yamauchi updated the diff for D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize..

Rebase.

Dec 2 2019, 1:48 PM · Restricted Project

Nov 22 2019

yamauchi updated the summary of D67120: [PGO] Profile guided code size optimization (continued)..
Nov 22 2019, 10:52 AM · Restricted Project
yamauchi added a child revision for D70095: [PGO][PGSO] DAG.shouldOptForSize part.: D67120: [PGO] Profile guided code size optimization (continued)..
Nov 22 2019, 10:52 AM · Restricted Project
yamauchi updated the diff for D67120: [PGO] Profile guided code size optimization (continued)..

Rebased past D70095. PTAL.

Nov 22 2019, 10:52 AM · Restricted Project
yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Committed https://reviews.llvm.org/D70567

Nov 22 2019, 10:34 AM · Restricted Project
yamauchi committed rG70a3c9f55f84: [WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize. (authored by yamauchi).
[WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize.
Nov 22 2019, 9:03 AM
yamauchi closed D70567: [WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize..
Nov 22 2019, 9:03 AM · Restricted Project

Nov 21 2019

yamauchi added a comment to D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize..

For example, we could retain the existing behavior (return true only for cold code and the existing call sites of shouldFuncOptimizeForSize) while adding new callers of shouldOptimizeForSize by changing shouldOptimizeForSizeImpl to always false for the "QueryType == PGSOQueryType::Other" case. An alternative would be to combine addition of new callers and behavior changes.

Nov 21 2019, 2:48 PM · Restricted Project
yamauchi added a comment to D70567: [WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize..

Can someone suggest reviewers?

Nov 21 2019, 2:30 PM · Restricted Project
yamauchi updated subscribers of D70567: [WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize..
Nov 21 2019, 2:30 PM · Restricted Project
yamauchi committed rG52e377497ddc: [PGO][PGSO] DAG.shouldOptForSize part. (authored by yamauchi).
[PGO][PGSO] DAG.shouldOptForSize part.
Nov 21 2019, 2:21 PM
yamauchi closed D70095: [PGO][PGSO] DAG.shouldOptForSize part..
Nov 21 2019, 2:21 PM · Restricted Project
yamauchi updated the diff for D70095: [PGO][PGSO] DAG.shouldOptForSize part..

Rebased.

Nov 21 2019, 2:12 PM · Restricted Project
yamauchi created D70567: [WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize..
Nov 21 2019, 1:53 PM · Restricted Project
yamauchi added a comment to D70095: [PGO][PGSO] DAG.shouldOptForSize part..

WebAssembly change: https://reviews.llvm.org/D70567

Nov 21 2019, 1:53 PM · Restricted Project
yamauchi updated the diff for D70095: [PGO][PGSO] DAG.shouldOptForSize part..

Split the WebAssembly change.

Nov 21 2019, 1:17 PM · Restricted Project
yamauchi added a comment to D70095: [PGO][PGSO] DAG.shouldOptForSize part..

Thanks, I'll try the option of splitting out the WebAssembly change.

Nov 21 2019, 1:17 PM · Restricted Project
yamauchi added a comment to D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize..

Can this be derived statically from the FuncT or BlockT?

Nov 21 2019, 12:58 PM · Restricted Project
yamauchi updated the diff for D70095: [PGO][PGSO] DAG.shouldOptForSize part..

Address comments.

Nov 21 2019, 11:00 AM · Restricted Project
yamauchi added a comment to D70095: [PGO][PGSO] DAG.shouldOptForSize part..

Does WebAssembly still need updating ?

Nov 21 2019, 11:00 AM · Restricted Project

Nov 20 2019

yamauchi added inline comments to D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration..
Nov 20 2019, 3:20 PM · Restricted Project
yamauchi updated the diff for D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration..

Moved tryPromoteCall to CallPromotionUtils.h/cpp.

Nov 20 2019, 3:20 PM · Restricted Project
yamauchi retitled D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize. from [PGO][PGSO] Add a query type parameter to shouldOptimizeForSize. to [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize..
Nov 20 2019, 2:07 PM · Restricted Project
yamauchi updated the diff for D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize..

Updated.

Nov 20 2019, 2:05 PM · Restricted Project
yamauchi created D70510: [PGO][PGSO] Add an optional query type parameter to shouldOptimizeForSize..
Nov 20 2019, 1:58 PM · Restricted Project

Nov 19 2019

yamauchi added inline comments to D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration..
Nov 19 2019, 3:37 PM · Restricted Project

Nov 18 2019

yamauchi added a comment to D70147: Repeat DevirtSCCRepeatedPass if new indirect calls are found..

As I understand, that code around line 1323 of InlineCost.cpp would handle a simple case where a caller is passing a (constant) function pointer as a call argument and the callee simply calls it (constant propagation). But it wouldn't handle a (more complex) virtual call (vtable lookup though memory) on a stack allocated (in the caller) object passed to a callee, and would not work for this particular missed inlining case, at least, as is.

Nov 18 2019, 9:38 AM · Restricted Project

Nov 15 2019

yamauchi added a comment to D70147: Repeat DevirtSCCRepeatedPass if new indirect calls are found..

Now it would repeat DevirtSCCRepeatedPass if new indirect calls appear after inlining.

Nov 15 2019, 1:39 PM · Restricted Project
yamauchi retitled D70147: Repeat DevirtSCCRepeatedPass if new indirect calls are found. from Repeat DevirtSCCRepeatedPass if any inlining happens. to Repeat DevirtSCCRepeatedPass if new indirect calls are found..
Nov 15 2019, 1:39 PM · Restricted Project
yamauchi updated the diff for D70147: Repeat DevirtSCCRepeatedPass if new indirect calls are found..

Updated.

Nov 15 2019, 1:31 PM · Restricted Project
yamauchi added a comment to D70147: Repeat DevirtSCCRepeatedPass if new indirect calls are found..

The way this patch currently is, the compile time impact in Clang's self build is ~5.3%.

Nov 15 2019, 10:23 AM · Restricted Project
yamauchi added inline comments to D70095: [PGO][PGSO] DAG.shouldOptForSize part..
Nov 15 2019, 9:39 AM · Restricted Project
yamauchi updated the diff for D70095: [PGO][PGSO] DAG.shouldOptForSize part..

Address comment.

Nov 15 2019, 9:38 AM · Restricted Project

Nov 14 2019

yamauchi updated the diff for D70095: [PGO][PGSO] DAG.shouldOptForSize part..

Cover non-x86 targets (which happens to affect AArch64 files only). PTAL.

Nov 14 2019, 11:01 AM · Restricted Project

Nov 13 2019

yamauchi added a comment to D67120: [PGO] Profile guided code size optimization (continued)..

Committed https://reviews.llvm.org/D70207

Nov 13 2019, 2:14 PM · Restricted Project
yamauchi committed rG3f0969daf9d0: [PGO][PGSO] Temporarily disable the large working set size behavior. (authored by yamauchi).
[PGO][PGSO] Temporarily disable the large working set size behavior.
Nov 13 2019, 2:02 PM
yamauchi closed D70207: [PGO][PGSO] Temporarily disable the large working set size behavior..
Nov 13 2019, 2:01 PM · Restricted Project
yamauchi created D70207: [PGO][PGSO] Temporarily disable the large working set size behavior..
Nov 13 2019, 1:56 PM · Restricted Project

Nov 12 2019

yamauchi added a comment to D70147: Repeat DevirtSCCRepeatedPass if new indirect calls are found..

This is an alternative approach to https://reviews.llvm.org/D69591

Nov 12 2019, 2:59 PM · Restricted Project