Page MenuHomePhabricator

yamauchi (Hiroshi Yamauchi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 5:32 PM (168 w, 3 d)

Recent Activity

Mon, Sep 14

yamauchi added a comment to D86890: [compiler-rt] Remove copy of InstrProfData.inc.

I'm not familiar with the history of this file well, but I had the same impression: it'd be nice if there's a single copy but since compiler-rt is set up to build without depending on llvm/, it's the way it is.

Mon, Sep 14, 9:13 AM · Restricted Project, Restricted Project

Wed, Sep 9

yamauchi committed rG0ab6a1569806: [X86] Add support for using fast short rep mov for memcpy lowering. (authored by yamauchi).
[X86] Add support for using fast short rep mov for memcpy lowering.
Wed, Sep 9, 12:47 PM
yamauchi closed D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Wed, Sep 9, 12:47 PM · Restricted Project
yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Rebase.

Wed, Sep 9, 12:44 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Wed, Sep 9, 12:26 PM · Restricted Project
yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Address comment.

Wed, Sep 9, 12:26 PM · Restricted Project
yamauchi added a comment to D87337: [PGO] De-Optimizing cold functions based on PGO info (PATCH 1/2).

As per https://llvm.org/docs/LangRef.html, deopt term appears to be already coined.

Wed, Sep 9, 8:57 AM · Restricted Project
yamauchi added a comment to rG8d09f20798ac: [AssumeBundles] Use operand bundles to encode alignment assumptions.

I think this was reverted by https://reviews.llvm.org/rG7bfaa40086359ed7e41c862ab0a65e0bb1be0aeb

Wed, Sep 9, 8:22 AM

Wed, Sep 2

yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Address comments.

Wed, Sep 2, 2:23 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Wed, Sep 2, 2:23 PM · Restricted Project
yamauchi updated the diff for D86883: [X86] Add support for using fast short rep mov for memcpy lowering..

Update to remove the getZExtOrTrunc.

Wed, Sep 2, 12:51 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Wed, Sep 2, 12:51 PM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Wed, Sep 2, 10:41 AM · Restricted Project
yamauchi added inline comments to D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Wed, Sep 2, 9:49 AM · Restricted Project

Mon, Aug 31

yamauchi requested review of D86883: [X86] Add support for using fast short rep mov for memcpy lowering..
Mon, Aug 31, 10:31 AM · Restricted Project

Aug 19 2020

yamauchi committed rG28ccc52c4045: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer. (authored by yamauchi).
[X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer.
Aug 19 2020, 1:40 PM
yamauchi closed D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 1:40 PM · Restricted Project
yamauchi added inline comments to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 1:18 PM · Restricted Project
yamauchi committed rGab401a8c8a9c: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts. (authored by yamauchi).
[PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts.
Aug 19 2020, 12:34 PM
yamauchi closed D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..
Aug 19 2020, 12:34 PM · Restricted Project
yamauchi added inline comments to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 12:25 PM · Restricted Project
yamauchi added inline comments to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 19 2020, 12:08 PM · Restricted Project

Aug 17 2020

yamauchi added a comment to D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..

If shouldOptimizeForSize is not available for loop analysis, should the check of be removed unconditionally instead of gated upon whether there is a hint?

Aug 17 2020, 1:00 PM · Restricted Project
yamauchi added a comment to D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..

Is there another patch coming to call hasFSRM()?

Aug 17 2020, 11:53 AM · Restricted Project

Aug 14 2020

yamauchi requested review of D85989: [X86] Add feature for Fast Short REP MOV (FSRM) for Icelake or newer..
Aug 14 2020, 12:38 PM · Restricted Project
yamauchi added a comment to D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..

If shouldOptimizeForSize is not available for loop analysis, should the check of be removed unconditionally instead of gated upon whether there is a hint?

Aug 14 2020, 10:28 AM · Restricted Project

Aug 11 2020

yamauchi requested review of D85784: [PGO][PGSO][LV] Fix loop not vectorized issue under profile guided size opts..
Aug 11 2020, 2:22 PM · Restricted Project

Aug 3 2020

yamauchi committed rG3e89cbf38e76: [PGO] Enable the extended value profile buckets for mem op sizes. (authored by yamauchi).
[PGO] Enable the extended value profile buckets for mem op sizes.
Aug 3 2020, 12:26 PM
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..
Aug 3 2020, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rGf78f509c7586: [PGO] Extend the value profile buckets for mem op sizes. (authored by yamauchi).
[PGO] Extend the value profile buckets for mem op sizes.
Aug 3 2020, 11:04 AM
yamauchi closed D81682: [PGO] Extend the value profile buckets for mem op sizes..
Aug 3 2020, 11:04 AM · Restricted Project, Restricted Project

Jul 31 2020

yamauchi committed rGdcdc77619e1a: [PGO][test] Add test to check memops changes function hash (authored by yamauchi).
[PGO][test] Add test to check memops changes function hash
Jul 31 2020, 9:44 AM
yamauchi closed D84953: [PGO][test] Add test to check memops changes function hash.
Jul 31 2020, 9:43 AM · Restricted Project

Jul 30 2020

yamauchi added a comment to D84953: [PGO][test] Add test to check memops changes function hash.

I think the test should use profile-gen option to compare generated hash of otherwise identical functions (except for memop).

Jul 30 2020, 11:33 AM · Restricted Project
yamauchi updated the diff for D84953: [PGO][test] Add test to check memops changes function hash.

Address comment. Use -pgo-instr-gen.

Jul 30 2020, 11:33 AM · Restricted Project
yamauchi requested review of D84953: [PGO][test] Add test to check memops changes function hash.
Jul 30 2020, 10:22 AM · Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Yup, -pgo-instr-old-cfg-hashing=true to revert back to the old hashing.

Jul 30 2020, 10:20 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rG3d6f53018f84: [PGO] Include the mem ops into the function hash. (authored by yamauchi).
[PGO] Include the mem ops into the function hash.
Jul 30 2020, 9:26 AM

Jul 29 2020

yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Latest update diff:

Jul 29 2020, 5:18 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Use endian::write64le.

Jul 29 2020, 5:16 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Here's the diff in the latest update:

Jul 29 2020, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Fix the endianness issue.

Jul 29 2020, 4:38 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a reverting change for rG120e66b3418b: [PGO] Include the mem ops into the function hash.: rGae7589e1f100: Revert "[PGO] Include the mem ops into the function hash.".
Jul 29 2020, 3:21 PM
yamauchi committed rGae7589e1f100: Revert "[PGO] Include the mem ops into the function hash." (authored by yamauchi).
Revert "[PGO] Include the mem ops into the function hash."
Jul 29 2020, 3:20 PM
yamauchi added a reverting change for D84782: [PGO] Include the mem ops into the function hash.: rGae7589e1f100: Revert "[PGO] Include the mem ops into the function hash.".
Jul 29 2020, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi reopened D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 3:06 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Builtbot failure: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/51984

Jul 29 2020, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rG120e66b3418b: [PGO] Include the mem ops into the function hash. (authored by yamauchi).
[PGO] Include the mem ops into the function hash.
Jul 29 2020, 2:00 PM
yamauchi closed D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 2:00 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Address comments. PTAL.

Jul 29 2020, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Address comment.

Jul 29 2020, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Rebase past D84865.

Jul 29 2020, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi committed rGcd890944ad34: [PGO] Remove insignificant function hash values from some tests. (authored by yamauchi).
[PGO] Remove insignificant function hash values from some tests.
Jul 29 2020, 10:24 AM
yamauchi closed D84865: [PGO] Remove insignificant function hash values from some tests..
Jul 29 2020, 10:24 AM · Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

changes like in llvm/test/Transforms/PGOProfile/PR41279.ll etc can be independently committed.

Jul 29 2020, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi requested review of D84865: [PGO] Remove insignificant function hash values from some tests..
Jul 29 2020, 9:16 AM · Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 29 2020, 9:02 AM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Address comment.

Jul 29 2020, 9:02 AM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2020

yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Can you split out the test changes and commit it separately?

Jul 28 2020, 5:23 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Rebase (converting one more test) and fixing a typo and whitespace.

Jul 28 2020, 5:17 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

On version bump --- looks like FrontPGO has been bumping version for hashing changes while IR PGO had not, so it is ok to leave the version unchanged (current situation is also confusing as the version of IR and FE PGO are mixed).

On the other hand, just in case, we need to introduce a temporary internal option for people to be able to keep on using old profile (with older scheme of hashing) for a while. Basically, under the option, the hashing scheme falls back to the old way.

other than that, looks fine.

Jul 28 2020, 4:43 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Add a flag to back out to the old hashing.

Jul 28 2020, 4:42 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added a comment to D84782: [PGO] Include the mem ops into the function hash..

Many tests can also be enhanced to filter out the hash details if they are not part the main test.

Jul 28 2020, 4:19 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Shift the higher 32 bits by 28 bits and add.

Jul 28 2020, 4:18 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 28 2020, 2:50 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 28 2020, 2:47 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi added inline comments to D84782: [PGO] Include the mem ops into the function hash..
Jul 28 2020, 2:37 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi updated the diff for D84782: [PGO] Include the mem ops into the function hash..

Use JamCRC.

Jul 28 2020, 2:33 PM · Restricted Project, Restricted Project, Restricted Project
yamauchi requested review of D84782: [PGO] Include the mem ops into the function hash..
Jul 28 2020, 11:40 AM · Restricted Project, Restricted Project, Restricted Project

Jul 23 2020

yamauchi accepted D84357: [llvm][NFC] Add comments and common-case API to MachineBlockFrequencyInfo.
Jul 23 2020, 8:23 AM · Restricted Project

Jul 22 2020

yamauchi added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

The re-landing of this patch in 4a539faf74b9b4c25ee3b880e4007564bd5139b0 causes our PGO build of clang to have thousands of

LLVM Profile Warning: Unable to track new values: Running out of static counters.  Consider using option -mllvm -vp-counters-per-site=<n> to allocate more value profile counters at compile time.

Is that expected? Should the cmake set a higher value of -vp-counters-per-site in self-hosted PGO builds?

Jul 22 2020, 4:19 PM · Restricted Project, Restricted Project
yamauchi added inline comments to D84357: [llvm][NFC] Add comments and common-case API to MachineBlockFrequencyInfo.
Jul 22 2020, 3:32 PM · Restricted Project
yamauchi accepted D84358: Temporarily revert D83903 "[PGO] Enable the extended value profile buckets for mem op sizes.".
Jul 22 2020, 1:06 PM · Restricted Project

Jul 21 2020

yamauchi closed D81682: [PGO] Extend the value profile buckets for mem op sizes..

Committed as https://reviews.llvm.org/rG4a539faf74b9

Jul 21 2020, 11:30 AM · Restricted Project, Restricted Project
yamauchi committed rG7bedae7deeb5: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality. (authored by yamauchi).
[PGO][PGSO] Add profile guided size optimization to loop vectorization legality.
Jul 21 2020, 11:17 AM

Jul 20 2020

yamauchi committed rG9f5d8e8a729d: [PGO] Enable the extended value profile buckets for mem op sizes. (authored by yamauchi).
[PGO] Enable the extended value profile buckets for mem op sizes.
Jul 20 2020, 9:18 PM
yamauchi closed D83903: [PGO] Enable the extended value profile buckets for mem op sizes..
Jul 20 2020, 9:17 PM · Restricted Project
yamauchi committed rGe64afefdf88d: [PGO][PGSO] Remove a temporary flag used for gradual rollout. (authored by yamauchi).
[PGO][PGSO] Remove a temporary flag used for gradual rollout.
Jul 20 2020, 9:17 PM
yamauchi closed D84057: [PGO][PGSO] Remove a temporary flag used for gradual rollout..
Jul 20 2020, 9:17 PM · Restricted Project
yamauchi added a comment to D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality..

PTAL. This is the diff of the patches before/after the latest fix.

Jul 20 2020, 9:16 PM · Restricted Project
yamauchi reopened D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality..
Jul 20 2020, 9:16 PM · Restricted Project
yamauchi updated the diff for D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality..

Update after a fix for https://crbug.com/1106813

Jul 20 2020, 9:16 PM · Restricted Project
yamauchi added a comment to D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality..

Reproduced https://crbug.com/1106813.

Jul 20 2020, 9:16 PM · Restricted Project

Jul 17 2020

Herald added a project to D84057: [PGO][PGSO] Remove a temporary flag used for gradual rollout.: Restricted Project.
Jul 17 2020, 11:01 AM · Restricted Project

Jul 15 2020

Herald added a project to D83903: [PGO] Enable the extended value profile buckets for mem op sizes.: Restricted Project.
Jul 15 2020, 1:26 PM · Restricted Project
yamauchi committed rG30c382a7c660: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality. (authored by yamauchi).
[PGO][PGSO] Add profile guided size optimization to loop vectorization legality.
Jul 15 2020, 11:50 AM
yamauchi closed D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality..
Jul 15 2020, 11:50 AM · Restricted Project
yamauchi updated the diff for D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality..

Rebase.

Jul 15 2020, 11:48 AM · Restricted Project
yamauchi committed rG4a539faf74b9: [PGO] Extend the value profile buckets for mem op sizes. (authored by yamauchi).
[PGO] Extend the value profile buckets for mem op sizes.
Jul 15 2020, 10:53 AM
yamauchi committed rGf233b92f92a6: [PGO][PGSO] Add profile guided size optimization to LegalizeDAG. (authored by yamauchi).
[PGO][PGSO] Add profile guided size optimization to LegalizeDAG.
Jul 15 2020, 10:23 AM
yamauchi closed D83333: [PGO][PGSO] Add profile guided size optimization to LegalizeDAG..
Jul 15 2020, 10:23 AM · Restricted Project
yamauchi added inline comments to D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality..
Jul 15 2020, 8:52 AM · Restricted Project

Jul 13 2020

yamauchi committed rGfb558ccae743: [PGO][PGSO] Add profile guided size optimization to X86ISelDAGToDAG. (authored by yamauchi).
[PGO][PGSO] Add profile guided size optimization to X86ISelDAGToDAG.
Jul 13 2020, 10:28 AM
yamauchi closed D83331: [PGO][PGSO] Add profile guided size optimization to X86ISelDAGToDAG..
Jul 13 2020, 10:28 AM · Restricted Project
yamauchi committed rG153a0b8906d5: [PGO][PGSO] Add profile guided size optimization to the X86 LEA fixup. (authored by yamauchi).
[PGO][PGSO] Add profile guided size optimization to the X86 LEA fixup.
Jul 13 2020, 10:07 AM
yamauchi closed D83330: [PGO][PGSO] Add profile guided size optimization to the X86 LEA fixup..
Jul 13 2020, 10:07 AM · Restricted Project

Jul 10 2020

yamauchi added a comment to D83331: [PGO][PGSO] Add profile guided size optimization to X86ISelDAGToDAG..

More comments?

Jul 10 2020, 9:55 AM · Restricted Project