Page MenuHomePhabricator

xiongji90 (xiongji90)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2018, 7:20 PM (143 w, 4 d)

Recent Activity

Today

xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Mon, Aug 2, 1:39 AM · Restricted Project, Restricted Project

Yesterday

xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.

Chang default value of LIBUNWIND_ENABLE_CET to OFF in libunwind CMakeFile.
Since the LLVM_BUILD_CET_ENABLE has not been added to LLVM building system, we can set LIBUNWIND_ENABLE_CET default value to OFF currently.
When LLVM_BUILD_CET_ENABLE is supported in LLVM building, we can set the default value to LLVM_ENABLE_CET.

Sun, Aug 1, 11:16 PM · Restricted Project, Restricted Project
xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Sun, Aug 1, 8:42 PM · Restricted Project, Restricted Project

Fri, Jul 30

xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Fri, Jul 30, 1:07 AM · Restricted Project, Restricted Project
xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
  1. Report error for LIBUNWIND_ENABLE_CET + MSVC
  2. Turn unw_cet_get_registers to an internal function libunwind_cet_get_registers
  3. Some tiny code format change.
Fri, Jul 30, 1:05 AM · Restricted Project, Restricted Project

Thu, Jul 29

xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Thu, Jul 29, 8:04 PM · Restricted Project, Restricted Project
xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Thu, Jul 29, 12:47 AM · Restricted Project, Restricted Project
xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Thu, Jul 29, 12:01 AM · Restricted Project, Restricted Project

Wed, Jul 28

xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
  1. Rename LIBUNWIND_BUILD_CET_ENABLE to LIBUNWIND_ENABLE_CET in libunwind CMakeFile and remove unnecessary LIBUNWIND_CET_ON local variable
  2. Get rid of using value of _LIBUNWIND_CET_ENABLED and using "_LIBUNWIND_TARGET_I386" and "_LIBUNWIND_TARGET_X86_64" to select inline asm.
Wed, Jul 28, 11:51 PM · Restricted Project, Restricted Project

Tue, Jul 27

xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Tue, Jul 27, 8:56 PM · Restricted Project, Restricted Project
xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Tue, Jul 27, 1:53 AM · Restricted Project, Restricted Project
xiongji90 added a reviewer for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment: rprichard.
Tue, Jul 27, 1:44 AM · Restricted Project, Restricted Project
xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Tue, Jul 27, 1:38 AM · Restricted Project, Restricted Project
xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Tue, Jul 27, 12:51 AM · Restricted Project, Restricted Project

Wed, Jul 21

xiongji90 updated the diff for D105603: [X86][CET] Support to build LLVM toolchain with CET enabled..
Wed, Jul 21, 8:45 PM · Restricted Project
xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.

Add a build option "LIBUNWIND_BUILD_CET_ENABLE" to enable CET for libunwind.

Wed, Jul 21, 12:32 AM · Restricted Project, Restricted Project

Tue, Jul 20

xiongji90 added inline comments to D105603: [X86][CET] Support to build LLVM toolchain with CET enabled..
Tue, Jul 20, 12:23 AM · Restricted Project

Mon, Jul 19

xiongji90 added a reviewer for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment: manojgupta.

Hi, @manojgupta
This patch aims to fix https://bugs.llvm.org/show_bug.cgi?id=45946
Could you help me review it?
Thanks very much!

Mon, Jul 19, 11:44 PM · Restricted Project, Restricted Project

Thu, Jul 15

xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.

Use scratch register %rcx for indirect jumping to landing pad, there are 2 reasons for this:

  1. it is safer since red zone may be unavailable
  2. align with 32bit mode
Thu, Jul 15, 11:17 PM · Restricted Project, Restricted Project
xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Thu, Jul 15, 1:02 AM · Restricted Project, Restricted Project
xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Thu, Jul 15, 1:01 AM · Restricted Project, Restricted Project
xiongji90 updated the diff for D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.

This update fixes some format issue and updates the way to jump to landing pad in 32bit node.
Previously, we used following code to jump to landing pad:
"
add $4, %esp
jmp *-4(%esp)
"
If interrupt comes in between these 2 instructions, interrupt handler may change the contents of "-4(%esp)" since there is no red zone in 32bit mode. To fix this issue, we align with gcc unwind to use %ecx to store landing pad address and jmp to it:
"
pop %ecx
jmp *%ecx
"

Thu, Jul 15, 12:57 AM · Restricted Project, Restricted Project

Wed, Jul 14

xiongji90 added inline comments to D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Wed, Jul 14, 7:14 AM · Restricted Project, Restricted Project
xiongji90 requested review of D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.
Wed, Jul 14, 1:47 AM · Restricted Project, Restricted Project

Wed, Jul 7

xiongji90 added a reviewer for D105603: [X86][CET] Support to build LLVM toolchain with CET enabled.: hjl.tools.
Wed, Jul 7, 7:17 PM · Restricted Project
xiongji90 requested review of D105603: [X86][CET] Support to build LLVM toolchain with CET enabled..
Wed, Jul 7, 7:11 PM · Restricted Project