Page MenuHomePhabricator

xgsa (Anton)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 3 2017, 2:52 PM (88 w, 6 d)

Recent Activity

Jan 7 2018

xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Fixed showing the check in -list-checks.

Jan 7 2018, 11:24 PM · Restricted Project

Jan 6 2018

xgsa added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Jan 6 2018, 3:48 AM · Restricted Project

Jan 2 2018

xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Rename the check nolint-usage => readability-nolint-usage for consistency.
Update diagnostics message according to the review comments.

Jan 2 2018, 10:17 AM · Restricted Project
xgsa added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Jan 2 2018, 2:20 AM · Restricted Project

Dec 25 2017

xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Review comments applied.

Dec 25 2017, 6:47 AM · Restricted Project
xgsa added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Dec 25 2017, 6:46 AM · Restricted Project

Dec 23 2017

xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

The full diff (but not only the incremental one) was uploaded. Please, skip previous revision. Sorry.

Dec 23 2017, 3:17 PM · Restricted Project
xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Review comments applied.

Dec 23 2017, 3:11 PM · Restricted Project
xgsa added a comment to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Aaron, thank you for your review and sorry for the coding convention mistakes -- I still cannot get used to the llvm coding convention, because it quite differs from the one I have been using in my projects.

Dec 23 2017, 3:01 PM · Restricted Project

Dec 21 2017

xgsa added a comment to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Ping.

Dec 21 2017, 11:20 PM · Restricted Project

Dec 17 2017

xgsa added a comment to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

I'm missing some documentation to understand the corner cases. How does this check behave with suppressed warnings for checks which ain't currently checked. (Using -no-... on a code base or suppressing the warnings via the pragmas)

Dec 17 2017, 1:58 AM · Restricted Project
xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Review comments applied.

Dec 17 2017, 12:21 AM · Restricted Project
xgsa added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Dec 17 2017, 12:12 AM · Restricted Project
xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Review comments were applied.

Dec 17 2017, 12:00 AM · Restricted Project

Dec 16 2017

xgsa added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Dec 16 2017, 11:58 PM · Restricted Project
xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

A few minor coding style fixes.

Dec 16 2017, 2:55 PM · Restricted Project
xgsa created D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Dec 16 2017, 2:38 PM · Restricted Project

Dec 14 2017

xgsa added a comment to D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.

Philosophically, mangled names and DWARF information serve different purposes, and I don't think you will find one true solution where both of them can yield the same name that everyone will be happy with. Mangled names exist to provide unique and reproducible identifiers for the "same" entity across compilation units. They are carefully specified (for example) to allow a linker to associate a reference in one object file to a definition in a different object file, and be guaranteed that the association is correct. A demangled name is a necessarily context-free translation of the mangled name into something that has a closer relationship to how a human would think of or write the name of the thing, but isn't necessarily the only way to write the name of the thing.

DWARF names are (deliberately not carefully specified) strings that ought to bear some relationship to how source code would name the thing, but you probably don't want to attach semantic significance to those names. This is rather emphatically true for names containing template parameters. Typedefs (and their recent offspring, 'using' aliases) are your sworn enemy here. Enums, as you have found, are also a problem.

Basically, the type of an entity does not have a unique name, and trying to coerce different representations of the type into having the same unique name is a losing battle.

Dec 14 2017, 2:21 AM · debug-info, Restricted Project

Dec 13 2017

xgsa added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

FWIW, I think we should do something about unknown check names in NOLINT comments, but that can be done as a follow-up patch. If we're ignoring the comment, we might want to diagnose that fact so users have an idea what's going on.

IIUC, cpplint can output a diagnostic about unknown categories inside NOLINT and about NOLINT directives that happen on lines where no warning is emitted. Both would be useful in clang-tidy, IMO.

Dec 13 2017, 11:56 PM · Restricted Project
xgsa updated the summary of D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.
Dec 13 2017, 2:23 PM · debug-info, Restricted Project
xgsa updated the diff for D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.

One more case was handled, review comments were applied, but no tests though, because I still not sure if the approach I have chosen is correct.

Dec 13 2017, 2:14 PM · debug-info, Restricted Project

Dec 12 2017

xgsa added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

@aaron.ballman, sorry for my insistence, but it seems all the comments are fixed and the patch is ready for commit or am I missing something? Could you please commit it on my behalf, as I don't have rights to do that?

Dec 12 2017, 11:37 PM · Restricted Project

Dec 8 2017

xgsa added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

How are unknown check names handled? More specifically: will the // NOLINT(runtime/explicit) comment disable all clang-tidy checks or none?

Dec 8 2017, 10:03 AM · Restricted Project

Dec 7 2017

xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

Documentation update

Dec 7 2017, 3:04 PM · Restricted Project
xgsa added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

There are still some outstanding concerns around the documentation wording, but once those are resolved it should be ready to commit. If you don't have commit access, I can commit on your behalf -- just let me know.

Dec 7 2017, 3:01 PM · Restricted Project

Dec 6 2017

xgsa added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

So can this patch be submitted? Should I do something to make it happen?

Dec 6 2017, 11:25 PM · Restricted Project

Dec 5 2017

xgsa added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

BTW, how will this feature interact with cpplint.py's way of handling specific NOLINT directives that use different lint rule names, which sometimes refer to the same rule (e.g. // NOLINT(runtime/explicit) suppresses the runtime/explicit cpplint rule that enforces the same style rule as the google-runtime-explicit check)?

Dec 5 2017, 8:36 AM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

Updated documentation

Dec 5 2017, 6:44 AM · Restricted Project
xgsa added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 5 2017, 6:42 AM · Restricted Project

Dec 4 2017

xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 4 2017, 6:24 AM · Restricted Project
xgsa added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 4 2017, 6:18 AM · Restricted Project

Dec 3 2017

xgsa added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 3 2017, 12:42 PM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

A typo in documentation was fixed.

Dec 3 2017, 9:07 AM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

Updated documentation and comments in code.

Dec 3 2017, 9:03 AM · Restricted Project
xgsa added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 3 2017, 9:02 AM · Restricted Project

Dec 2 2017

xgsa added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 2 2017, 6:37 AM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

Release note item was reworded

Dec 2 2017, 1:01 AM · Restricted Project

Dec 1 2017

xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

Minor change: update default value of SmallVector of check names.

Dec 1 2017, 1:39 PM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

An item to release notes was added.

Dec 1 2017, 12:15 PM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 1 2017, 7:22 AM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

A few additional test cases were added.

Dec 1 2017, 3:34 AM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

Add comments to code as it was recommended.

Dec 1 2017, 1:52 AM · Restricted Project
xgsa added inline comments to D40671: [clang-tidy] Support specific checks for NOLINT directive.
Dec 1 2017, 1:37 AM · Restricted Project
xgsa retitled D40671: [clang-tidy] Support specific checks for NOLINT directive from [clang-tidy] Support specific categories for NOLINT directive to [clang-tidy] Support specific checks for NOLINT directive.
Dec 1 2017, 12:41 AM · Restricted Project
xgsa added a comment to D40671: [clang-tidy] Support specific checks for NOLINT directive.

Could you please explain what category means? Could i disable all of cppcoreguidelines with something like // NOLINT (cppcoreguidelines-*)?

Dec 1 2017, 12:40 AM · Restricted Project

Nov 30 2017

xgsa retitled D40671: [clang-tidy] Support specific checks for NOLINT directive from Support specific categories for NOLINT directive to [clang-tidy] Support specific categories for NOLINT directive.
Nov 30 2017, 10:43 PM · Restricted Project
xgsa updated the diff for D40671: [clang-tidy] Support specific checks for NOLINT directive.

Update the diff to contain the full context

Nov 30 2017, 1:57 PM · Restricted Project
xgsa created D40671: [clang-tidy] Support specific checks for NOLINT directive.
Nov 30 2017, 1:25 PM · Restricted Project

Nov 12 2017

xgsa added a comment to D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.

For clarification: what is the "symbols table" you are referring to in the description?

Nov 12 2017, 12:53 PM · debug-info, Restricted Project

Nov 4 2017

xgsa added inline comments to D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.
Nov 4 2017, 3:10 PM · debug-info, Restricted Project
xgsa created D39633: Remove \brief from doxygen comments in PrettyPrinter.h.
Nov 4 2017, 3:08 PM · Restricted Project
xgsa added inline comments to D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.
Nov 4 2017, 2:15 AM · debug-info, Restricted Project
xgsa added a comment to D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.

Can you add a testcase?

Nov 4 2017, 2:04 AM · debug-info, Restricted Project

Nov 3 2017

xgsa added a reviewer for D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations: echristo.
Nov 3 2017, 4:19 PM · debug-info, Restricted Project
xgsa created D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations.
Nov 3 2017, 4:16 PM · debug-info, Restricted Project