Page MenuHomePhabricator

xerofoify (Nicholas Krause)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 4:43 PM (194 w, 1 d)

Recent Activity

Jun 7 2019

xerofoify added a comment to D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.

Yes as I don't have commit privileges.

Jun 7 2019, 1:10 PM · Restricted Project

Jun 5 2019

xerofoify updated the diff for D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.
Jun 5 2019, 6:34 AM · Restricted Project

Jun 3 2019

xerofoify updated the diff for D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.
Jun 3 2019, 11:55 AM · Restricted Project
xerofoify added a comment to D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.

Sorry about that I thought the patch name needed to change just not here. That's fixed and the error message is back to normal with the added condition and test case.

The error message I'm seeing still is wrong. I don't think you've updated the diff. Please do so.

Jun 3 2019, 11:50 AM · Restricted Project

May 28 2019

xerofoify added a comment to D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.

Sorry about that I thought the patch name needed to change just not here. That's fixed and the error message is back to normal with the added condition and test case.

May 28 2019, 10:49 AM · Restricted Project
xerofoify retitled D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object from Fix Bugzilla ID 41862 to support checking addresses of disassembled object to llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.
May 28 2019, 10:41 AM · Restricted Project

May 24 2019

xerofoify updated the diff for D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.

Sorry about the issues. I looked through the comments and it seems that the test cases below are correct and one needed to just be added by copying and pasting the other one but checking for the same addresses with a newer error message to check against. Hopefully this is correct now and thanks for the patience.

May 24 2019, 5:39 PM · Restricted Project

May 23 2019

xerofoify updated the diff for D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.

This is the updated patch. I wasn't sure if the test cases are correct, not sure if the syntax has issues. Otherwise this should be fixed now and thanks for the comments.

May 23 2019, 9:28 PM · Restricted Project

May 17 2019

xerofoify added a comment to D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.

Yes you did and gnu generally errors here. My point was is there is a third case so the if should really be:
if (StartAddress >= StopAddress)

error("Start address should be less than stop address");

if (StartAddress < StopAddress)

error("Stop address should be greater than start address");
May 17 2019, 9:23 AM · Restricted Project

May 16 2019

xerofoify added a comment to D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.

It fails after looking at the code again for the gnu binutils so it would be best to keep them compatible IMO. However merging my if statement together is better through so I
keep upload a new patch with the git diff comments as I was just using git format patch before. In addition it seems that there is also the case in binutils of lesser
than stop address so that should be added as well so I guess we really do need another if statement. Let me know if those changes work for you to keep compatibility with
gnu binutils.

May 16 2019, 1:27 PM · Restricted Project

May 15 2019

xerofoify created D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.
May 15 2019, 4:56 PM · Restricted Project