Page MenuHomePhabricator

wnewton (Will Newton)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 28 2014, 3:31 AM (242 w, 1 d)

Recent Activity

Feb 17 2015

wnewton committed rL229487: Fix AArhc64 ELF test failure on Windows.
Fix AArhc64 ELF test failure on Windows
Feb 17 2015, 3:19 AM

Feb 12 2015

wnewton committed rL229072: ELF/AArch64: Add support for checking for ABS32 overflow.
ELF/AArch64: Add support for checking for ABS32 overflow
Feb 12 2015, 10:24 PM

Feb 10 2015

wnewton added inline comments to D7502: [lld][ELF][ARM] Add veneer generation to branch instructions.
Feb 10 2015, 12:25 AM · lld

Feb 9 2015

wnewton accepted D7502: [lld][ELF][ARM] Add veneer generation to branch instructions.
Feb 9 2015, 5:44 PM · lld

Feb 2 2015

wnewton accepted D7223: [lld][ARM] Add relocations to perform function calls.

LGTM

Feb 2 2015, 8:17 AM · lld

Jan 28 2015

wnewton accepted D7225: [lld] Remove PPC ELF target.

LGTM

Jan 28 2015, 6:53 AM · lld
wnewton added inline comments to D7223: [lld][ARM] Add relocations to perform function calls.
Jan 28 2015, 2:33 AM · lld
wnewton added inline comments to D7223: [lld][ARM] Add relocations to perform function calls.
Jan 28 2015, 1:42 AM · lld

Jan 20 2015

wnewton committed rL226572: ELF: Handle sh_addralign being set to zero.
ELF: Handle sh_addralign being set to zero
Jan 20 2015, 8:11 AM
wnewton closed D6827: [lld] ELF: Support detection of relocation errors during processing.
Jan 20 2015, 2:40 AM · lld
wnewton committed rL226557: ELF: Support detection of relocation errors during processing.
ELF: Support detection of relocation errors during processing
Jan 20 2015, 2:39 AM

Jan 14 2015

wnewton accepted D6716: [lld][ELF]: Minimal implementation for ARM static linking.
Jan 14 2015, 1:54 AM · lld

Jan 13 2015

wnewton updated the diff for D6827: [lld] ELF: Support detection of relocation errors during processing.

Switched to using dynamic error rather than adding a new error category.
Fixed buggy usage of Twine.

Jan 13 2015, 9:01 AM · lld

Jan 7 2015

wnewton updated the diff for D6827: [lld] ELF: Support detection of relocation errors during processing.
  1. Split out AArch64 ABS32 overflow checking code to a separate patch
  2. Add a mutex to make sure error output it not interleaved when multi-threaded
Jan 7 2015, 7:57 AM · lld
wnewton closed D6523: ELF: Add a standard method for unknown relocation errors.

This change has been committed.

Jan 7 2015, 7:53 AM · lld

Jan 2 2015

wnewton retitled D6827: [lld] ELF: Support detection of relocation errors during processing from to [lld] ELF: Support detection of relocation errors during processing.
Jan 2 2015, 9:21 AM · lld
wnewton added a comment to D6716: [lld][ELF]: Minimal implementation for ARM static linking.

This looks ok to me.

Jan 2 2015, 9:13 AM · lld

Dec 11 2014

wnewton committed rL224014: ELF/AArch64: Add a test for R_AARCH64_ABS32.
ELF/AArch64: Add a test for R_AARCH64_ABS32
Dec 11 2014, 6:35 AM
wnewton committed rL224013: ELF/AArch64: Add a test for R_AARCH64_ABS64.
ELF/AArch64: Add a test for R_AARCH64_ABS64
Dec 11 2014, 6:35 AM

Dec 5 2014

wnewton added a comment to D6523: ELF: Add a standard method for unknown relocation errors.
In D6523#6, @atanasyan wrote:

Good idea. Did you consider to factor out the unhandledReferenceType method into the separate class? Some sort of Diagnostic. The LinkingContext might have a reference to this class. That allow us to keep all diagnostics stuff together and simplify implementation of feature-rich diagnostics engine in the future.

Dec 5 2014, 4:38 AM · lld

Dec 4 2014

wnewton retitled D6523: ELF: Add a standard method for unknown relocation errors from to ELF: Add a standard method for unknown relocation errors.
Dec 4 2014, 4:17 AM · lld
wnewton accepted D6446: [ELF]: Initial implementation for ARM static linking.

This looks ok to me as an initial revision, although obviously it is missing functionality and test coverage.

Dec 4 2014, 4:13 AM · lld