- User Since
- Nov 8 2020, 9:22 AM (16 w, 4 d)
Jan 20 2021
Thanks for the review. I hope the current comment looks better.
Trim down the comment
Jan 19 2021
I don't have commit access. Would someone please commit for me?
- GIT_AUTHOR_NAME="Anton Rapetov"
Jan 18 2021
Ignore all Constants, not just ConstantData
Add a comment with the reasoning for the early exit
Make findInnerReductionPhi return nullptr on isa<Constant> as suggested
Add a test for that case.
Jan 17 2021
Correct comment explaining the reason to skip ConstantData, as suggested by
@dexonsmith. At the moment isa<ConstantData>, I'm not sure whether using
isa<Constant> whould be better here.