Page MenuHomePhabricator

watsond (Blaise Watson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 8 2017, 4:01 PM (183 w, 1 d)

Recent Activity

Mar 22 2017

watsond added a comment to D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

Following up. Was this checked in? Do I need to do anything further?

Mar 22 2017, 12:46 PM

Mar 2 2017

watsond added a comment to D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

Do you need someone to commit the patch for you?

Mar 2 2017, 1:18 PM

Feb 28 2017

watsond updated the diff for D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

Fixed logic error, added enum test case

Feb 28 2017, 2:53 PM
watsond added a comment to D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

Could you add some tests with enums (like the one in your description)?
This is missing and it's a nice to have.

Feb 28 2017, 2:52 PM

Feb 10 2017

watsond created D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.
Feb 10 2017, 4:58 PM
watsond abandoned D29857: Catch trivially true statements of the form a != 1 || a != 3. Statements like these are likely errors. They are particularly easy to miss when handling enums: enum State { RUNNING, STOPPED, STARTING, ENDING } ... if (state != RUNNING || state !=....

Apologies all. I messed up the formatting. Resubmitting in a second.

Feb 10 2017, 4:53 PM
watsond updated the diff for D29857: Catch trivially true statements of the form a != 1 || a != 3. Statements like these are likely errors. They are particularly easy to miss when handling enums: enum State { RUNNING, STOPPED, STARTING, ENDING } ... if (state != RUNNING || state !=....

Updating D29857: Catch trivially true statements of the form a != 1 || a != 3. Statements like

these are likely errors. They are particularly easy to miss when handling enums:

Feb 10 2017, 4:52 PM
watsond created D29857: Catch trivially true statements of the form a != 1 || a != 3. Statements like these are likely errors. They are particularly easy to miss when handling enums: enum State { RUNNING, STOPPED, STARTING, ENDING } ... if (state != RUNNING || state !=....
Feb 10 2017, 4:51 PM