Page MenuHomePhabricator

w88 (congphat79)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2019, 2:26 PM (31 w, 5 d)

Recent Activity

Nov 24 2019

w88 raised a concern with rG0068c5913999: [libc++] Rename __to_raw_pointer to __to_address..

w88 . tk congphat79 . ad chuyen tien ao tk cgo toi cai

Nov 24 2019, 4:13 PM
w88 accepted rG0068c5913999: [libc++] Rename __to_raw_pointer to __to_address..

Nov 24 2019, 4:11 PM
w88 accepted rG1de788a1f16e: [mips] Split test into MIPS and microMIPS parts. NFC.
Nov 24 2019, 3:09 PM · Restricted Project
w88 added a comment to D70590: [Examples] Add add_llvm_example_library macro and use it for IR example..

I think that rather than adding more wrapping macros, we should fix the structure. We can mark the examples directory from ALL at the add_subdirectory level and only add the subdirectory when examples are enabled. This avoids the need for the new macro. I think that we want to move towards a more standard cmake build rather than a more specialized one.

I think sticking to more standard cmake is great. My Cmake is a bit rusty, are you suggesting to just not add the examples directory (guarding add_subdirectory with LLVM_BUILD_EXAMPLES)?

I think that would change the behavior slightly, because currently IIUC we always add the example targets, we just not build them by default and also update the target directory for installing them and it would be valuable to keep the current behavior.

Nov 24 2019, 2:59 PM · Restricted Project
w88 added reviewers for D70590: [Examples] Add add_llvm_example_library macro and use it for IR example.: 0x64616E69656C, 01alchemist.
Nov 24 2019, 2:43 PM · Restricted Project
w88 raised a concern with rG1de788a1f16e: [mips] Split test into MIPS and microMIPS parts. NFC.
Nov 24 2019, 2:32 PM · Restricted Project