Page MenuHomePhabricator

vrnithinkumar (Nithin VR)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 6:52 AM (76 w, 6 d)

Recent Activity

Oct 9 2020

vrnithinkumar committed rG0b4fe8086f03: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner… (authored by vrnithinkumar).
[Analyzer] Fix for dereferece of smart pointer after branching on unknown inner…
Oct 9 2020, 4:43 AM
vrnithinkumar closed D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.
Oct 9 2020, 4:43 AM · Restricted Project

Oct 7 2020

vrnithinkumar added inline comments to D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.
Oct 7 2020, 2:01 PM · Restricted Project
vrnithinkumar updated the diff for D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.
  • Addressing review comment
Oct 7 2020, 1:59 PM · Restricted Project

Sep 28 2020

vrnithinkumar added a comment to D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.

Congrats on your GSoC! Unless I missed it, it seems like you haven't posted your final report on cfe-dev, even though its an amazing looking document with a lot of examples and explanations. I think it would be great to spread the message, its a work to be proud of!

Sep 28 2020, 4:12 PM · Restricted Project

Sep 2 2020

vrnithinkumar updated the summary of D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.
Sep 2 2020, 10:00 AM · Restricted Project
vrnithinkumar requested review of D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.
Sep 2 2020, 9:56 AM · Restricted Project

Aug 31 2020

vrnithinkumar committed rGbc3d4d9ed783: [analyzer] Add bool operator modeling for unque_ptr (authored by vrnithinkumar).
[analyzer] Add bool operator modeling for unque_ptr
Aug 31 2020, 10:42 AM
vrnithinkumar closed D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 31 2020, 10:41 AM · Restricted Project
vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 31 2020, 10:02 AM · Restricted Project
vrnithinkumar updated the diff for D86027: [analyzer] Add bool operator modeling for unque_ptr.
  • Fixing minor spacing issue
Aug 31 2020, 9:59 AM · Restricted Project
vrnithinkumar updated the diff for D86027: [analyzer] Add bool operator modeling for unque_ptr.
  • Addressing review comments
Aug 31 2020, 9:55 AM · Restricted Project
vrnithinkumar committed rG1b743a9efa08: [analyzer] Add modeling for unique_ptr move constructor (authored by vrnithinkumar).
[analyzer] Add modeling for unique_ptr move constructor
Aug 31 2020, 5:36 AM
vrnithinkumar closed D86373: [analyzer] Add modeling for unique_ptr move constructor.
Aug 31 2020, 5:36 AM · Restricted Project

Aug 26 2020

vrnithinkumar added a comment to D86373: [analyzer] Add modeling for unique_ptr move constructor.
In D86373#2231605, @NoQ wrote:

This is easier than D86293 because there's no old value in the freshly constructed smart pointer, right? I suspect that you can still re-use a lot of the implementation with D86293, at least partially.

Aug 26 2020, 1:33 PM · Restricted Project
vrnithinkumar added inline comments to D86373: [analyzer] Add modeling for unique_ptr move constructor.
Aug 26 2020, 1:32 PM · Restricted Project
vrnithinkumar added inline comments to D86373: [analyzer] Add modeling for unique_ptr move constructor.
Aug 26 2020, 1:31 PM · Restricted Project
vrnithinkumar updated the diff for D86373: [analyzer] Add modeling for unique_ptr move constructor.
  • Refactoring to reuse common duplicated code
Aug 26 2020, 1:28 PM · Restricted Project
vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 26 2020, 11:14 AM · Restricted Project
vrnithinkumar updated the diff for D86027: [analyzer] Add bool operator modeling for unque_ptr.
  • Removing unnecessary notetags.
Aug 26 2020, 11:11 AM · Restricted Project
vrnithinkumar committed rG20676cab1168: [analyzer] Add modeling of assignment operator in smart ptr (authored by vrnithinkumar).
[analyzer] Add modeling of assignment operator in smart ptr
Aug 26 2020, 2:23 AM
vrnithinkumar closed D86293: [analyzer] Add modeling of Eq operator in smart ptr.
Aug 26 2020, 2:23 AM · Restricted Project

Aug 25 2020

vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 25 2020, 5:47 AM · Restricted Project
vrnithinkumar updated the diff for D86027: [analyzer] Add bool operator modeling for unque_ptr.
  • Making the note tags prunable
Aug 25 2020, 5:43 AM · Restricted Project
vrnithinkumar added inline comments to D86293: [analyzer] Add modeling of Eq operator in smart ptr.
Aug 25 2020, 3:34 AM · Restricted Project
vrnithinkumar updated the diff for D86293: [analyzer] Add modeling of Eq operator in smart ptr.
  • Addressing review comments
Aug 25 2020, 3:34 AM · Restricted Project

Aug 24 2020

vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 24 2020, 3:25 PM · Restricted Project
vrnithinkumar updated the diff for D86027: [analyzer] Add bool operator modeling for unque_ptr.
  • Adding checkLiveSymbols and review comments changes
Aug 24 2020, 3:25 PM · Restricted Project

Aug 23 2020

vrnithinkumar committed rG55208f5a2126: [analyzer] Add modeling for unque_ptr::get() (authored by vrnithinkumar).
[analyzer] Add modeling for unque_ptr::get()
Aug 23 2020, 5:51 AM
vrnithinkumar closed D86029: [analyzer] Add modeling for unque_ptr::get().
Aug 23 2020, 5:51 AM · Restricted Project

Aug 21 2020

vrnithinkumar added inline comments to D86373: [analyzer] Add modeling for unique_ptr move constructor.
Aug 21 2020, 2:42 PM · Restricted Project
vrnithinkumar updated the summary of D86373: [analyzer] Add modeling for unique_ptr move constructor.
Aug 21 2020, 2:39 PM · Restricted Project
vrnithinkumar requested review of D86373: [analyzer] Add modeling for unique_ptr move constructor.
Aug 21 2020, 2:37 PM · Restricted Project

Aug 20 2020

vrnithinkumar updated the summary of D86293: [analyzer] Add modeling of Eq operator in smart ptr.
Aug 20 2020, 11:49 AM · Restricted Project
vrnithinkumar updated the diff for D86293: [analyzer] Add modeling of Eq operator in smart ptr.
  • Add assignment to nullptr case
Aug 20 2020, 11:46 AM · Restricted Project
vrnithinkumar requested review of D86293: [analyzer] Add modeling of Eq operator in smart ptr.
Aug 20 2020, 8:06 AM · Restricted Project

Aug 19 2020

vrnithinkumar added inline comments to D86029: [analyzer] Add modeling for unque_ptr::get().
Aug 19 2020, 3:36 PM · Restricted Project
vrnithinkumar updated the diff for D86029: [analyzer] Add modeling for unque_ptr::get().
  • Using conjureSymbolVal in case of missing inner pointer value
Aug 19 2020, 3:29 PM · Restricted Project
vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 19 2020, 12:32 PM · Restricted Project
vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 19 2020, 12:30 PM · Restricted Project
vrnithinkumar updated the diff for D86027: [analyzer] Add bool operator modeling for unque_ptr.

Changes to use conjureSymbolVal if the inner pointer value is missing

Aug 19 2020, 12:30 PM · Restricted Project

Aug 18 2020

vrnithinkumar committed rGb34b1e38381f: [Analysis] Bug fix for exploded graph branching in evalCall for constructor (authored by vrnithinkumar).
[Analysis] Bug fix for exploded graph branching in evalCall for constructor
Aug 18 2020, 3:04 PM
vrnithinkumar closed D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Aug 18 2020, 3:03 PM · Restricted Project

Aug 17 2020

vrnithinkumar added inline comments to D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Aug 17 2020, 5:07 AM · Restricted Project
vrnithinkumar updated the diff for D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
  • Make exactly single NodeBuilder exists at any given time
Aug 17 2020, 4:59 AM · Restricted Project

Aug 15 2020

vrnithinkumar updated the summary of D86029: [analyzer] Add modeling for unque_ptr::get().
Aug 15 2020, 4:40 PM · Restricted Project
vrnithinkumar requested review of D86029: [analyzer] Add modeling for unque_ptr::get().
Aug 15 2020, 4:38 PM · Restricted Project
vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 15 2020, 4:20 PM · Restricted Project
vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 15 2020, 4:15 PM · Restricted Project
vrnithinkumar added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 15 2020, 2:49 PM · Restricted Project
vrnithinkumar updated the summary of D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 15 2020, 2:46 PM · Restricted Project
vrnithinkumar requested review of D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 15 2020, 2:44 PM · Restricted Project

Aug 14 2020

vrnithinkumar added inline comments to D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Aug 14 2020, 2:47 PM · Restricted Project
vrnithinkumar updated the diff for D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
  • Fix without passing the NodeBuilder
Aug 14 2020, 2:39 PM · Restricted Project

Aug 13 2020

vrnithinkumar added a comment to D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Aug 13 2020, 3:56 PM · Restricted Project
vrnithinkumar updated the diff for D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
  • Addressing review comments
Aug 13 2020, 3:50 PM · Restricted Project

Aug 12 2020

vrnithinkumar added inline comments to D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Aug 12 2020, 4:38 PM · Restricted Project

Aug 11 2020

vrnithinkumar updated the summary of D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Aug 11 2020, 4:52 PM · Restricted Project
vrnithinkumar requested review of D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Aug 11 2020, 4:39 PM · Restricted Project
vrnithinkumar committed rG06d100a69a08: [Analyzer] Support note tags for smart ptr checker (authored by vrnithinkumar).
[Analyzer] Support note tags for smart ptr checker
Aug 11 2020, 2:28 PM
vrnithinkumar closed D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 11 2020, 2:27 PM · Restricted Project

Aug 9 2020

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 9 2020, 3:57 PM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Updating test with tags from header file
Aug 9 2020, 3:56 PM · Restricted Project

Aug 8 2020

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 8 2020, 10:30 AM · Restricted Project
vrnithinkumar added a comment to D84600: [Analyzer] Support note tags for smart ptr checker.

Layering violations are a running theme in the analyzer -- CheckerRegistry and the entire MallocChecker fiasco are two glaring examples. Luckily, this isn't a severe case so I wouldn't worry about it much.

I've been following your patches, but them mentors answer way ahead of me and are very thorough :^) Best of luck with the finale!

Aug 8 2020, 10:27 AM · Restricted Project
vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 8 2020, 10:18 AM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Review comment changes
Aug 8 2020, 10:18 AM · Restricted Project

Aug 6 2020

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 6 2020, 7:30 AM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Changes from review comments
Aug 6 2020, 7:30 AM · Restricted Project

Aug 5 2020

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 5 2020, 2:51 PM · Restricted Project

Aug 4 2020

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 4 2020, 9:33 AM · Restricted Project

Aug 3 2020

vrnithinkumar closed D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Aug 3 2020, 5:06 PM · Restricted Project
vrnithinkumar closed D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Aug 3 2020, 5:05 PM · Restricted Project
vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Aug 3 2020, 5:05 PM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Addressing review comments
Aug 3 2020, 5:04 PM · Restricted Project

Aug 2 2020

vrnithinkumar added a comment to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
In D83836#2189636, @NoQ wrote:

These patches look like they're done, maybe let's land them?

Aug 2 2020, 1:35 PM · Restricted Project
vrnithinkumar added a comment to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
In D83877#2189637, @NoQ wrote:

These patches look like they're done, maybe let's land them?

Aug 2 2020, 1:34 PM · Restricted Project

Jul 31 2020

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Jul 31 2020, 5:31 PM · Restricted Project
vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Jul 31 2020, 5:09 PM · Restricted Project

Jul 26 2020

vrnithinkumar added reviewers for D84600: [Analyzer] Support note tags for smart ptr checker: NoQ, vsavchenko, xazax.hun, Szelethus.
Jul 26 2020, 10:14 AM · Restricted Project
Herald added a project to D84600: [Analyzer] Support note tags for smart ptr checker: Restricted Project.
Jul 26 2020, 10:09 AM · Restricted Project

Jul 21 2020

vrnithinkumar committed rG76c057776350: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling (authored by vrnithinkumar).
[Analyzer] Handle unique_ptr::swap() in SmartPtrModeling
Jul 21 2020, 3:05 AM

Jul 20 2020

vrnithinkumar committed rGa5609102117d: [Analyzer] Add checkRegionChanges for SmartPtrModeling (authored by vrnithinkumar).
[Analyzer] Add checkRegionChanges for SmartPtrModeling
Jul 20 2020, 9:19 PM

Jul 17 2020

vrnithinkumar added inline comments to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Jul 17 2020, 6:52 AM · Restricted Project
vrnithinkumar updated the diff for D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
  • Changes from review comments
Jul 17 2020, 6:51 AM · Restricted Project
vrnithinkumar retitled D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling from [Analyzer] Changed in SmartPtrModeling to handle Swap to [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Jul 17 2020, 2:46 AM · Restricted Project

Jul 16 2020

vrnithinkumar added inline comments to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Jul 16 2020, 4:34 PM · Restricted Project
vrnithinkumar updated the diff for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
  • Adding a missed todo
Jul 16 2020, 4:32 PM · Restricted Project
vrnithinkumar updated the diff for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
  • Addressing review comments
  • Enabling commented out tests
Jul 16 2020, 4:14 PM · Restricted Project
vrnithinkumar retitled D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling from [Analyzer] Implementing checkRegionChanges for SmartPtrModeling to [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Jul 16 2020, 3:31 PM · Restricted Project

Jul 15 2020

vrnithinkumar added inline comments to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Jul 15 2020, 8:48 AM · Restricted Project
vrnithinkumar updated the diff for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.

Untrack all changing regions in checkRegionChanges

Jul 15 2020, 8:46 AM · Restricted Project
vrnithinkumar added inline comments to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Jul 15 2020, 8:04 AM · Restricted Project
vrnithinkumar added reviewers for D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling: NoQ, vsavchenko, xazax.hun, Szelethus.
Jul 15 2020, 8:03 AM · Restricted Project
Herald added a project to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling: Restricted Project.
Jul 15 2020, 8:01 AM · Restricted Project

Jul 14 2020

vrnithinkumar added inline comments to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Jul 14 2020, 6:16 PM · Restricted Project
vrnithinkumar added reviewers for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling: NoQ, Szelethus, vsavchenko, xazax.hun.
Jul 14 2020, 6:06 PM · Restricted Project
Herald added a project to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling: Restricted Project.
Jul 14 2020, 5:58 PM · Restricted Project

Jul 8 2020

vrnithinkumar committed rG20e271a98de5: [analyzer] Warning for default constructed unique_ptr dereference (authored by vrnithinkumar).
[analyzer] Warning for default constructed unique_ptr dereference
Jul 8 2020, 12:52 AM
vrnithinkumar closed D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jul 8 2020, 12:52 AM · Restricted Project