Page MenuHomePhabricator

vrnithinkumar (Nithin VR)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 6:52 AM (36 w, 3 d)

Recent Activity

Fri, Jul 3

vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Fri, Jul 3, 11:17 AM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

addressing review comments

Fri, Jul 3, 11:17 AM · Restricted Project

Thu, Jul 2

vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Addressing review comments

Thu, Jul 2, 4:13 PM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Thu, Jul 2, 4:13 PM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Thu, Jul 2, 5:52 AM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Thu, Jul 2, 5:52 AM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.
  • Created a new checker for smart point derference diagnostic
  • Moved checking part to this checker
  • Kept all the modeling in SmartPtrModeling
  • Created a header file for shared API -calls
Thu, Jul 2, 5:52 AM · Restricted Project

Fri, Jun 26

vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Fri, Jun 26, 3:10 PM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Moving dereference precondition checks into checkPreCall.

Fri, Jun 26, 3:10 PM · Restricted Project

Thu, Jun 25

vrnithinkumar added a comment to D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Best of luck on your GSoC! I don't have much else to add to your patch, but you seem to have made good progress already!

Thanks!

some folks have automated scripts based on that tag to add themselves as subscriber/reviewer.

Hope you don't mind my intrusion :)

Not at all.

I am not sure about whether I should use eval::Call or both check::PreCall and check::PostCall. In the eval::Call documentation I found this "Note, that only one checker can evaluate a call.". So I am little bit confused about using it.

Inlining (when we model a function call, https://youtu.be/yh2qdnJjizE?t=238) is rather expensive. Creating a new stack frame, parameters, new ExplodedNodes, running checkers, etc., eats memory for breakfast, is slow and limits how deep the analysis can go. Worse still, the analysis could lose precision if the called function's definition isn't available. eval::Call serves to circumvent this by allowing the analyzer to give a precise summary of the function. StreamChecker, for instance, uses this for functions such as clearerr() -- the C standard defines how this function should behave, so upon encountering a call to it, we don't need all the extra work regular inlining demands, just ask StreamChecker to model it for us.

Use eval::Call if you can provide a precise model for a function. Only a single checker is allowed to do that -- you can see that it returns with a boolean value to sign whether the checker could provide an evaluation, and as far as I know, the first checker that returns true will be doing it.

I think it would be appropriate in this instance, because we're modeling a well established API. In general, I think we should use it when appropriate more often, like in MallocChecker.

Thank you for the detailed help.

Thu, Jun 25, 6:02 PM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Addressing review comments

Thu, Jun 25, 6:02 PM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Thu, Jun 25, 6:02 PM · Restricted Project
Artem Dergachev <adergachev@apple.com> committed rG37c1bf21d1da: [analyzer] Enable constructor support in evalCall event. (authored by vrnithinkumar).
[analyzer] Enable constructor support in evalCall event.
Thu, Jun 25, 10:14 AM
vrnithinkumar closed D82256: [analyzer] Enable constructor support in evalCall event.
Thu, Jun 25, 10:14 AM · Restricted Project
vrnithinkumar added a comment to D82256: [analyzer] Enable constructor support in evalCall event.
In D82256#2113233, @NoQ wrote:

@vrnithinkumar what's your preferred Full Name <email> for llvm's git?

Thu, Jun 25, 3:12 AM · Restricted Project

Wed, Jun 24

vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

clang-format fix

Wed, Jun 24, 2:40 PM · Restricted Project
vrnithinkumar retitled D82256: [analyzer] Enable constructor support in evalCall event from [analyzer] Enabling ctr in evalCall event to [analyzer] Enable constructor support in evalCall event.
Wed, Jun 24, 12:29 PM · Restricted Project
vrnithinkumar added inline comments to D82256: [analyzer] Enable constructor support in evalCall event.
Wed, Jun 24, 12:28 PM · Restricted Project
vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

Fixing test failures

Wed, Jun 24, 11:55 AM · Restricted Project

Sat, Jun 20

vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

Addressing review comment adding miised new line

Sat, Jun 20, 4:25 PM · Restricted Project
vrnithinkumar added inline comments to D82256: [analyzer] Enable constructor support in evalCall event.
Sat, Jun 20, 4:25 PM · Restricted Project
vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

Fixing wrongly deleted the old commit via arc

Sat, Jun 20, 4:25 PM · Restricted Project
vrnithinkumar added inline comments to D82256: [analyzer] Enable constructor support in evalCall event.
Sat, Jun 20, 5:16 AM · Restricted Project
vrnithinkumar retitled D82256: [analyzer] Enable constructor support in evalCall event from Enabling ctr in evalCall event to [analyzer] Enabling ctr in evalCall event.
Sat, Jun 20, 5:16 AM · Restricted Project
vrnithinkumar created D82256: [analyzer] Enable constructor support in evalCall event.
Sat, Jun 20, 4:44 AM · Restricted Project

Fri, Jun 12

vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Fri, Jun 12, 7:31 AM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Addressing the review comments

Fri, Jun 12, 7:31 AM · Restricted Project
vrnithinkumar abandoned D81734: Initial smart pointer check.

It was a mistake
I was supposed to update an existing review.
first time use of arc

Fri, Jun 12, 6:58 AM · Restricted Project
vrnithinkumar created D81734: Initial smart pointer check.
Fri, Jun 12, 6:58 AM · Restricted Project

Jun 5 2020

vrnithinkumar created D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jun 5 2020, 4:16 PM · Restricted Project

May 24 2020

vrnithinkumar updated the diff for D80490: [clang-tidy] Check for rule of five and zero..

fixed the clang-tidy warnig

May 24 2020, 5:51 AM · Restricted Project
vrnithinkumar created D80490: [clang-tidy] Check for rule of five and zero..
May 24 2020, 4:16 AM · Restricted Project