Page MenuHomePhabricator

voskresensky.vladimir (Vladimir Voskresensky)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2015, 4:08 AM (238 w, 11 h)

Recent Activity

Nov 16 2018

voskresensky.vladimir added a comment to D54547: PTH-- Remove feature entirely-.

I thought clang-d service is using it to speed up indexing.

Presumably, I could also just make PTH use another bit or two for the TokenID and it would work fine. However, when I mentioned this on IRC the general response was that it is a 'failed experiment'. In your use case, I wonder why you couldn't just use PCH and get even further performance improvements?

To be fair, I don't remember exactly. :-)
I remember we shared the same PTH for all C and C++ files and built some preprocessor-based features for incomplete code written in editor based on that.

Nov 16 2018, 11:08 AM
voskresensky.vladimir added a comment to D54547: PTH-- Remove feature entirely-.

I have some experience with PTH implementation, because had to fix it for Java-port of Clang (https://github.com/java-port/clank).

Nov 16 2018, 10:50 AM

Jun 29 2017

voskresensky.vladimir added a comment to D34766: fix NSAPI constants to reflect the current state of NSStringMethodKind/NSDictionaryMethodKind enums.

LGTM, Thanks! Do you have commit access?

Jun 29 2017, 5:47 AM

Jun 28 2017

voskresensky.vladimir added a reviewer for D34766: fix NSAPI constants to reflect the current state of NSStringMethodKind/NSDictionaryMethodKind enums: arphaman.
Jun 28 2017, 10:48 AM
voskresensky.vladimir created D34766: fix NSAPI constants to reflect the current state of NSStringMethodKind/NSDictionaryMethodKind enums.
Jun 28 2017, 10:44 AM

Jun 20 2017

voskresensky.vladimir added a comment to D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros.

Here's an example to clarify the difference:

Thanks for the example. You are right, I missed this difference in patch.

Jun 20 2017, 2:07 AM

Jun 19 2017

voskresensky.vladimir added a comment to D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros.

Hey Vladimir, what you are proposing is orthogonal to this patch. You are proposing for "the client to provide the value for an undefined identifier", and the patch is about the client not knowing what the value should be so it fallbacks to parsing all tokens to get the max amount of info. Note that both of the techniques can be combined well, if the client provides the value, the preprocessor will take it into account, otherwise if it is stays unresolved it will fallback to lexing all tokens.
But what you are proposing is not a replacement for what the patch is doing.

Jun 19 2017, 2:40 AM

Jun 16 2017

voskresensky.vladimir added a comment to D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros.

Hello Argyrios,
This is a good addition to simplify reuse of preprocessor in IDEs. Thanks for doing this.

Jun 16 2017, 2:25 AM

May 12 2015

voskresensky.vladimir added a comment to D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.

Nikola, I don't have write access, so I'd appreciate your help with commit.

May 12 2015, 4:32 AM
voskresensky.vladimir updated the diff for D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.

updated comments

May 12 2015, 3:33 AM

May 9 2015

voskresensky.vladimir updated the diff for D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.

Sorry for the long delay! I've attached changes from 'clang-extra'

May 9 2015, 9:49 AM

Apr 20 2015

voskresensky.vladimir retitled D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped from to Fixed misleading parameter name for PPCallbacks::FileSkipped.
Apr 20 2015, 7:23 AM