Page MenuHomePhabricator

vladaindjic (Vladimir Inđić)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 15 2021, 12:27 PM (11 w, 5 d)

Recent Activity

Wed, Dec 1

vladaindjic added a reviewer for D111789: [OpenMP][OMPT] ompt_parallel_invoker_program used when clang generates the code of parallel if(0)-serialized regions: jlpeyton.
Wed, Dec 1, 1:21 AM · Restricted Project

Tue, Nov 30

vladaindjic updated the diff for D111789: [OpenMP][OMPT] ompt_parallel_invoker_program used when clang generates the code of parallel if(0)-serialized regions.

As @protze.joachim suggested, kmpc_end_serialized_parallel is not called from within the runtime code on host.
Instead,
kmp_end_serialized_parallel function has been created by copying the body
of __kmpc_ counterpart. Its parameters list has been extended with the “invoker” parameter
responsible to distinct whether the parallel region’s wrapper function is called
by the runtime code or the OpenMP program directly. The later one corresponds to the
parallel construct that contains if(0) clause compiled with clang.

Tue, Nov 30, 3:25 AM · Restricted Project

Oct 25 2021

vladaindjic added a comment to D112419: [OpenMP][OMPT][clang] task frame support fixed in __kmpc_fork_call.

@protze.joachim Thank you for the revision. Could you please land this commit for me?

Oct 25 2021, 9:02 AM · Restricted Project
vladaindjic added a comment to D110699: [OpenMP][OMPT] thread_num determination during execution of nested serialized parallel regions.

@protze.joachim Thank you for the revision. Could you please land this patch for me?

Oct 25 2021, 5:11 AM · Restricted Project
vladaindjic updated the diff for D112419: [OpenMP][OMPT][clang] task frame support fixed in __kmpc_fork_call.
  • clang-formated diffs in kmp_csupport.cpp
Oct 25 2021, 2:54 AM · Restricted Project
vladaindjic requested review of D112419: [OpenMP][OMPT][clang] task frame support fixed in __kmpc_fork_call.
Oct 25 2021, 2:45 AM · Restricted Project

Oct 21 2021

vladaindjic added a comment to D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS.

@jlpeyton Thank you a lot for the review. Could you please land this patch for me?

Oct 21 2021, 2:54 PM · Restricted Project
vladaindjic added a comment to D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS.
Oct 21 2021, 2:53 PM · Restricted Project
vladaindjic updated the diff for D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS.

As @jlpeyton suggessted, the following is done:

  • Unnecessary code has been removed from sections_serialized.c test case
  • print_ids is used inside the same test case.
Oct 21 2021, 7:33 AM · Restricted Project
vladaindjic requested review of D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS.
Oct 21 2021, 2:13 AM · Restricted Project

Oct 20 2021

vladaindjic requested review of D112149: [OpenMP][OMPT][GOMP] PARALLEL_LOOP macro initializes exit_frame.
Oct 20 2021, 9:13 AM · Restricted Project

Oct 19 2021

vladaindjic updated the diff for D110707: [OpenMP][OMPT] lightweight tasks and explicit tasks.
  • [OpenMP][OMPT] clang-formatted diffs of kmp_tasking_flags.h and ompt-specific.cpp
Oct 19 2021, 4:09 AM · Restricted Project
vladaindjic updated the diff for D110707: [OpenMP][OMPT] lightweight tasks and explicit tasks.

The diff context should have been provided. @protze.joachim
Also, some comments have been rewritten for clarification.

Oct 19 2021, 3:31 AM · Restricted Project
vladaindjic updated the diff for D110811: [OpenMP][OMPT] Unnecessary execution of the while loop inside __ompt_get_task_info_internal.

The diffs have been updated through arc diff tool instead of web form.

Oct 19 2021, 3:08 AM · Restricted Project

Oct 18 2021

vladaindjic updated the diff for D110699: [OpenMP][OMPT] thread_num determination during execution of nested serialized parallel regions.

[OpenMP][OMPT] Barrier has been added inside nested_lwt_thread_num.c test case.

Oct 18 2021, 9:46 AM · Restricted Project
vladaindjic added a comment to D110473: [OpenMP][OMPT] thread_num determination for programs with explicit tasks.

@protze.joachim Thank you very much for reviewing. Could you please land this patch for me?

Oct 18 2021, 4:26 AM · Restricted Project

Oct 14 2021

vladaindjic updated the diff for D111789: [OpenMP][OMPT] ompt_parallel_invoker_program used when clang generates the code of parallel if(0)-serialized regions.
  • clang-formatted diffs in kmp_csupport.cpp
Oct 14 2021, 4:16 AM · Restricted Project
vladaindjic requested review of D111789: [OpenMP][OMPT] ompt_parallel_invoker_program used when clang generates the code of parallel if(0)-serialized regions.
Oct 14 2021, 4:00 AM · Restricted Project

Oct 1 2021

vladaindjic updated the diff for D110811: [OpenMP][OMPT] Unnecessary execution of the while loop inside __ompt_get_task_info_internal.

@protze.joachim According to the standard specification which claims the following: “If no task region exists at the specified ancestor level or the information is unavailable then the values of variables passed by reference to the entry point are undefined when ompt_get_task_info returns.”, it is not safe to use “task_data” and “parallel_data” before previously asserting that “ret == 2” inside ompt-multiplex.h test sections.

Oct 1 2021, 3:44 AM · Restricted Project

Sep 30 2021

vladaindjic requested review of D110811: [OpenMP][OMPT] Unnecessary execution of the while loop inside __ompt_get_task_info_internal.
Sep 30 2021, 4:09 AM · Restricted Project

Sep 29 2021

vladaindjic updated the diff for D110707: [OpenMP][OMPT] lightweight tasks and explicit tasks.

Some comments has been clarified.
Also, the diffs in ompt-specific.cpp has been clang-formatted.

Sep 29 2021, 2:27 PM · Restricted Project
vladaindjic requested review of D110707: [OpenMP][OMPT] lightweight tasks and explicit tasks.
Sep 29 2021, 5:58 AM · Restricted Project
vladaindjic requested review of D110699: [OpenMP][OMPT] thread_num determination during execution of nested serialized parallel regions.
Sep 29 2021, 5:04 AM · Restricted Project

Sep 27 2021

vladaindjic added a comment to D110441: [OpenMP][GNU] Usage of TASK_TIED constant inside kmp_gsupport.cpp.

@AndreyChurbanov, could you please land this patch for me?

Sep 27 2021, 6:09 AM · Restricted Project

Sep 25 2021

vladaindjic requested review of D110473: [OpenMP][OMPT] thread_num determination for programs with explicit tasks.
Sep 25 2021, 4:52 AM · Restricted Project

Sep 24 2021

vladaindjic requested review of D110441: [OpenMP][GNU] Usage of TASK_TIED constant inside kmp_gsupport.cpp.
Sep 24 2021, 12:43 PM · Restricted Project