Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

vidsinghal (Vidhush Singhal)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2023, 12:07 PM (17 w, 2 d)

Recent Activity

Sep 4 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Remove run commands in depgraph.ll that were not being parsed

Sep 4 2023, 10:28 AM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

New example and question about what the optimization should do for an example like @baz in allocator.ll

Sep 4 2023, 9:42 AM · Restricted Project, Restricted Project

Sep 3 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Add null check for IntOperand

Sep 3 2023, 12:11 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Add new test where argument to malloc isn't a constant.
Use AAPotentialConstantValues to get the constant value.

Sep 3 2023, 11:51 AM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

style

Sep 3 2023, 9:08 AM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Clean up code

Sep 3 2023, 9:03 AM · Restricted Project, Restricted Project

Sep 2 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Don't call AAPointerInfoGetOrCreate other than Alloca and Malloc Instruction. Results in infinite loop for instance when calling a ptr

Sep 2 2023, 8:51 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

edits

Sep 2 2023, 6:23 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

fix example IR

Sep 2 2023, 6:14 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Delete malloc call after attributor update

Sep 2 2023, 5:59 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

edit

Sep 2 2023, 4:34 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

fix name variable

Sep 2 2023, 4:23 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

edits

Sep 2 2023, 2:37 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Support for modifying malloc instructions
TODO: The original malloc call is not being removed by changeAfterManifest even though it is dead.

Sep 2 2023, 2:19 PM · Restricted Project, Restricted Project

Sep 1 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

remove (void)success

Sep 1 2023, 7:03 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Make switch to indentify alloca vs malloc instruction

Sep 1 2023, 6:50 PM · Restricted Project, Restricted Project

Aug 30 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Add a positive test with TODO

Aug 30 2023, 8:48 PM · Restricted Project, Restricted Project

Aug 27 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Add API for begin, end size in AAPointerInfo

Aug 27 2023, 11:59 AM · Restricted Project, Restricted Project
vidsinghal added inline comments to D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.
Aug 27 2023, 11:33 AM · Restricted Project, Restricted Project

Aug 24 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

edits

Aug 24 2023, 3:28 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

add maybe_unused pragma

Aug 24 2023, 3:24 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

1.) Put method to get offsetBins in AAPointerInfo
2.) work on other comments.

Aug 24 2023, 3:11 PM · Restricted Project, Restricted Project

Aug 23 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

1.) Insert a new instruction instead of modiying the old one (Char array)
2.) Restore value-simplify-local-remote.ll
3.) Add a new positive test to reduce size of array alloca

Aug 23 2023, 5:17 PM · Restricted Project, Restricted Project

Aug 22 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

check for zero alloca and indicate fixpoint.

Aug 22 2023, 12:02 PM · Restricted Project, Restricted Project

Aug 21 2023

vidsinghal added inline comments to D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.
Aug 21 2023, 6:50 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Remove un-necessary if condition for struct with only one element.

Aug 21 2023, 6:49 PM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Fix bugs

Aug 21 2023, 4:40 PM · Restricted Project, Restricted Project
vidsinghal added inline comments to D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.
Aug 21 2023, 8:25 AM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Revision based on comments

Aug 21 2023, 8:25 AM · Restricted Project, Restricted Project

Aug 20 2023

vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.
Aug 20 2023, 10:41 AM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Fix typo in assert.
Add a positive test case for malloc with a TODO.

Aug 20 2023, 9:46 AM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Edited unit tests

Aug 20 2023, 7:09 AM · Restricted Project, Restricted Project
vidsinghal added inline comments to D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.
Aug 20 2023, 7:00 AM · Restricted Project, Restricted Project
vidsinghal updated the diff for D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation.

Fixed some comments.

Aug 20 2023, 6:50 AM · Restricted Project, Restricted Project

Aug 15 2023

vidsinghal published D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation for review.
Aug 15 2023, 1:02 PM · Restricted Project, Restricted Project

Aug 10 2023

vidsinghal abandoned D157634: [Attributor] Revision to AAAllocationinfo based on Review.
Aug 10 2023, 1:36 PM · Restricted Project, Restricted Project
vidsinghal removed reviewers for D157634: [Attributor] Revision to AAAllocationinfo based on Review: sstefan1, homerdin.
Aug 10 2023, 1:22 PM · Restricted Project, Restricted Project
vidsinghal removed reviewers for D157634: [Attributor] Revision to AAAllocationinfo based on Review: sstefan1, homerdin.
Aug 10 2023, 1:20 PM · Restricted Project, Restricted Project
vidsinghal removed reviewers for D157634: [Attributor] Revision to AAAllocationinfo based on Review: homerdin, sstefan1.
Aug 10 2023, 1:19 PM · Restricted Project, Restricted Project
vidsinghal requested review of D157634: [Attributor] Revision to AAAllocationinfo based on Review.
Aug 10 2023, 9:42 AM · Restricted Project, Restricted Project