Page MenuHomePhabricator

vddvss (Colin Samples)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2019, 4:02 PM (42 w, 3 d)

Recent Activity

Jan 2 2020

vddvss updated the diff for D71287: [PowerPC] Use fcti[dw] instructions in additional cases.

Updated differential. This moves the actions to near where D69949 had them, guards them with TM.Options.UnsafeFPMath (I can't believe I didn't do that in the first patch), and changes tests accordingly.

Jan 2 2020, 12:21 PM · Restricted Project

Dec 13 2019

vddvss added a comment to D71138: [PowerPC] Fix %llvm.ppc.altivec.vc* lowering.

Oops, sorry about the typo in the URL. When ready, could someone please land for me? Thanks!

Dec 13 2019, 8:33 AM · Restricted Project

Dec 10 2019

vddvss created D71287: [PowerPC] Use fcti[dw] instructions in additional cases.
Dec 10 2019, 10:37 AM · Restricted Project

Dec 9 2019

vddvss updated the diff for D71170: [PowerPC] [NFC] Cleanup xxpermdi peephole optimization.

This addresses @jsji's note about the potential for stack slots being let through by using isPhysicalRegister. It changes this pattern and the one from D69497 to use !isVirtualRegister.

Dec 9 2019, 1:12 PM · Restricted Project
vddvss added inline comments to D71170: [PowerPC] [NFC] Cleanup xxpermdi peephole optimization.
Dec 9 2019, 12:16 PM · Restricted Project
vddvss added a comment to D71170: [PowerPC] [NFC] Cleanup xxpermdi peephole optimization.

LGTM, as early return makes the code more clear. Thank you for the clean up.

Dec 9 2019, 6:33 AM · Restricted Project

Dec 8 2019

vddvss added a comment to D71170: [PowerPC] [NFC] Cleanup xxpermdi peephole optimization.

Please attach the test if it is NOT NFC patch, otherwise, adding a tag [NFC] in the title, thank you.

Dec 8 2019, 6:30 PM · Restricted Project
vddvss retitled D71170: [PowerPC] [NFC] Cleanup xxpermdi peephole optimization from [PowerPC] Cleanup xxpermdi peephole optimization to [PowerPC] [NFC] Cleanup xxpermdi peephole optimization.
Dec 8 2019, 6:27 PM · Restricted Project

Dec 7 2019

vddvss created D71170: [PowerPC] [NFC] Cleanup xxpermdi peephole optimization.
Dec 7 2019, 3:15 PM · Restricted Project

Dec 6 2019

vddvss created D71138: [PowerPC] Fix %llvm.ppc.altivec.vc* lowering.
Dec 6 2019, 11:38 AM · Restricted Project
vddvss added a comment to D69497: [PowerPC] Fix MI peephole optimization for splats.

@lkail yes, new contributor here so if you can land it or tell me how to go about that? Thanks

Dec 6 2019, 5:16 AM · Restricted Project

Nov 5 2019

vddvss abandoned D69267: [PowerPC] Fix lrint and llrint code generation.
Nov 5 2019, 1:06 PM · Restricted Project

Nov 1 2019

vddvss updated the diff for D69497: [PowerPC] Fix MI peephole optimization for splats.

See attached for an updated diff. This also changes the name of FeedImmed to DefImmed to be congruent with DefReg[12].

Nov 1 2019, 8:12 AM · Restricted Project

Oct 30 2019

vddvss updated the diff for D69497: [PowerPC] Fix MI peephole optimization for splats.

Per @jsji's suggestion, this checks if the operands to DefMI are both the same virtual register, which enables optimization in more cases.

Oct 30 2019, 8:52 AM · Restricted Project
vddvss added inline comments to D69497: [PowerPC] Fix MI peephole optimization for splats.
Oct 30 2019, 8:15 AM · Restricted Project

Oct 28 2019

vddvss updated the diff for D69497: [PowerPC] Fix MI peephole optimization for splats.

Updated revision. Note, I also had to update test/CodeGen/PowerPC/load-shuffle-and-shuffle-store.ll since this will omit the optimization in some of those cases.

Oct 28 2019, 7:31 AM · Restricted Project

Oct 27 2019

vddvss created D69497: [PowerPC] Fix MI peephole optimization for splats.
Oct 27 2019, 6:18 PM · Restricted Project

Oct 22 2019

vddvss added a comment to D69267: [PowerPC] Fix lrint and llrint code generation.

Thanks. Should have checked :) This issue is causing buffer overflows in some applications compiled with Clang 9, so hopefully your fix can be ok'd soon.

Oct 22 2019, 6:26 PM · Restricted Project

Oct 21 2019

vddvss created D69267: [PowerPC] Fix lrint and llrint code generation.
Oct 21 2019, 10:27 AM · Restricted Project