Page MenuHomePhabricator

varungandhi-apple (Varun Gandhi)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2019, 5:18 PM (40 w, 2 d)

Recent Activity

Today

varungandhi-apple added a comment to D82791: [lit] Improve lit's output with default settings and --verbose..

Thanks for the review, it's a big patch. ๐Ÿ˜… I'm a bit busy at the moment, I will respond to the other comments later this week or sometime next week.

Mon, Jul 6, 12:29 PM ยท Restricted Project, Restricted Project

Wed, Jul 1

varungandhi-apple updated the diff for D82814: [lit] Replace echo_all_commands with run_with_command_output..

Rebase after changes in D82808.

Wed, Jul 1, 10:48 AM ยท Restricted Project
varungandhi-apple updated the diff for D82811: [lit] Highlight failing line with colored output..

Rebase after changes in D82808.

Wed, Jul 1, 10:48 AM ยท Restricted Project
varungandhi-apple updated the diff for D82791: [lit] Improve lit's output with default settings and --verbose..

Rebase after changes in D82808.

Wed, Jul 1, 10:48 AM ยท Restricted Project, Restricted Project
varungandhi-apple updated the diff for D82808: [docs] [lit] Add a more helpful description for lit.py's -s flag..

Addressed review comment: replace shows -> show.

Wed, Jul 1, 10:48 AM ยท Restricted Project

Mon, Jun 29

varungandhi-apple added a comment to D82811: [lit] Highlight failing line with colored output..

Please review D82791: "[lit] Improve lit's output with default settings and --verbose." before reviewing this revision.

Mon, Jun 29, 3:32 PM ยท Restricted Project
varungandhi-apple added a comment to D82814: [lit] Replace echo_all_commands with run_with_command_output..

Please review D82791: "[lit] Improve lit's output with default settings and --verbose." and D82811 "[lit] Highlight failing line with colored output." before reviewing this revision.

Mon, Jun 29, 3:32 PM ยท Restricted Project
varungandhi-apple abandoned D80694: Improve lit.py's usability by highlighting failing lines..
Mon, Jun 29, 3:18 PM ยท Restricted Project
varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

I've split this patch up into four different patches. Here is the suggested review order:

Mon, Jun 29, 3:18 PM ยท Restricted Project
varungandhi-apple created D82814: [lit] Replace echo_all_commands with run_with_command_output..
Mon, Jun 29, 3:18 PM ยท Restricted Project
varungandhi-apple added a reviewer for D82791: [lit] Improve lit's output with default settings and --verbose.: yln.
Mon, Jun 29, 2:58 PM ยท Restricted Project, Restricted Project
varungandhi-apple created D82811: [lit] Highlight failing line with colored output..
Mon, Jun 29, 2:58 PM ยท Restricted Project
varungandhi-apple updated the diff for D82791: [lit] Improve lit's output with default settings and --verbose..
  • [docs] [lit] Add a more helpful description for lit.py's -s flag.
  • [NFC] [lit] Separate verbose and showOutput.
  • [lit] Improve lit's output with default settings and --verbose.
Mon, Jun 29, 2:46 PM ยท Restricted Project, Restricted Project
varungandhi-apple updated the diff for D82791: [lit] Improve lit's output with default settings and --verbose..

Include missing commit separating verbose and showOutput.

Mon, Jun 29, 2:46 PM ยท Restricted Project, Restricted Project
varungandhi-apple created D82808: [docs] [lit] Add a more helpful description for lit.py's -s flag..
Mon, Jun 29, 2:46 PM ยท Restricted Project
varungandhi-apple created D82791: [lit] Improve lit's output with default settings and --verbose..
Mon, Jun 29, 10:48 AM ยท Restricted Project, Restricted Project

Fri, Jun 19

varungandhi-apple added inline comments to D82233: [lit] Add --show command line option.
Fri, Jun 19, 5:56 PM ยท Restricted Project

May 31 2020

varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

On second thought, I'm going to update the documentation alongside the behavior change, to make sure the two are in sync.
Patch 1: Change behavior of -v. (and default and -vv behavior). Update https://llvm.org/docs/CommandGuide/lit.html as necessary.
Patch 2: Add highlighting/colored output. Update https://llvm.org/docs/CommandGuide/lit.html as necessary.
Patch 3: Rename echo_all_commands to runWithCommandOutput.

May 31 2020, 7:25 PM ยท Restricted Project

May 28 2020

varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

Quick question: We show the command output up to and including the failing line. Should we do the same for the script part, i.e., skip the un-executed part of the script? Is it ever useful to know which script line/command would have been executed next?

May 28 2020, 5:38 PM ยท Restricted Project
varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

@JDevlieghere, that is part of the code that is writing out the command line.

May 28 2020, 3:59 PM ยท Restricted Project
varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

Hmm, Phabricator attached my inline comment to my other larger comment, that's confusing.
I'm guessing I was supposed to make an out-of-line comment paired with the inline one,
that's what the "not submitted" was about.

May 28 2020, 3:59 PM ยท Restricted Project
varungandhi-apple updated the diff for D80694: Improve lit.py's usability by highlighting failing lines..

Fixed some variable names, added some doc comments, cleaned up some logic, added some more CHECK lines to tests.

May 28 2020, 12:38 PM ยท Restricted Project
varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

Ah, I just realized there are some inconsistent variable names, some are snake_case, some are camelCase. Should I be consistently using camelCase? I did see a bunch of snake_case variables, that's probably what tripped me up...

May 28 2020, 9:15 AM ยท Restricted Project
varungandhi-apple updated the summary of D80694: Improve lit.py's usability by highlighting failing lines..
May 28 2020, 12:30 AM ยท Restricted Project
varungandhi-apple created D80694: Improve lit.py's usability by highlighting failing lines..
May 28 2020, 12:30 AM ยท Restricted Project
varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

Consider the test file:

May 28 2020, 12:30 AM ยท Restricted Project

Mar 25 2020

varungandhi-apple abandoned D76756: [arm64e] Upstream signing for coroutine continuations.

Closing. I have a PR up against apple/llvm-project. https://github.com/apple/llvm-project/pull/979

Mar 25 2020, 5:53 PM ยท Restricted Project

Mar 24 2020

varungandhi-apple updated the diff for D76756: [arm64e] Upstream signing for coroutine continuations.
Mar 24 2020, 10:32 PM ยท Restricted Project
varungandhi-apple updated the diff for D76756: [arm64e] Upstream signing for coroutine continuations.
Mar 24 2020, 10:24 PM ยท Restricted Project
varungandhi-apple created D76756: [arm64e] Upstream signing for coroutine continuations.
Mar 24 2020, 9:52 PM ยท Restricted Project

Nov 18 2019

varungandhi-apple updated the diff for D70364: Fix iOSDarwin()'s doc comment..

Addressed John's suggestion to replace OS X -> macOS.

Nov 18 2019, 12:03 PM ยท Restricted Project

Nov 17 2019

varungandhi-apple created D70364: Fix iOSDarwin()'s doc comment..
Nov 17 2019, 1:10 PM ยท Restricted Project