Page MenuHomePhabricator

valentinagiusti (Valentina Giusti)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2016, 5:42 AM (118 w, 4 d)

Recent Activity

Feb 1 2017

valentinagiusti added a comment to D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..

I am not sure what you mean, this is a pluggable command and as such it has to be a dynamic loadable lib.
As for the wrong install name of the binary, I don't think I can fix it from here, the SOVERSION is set by AddLLVM.cmake.
On which platform did you get this issue?

Feb 1 2017, 9:30 AM
valentinagiusti added a comment to D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..

Do you have a better proposal?

Feb 1 2017, 7:49 AM

Jan 31 2017

valentinagiusti committed rL293660: Add a command to access and manipulate the Intel(R) MPX Boundary Tables..
Add a command to access and manipulate the Intel(R) MPX Boundary Tables.
Jan 31 2017, 10:14 AM
valentinagiusti closed D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables. by committing rL293660: Add a command to access and manipulate the Intel(R) MPX Boundary Tables..
Jan 31 2017, 10:14 AM

Jan 26 2017

valentinagiusti updated the diff for D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..

used GetAddress() instead of GetUnsignedIntXX()

Jan 26 2017, 7:44 AM
valentinagiusti added inline comments to D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..
Jan 26 2017, 7:16 AM

Jan 25 2017

valentinagiusti updated the diff for D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..

Applied some of the proposed changes.

Jan 25 2017, 4:54 AM
valentinagiusti added inline comments to D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..
Jan 25 2017, 4:42 AM
valentinagiusti added a comment to D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..

Hi Greg, thanks a lot for your review. I have a question about the API that you proposed, please have a look at the inline comments.

Jan 25 2017, 3:07 AM

Jan 24 2017

valentinagiusti created D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..
Jan 24 2017, 4:47 AM

Nov 28 2016

valentinagiusti accepted D27161: Fix floating point register reads x86_64 linux on targets with no AVX support.

lgtm, thanks!

Nov 28 2016, 7:26 AM

Oct 7 2016

valentinagiusti committed rL283548: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474.
Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474
Oct 7 2016, 10:45 AM
valentinagiusti closed D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474 by committing rL283548: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474.
Oct 7 2016, 10:45 AM
valentinagiusti updated the diff for D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474.

cleaned up code

Oct 7 2016, 4:31 AM
valentinagiusti updated the diff for D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474.

applied clang-format

Oct 7 2016, 4:01 AM
valentinagiusti retitled D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474 from to Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474.
Oct 7 2016, 3:59 AM

Oct 6 2016

valentinagiusti committed rL283474: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel….
Add bound violation handling for Intel(R) Memory Protection Extensions (Intel…
Oct 6 2016, 11:14 AM
valentinagiusti closed D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX) by committing rL283474: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel….
Oct 6 2016, 11:14 AM
valentinagiusti updated the diff for D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX).

fixed usage of llvm:raw_string_ostream

Oct 6 2016, 10:52 AM
valentinagiusti updated the diff for D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX).

used llvm:raw_string_ostream instead of std::stringstream

Oct 6 2016, 9:44 AM
valentinagiusti committed rL283461: Improve test for Intel(R) MPX registers..
Improve test for Intel(R) MPX registers.
Oct 6 2016, 8:58 AM
valentinagiusti closed D25328: Improve test for Intel(R) MPX registers. by committing rL283461: Improve test for Intel(R) MPX registers..
Oct 6 2016, 8:58 AM
valentinagiusti retitled D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX) from to Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX).
Oct 6 2016, 8:30 AM
valentinagiusti added a reviewer for D25328: Improve test for Intel(R) MPX registers.: labath.
Oct 6 2016, 8:28 AM
valentinagiusti retitled D25328: Improve test for Intel(R) MPX registers. from to Improve test for Intel(R) MPX registers..
Oct 6 2016, 8:27 AM
valentinagiusti abandoned D25317: Improve test for Intel(R) MPX registers..
Oct 6 2016, 8:25 AM
valentinagiusti abandoned D25319: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX).
Oct 6 2016, 8:25 AM
valentinagiusti added a reviewer for D25319: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX): emaste.
Oct 6 2016, 6:07 AM
valentinagiusti added reviewers for D25319: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX): labath, clayborg, zturner.
Oct 6 2016, 6:04 AM
valentinagiusti retitled D25319: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX) from to Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX).
Oct 6 2016, 6:03 AM
valentinagiusti added reviewers for D25317: Improve test for Intel(R) MPX registers.: labath, clayborg, zturner.
Oct 6 2016, 5:31 AM
valentinagiusti retitled D25317: Improve test for Intel(R) MPX registers. from to Improve test for Intel(R) MPX registers..
Oct 6 2016, 5:27 AM

Sep 21 2016

valentinagiusti added a comment to D24764: Refactor NativeRegisterContextLinux_x86_64 code..

ok, I will keep it in mind for some further refactoring, thanks!

Sep 21 2016, 6:44 AM
valentinagiusti committed rL282072: Refactor NativeRegisterContextLinux_x86_64 code..
Refactor NativeRegisterContextLinux_x86_64 code.
Sep 21 2016, 6:41 AM
valentinagiusti closed D24764: Refactor NativeRegisterContextLinux_x86_64 code. by committing rL282072: Refactor NativeRegisterContextLinux_x86_64 code..
Sep 21 2016, 6:41 AM
valentinagiusti added a comment to D24764: Refactor NativeRegisterContextLinux_x86_64 code..

Thechnically it's not correct that I am introducing this issue, because the old code already used a cast. It was done in the old and now not existing method "GetFPRType()", long before I introduced the MPX changes, and then I later moved it into HasXSave()/HasXSave() and now with this current refactoring patch I am moving it into IsCPUFeatureAvailable().

Sep 21 2016, 6:20 AM
valentinagiusti added inline comments to D24764: Refactor NativeRegisterContextLinux_x86_64 code..
Sep 21 2016, 4:19 AM
valentinagiusti added inline comments to D24764: Refactor NativeRegisterContextLinux_x86_64 code..
Sep 21 2016, 1:18 AM
valentinagiusti added inline comments to D24764: Refactor NativeRegisterContextLinux_x86_64 code..
Sep 21 2016, 12:56 AM

Sep 20 2016

valentinagiusti updated the diff for D24764: Refactor NativeRegisterContextLinux_x86_64 code..

Removed unnecessary header, corrected switch-case.

Sep 20 2016, 9:50 AM
valentinagiusti added a comment to D24764: Refactor NativeRegisterContextLinux_x86_64 code..

Thanks for your review! Please find my answers inline.

Sep 20 2016, 9:40 AM
valentinagiusti updated D24764: Refactor NativeRegisterContextLinux_x86_64 code..
Sep 20 2016, 7:41 AM
valentinagiusti retitled D24764: Refactor NativeRegisterContextLinux_x86_64 code. from to Refactor NativeRegisterContextLinux_x86_64 code..
Sep 20 2016, 7:37 AM

Sep 14 2016

valentinagiusti committed rL281528: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64..
Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64.
Sep 14 2016, 1:20 PM
valentinagiusti closed D24578: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64. by committing rL281528: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64..
Sep 14 2016, 1:20 PM
valentinagiusti added reviewers for D24578: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64.: zturner, labath, clayborg.
Sep 14 2016, 1:11 PM
valentinagiusti retitled D24578: Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64. from to Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64..
Sep 14 2016, 1:05 PM
valentinagiusti committed rL281507: Use Intel CPU flags to determine target supported features..
Use Intel CPU flags to determine target supported features.
Sep 14 2016, 10:38 AM
valentinagiusti closed D24559: Use Intel CPU flags to determine target supported features. by committing rL281507: Use Intel CPU flags to determine target supported features..
Sep 14 2016, 10:38 AM
valentinagiusti updated the diff for D24559: Use Intel CPU flags to determine target supported features..

moved header to the bottom and moved enum into header file

Sep 14 2016, 9:07 AM
valentinagiusti added a comment to D24559: Use Intel CPU flags to determine target supported features..

This fixes the fact that there is no proper check that the kernel or the hardware are actually supporting either AVX or MPX. Before this patch, the code only relied on a "hack" that checks if it's possible to do a ptrace to retrieve the XSAVE or FXSAVE areas: the assumption was that if XSAVE is there, then there must be also AVX and MPX, which obviously is not the correct thing to do.
The 'cpuid' calls (wrappers for the CPUID instruction) get the info directly from the hardware, and then the ptrace call is made to actually get either FXSAVE or XSAVE. If XSAVE is there, then 'cpuid' is used again to check the hardware for AVX and MPX, and then if this step is also successful, the XSAVE memory region is further checked to verify that the kernel is properly handling these features.
Basically it's both a refactoring and a fix, and it doesn't require a dedicated test: the fact that the current register tests succeed is proof enough.

Sep 14 2016, 8:28 AM
valentinagiusti updated subscribers of D24559: Use Intel CPU flags to determine target supported features..
Sep 14 2016, 6:29 AM
valentinagiusti added reviewers for D24559: Use Intel CPU flags to determine target supported features.: labath, clayborg.
Sep 14 2016, 6:29 AM
valentinagiusti retitled D24559: Use Intel CPU flags to determine target supported features. from to Use Intel CPU flags to determine target supported features..
Sep 14 2016, 6:27 AM

Sep 8 2016

valentinagiusti committed rL280942: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.
Sep 8 2016, 7:25 AM
valentinagiusti closed D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support. by committing rL280942: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 8 2016, 7:25 AM
valentinagiusti added inline comments to D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 8 2016, 7:06 AM
valentinagiusti updated the diff for D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..

Improved MPX test Makefile and removed workaround for unnamed register sets, and rebased according to the new coding style.

Sep 8 2016, 7:04 AM

Sep 7 2016

valentinagiusti added inline comments to D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 7 2016, 7:13 AM
valentinagiusti updated the diff for D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..

Improved TestMPXRegisters.py and Makefile according to review.

Sep 7 2016, 1:00 AM

Sep 6 2016

valentinagiusti added a comment to D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..

Hi, inline there are my other replies.

Sep 6 2016, 9:10 AM
valentinagiusti added a comment to D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support..

Thanks for the review! You can find my replies inline.

Sep 6 2016, 9:00 AM
valentinagiusti added a reviewer for D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.: granata.enrico.
Sep 6 2016, 7:53 AM
valentinagiusti added a reviewer for D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.: labath.
Sep 6 2016, 7:52 AM
valentinagiusti added reviewers for D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.: clayborg, dvlahovski.
Sep 6 2016, 7:37 AM
valentinagiusti retitled D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support. from to Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 6 2016, 7:35 AM

Sep 5 2016

valentinagiusti committed rL280668: Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Intel(R) Memory Protection Extensions (Intel(R) MPX) support.
Sep 5 2016, 10:51 AM
valentinagiusti closed D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. by committing rL280668: Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 5 2016, 10:51 AM

Sep 2 2016

valentinagiusti retitled D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. from Enable eFormatVectorOfUInt64 formatting for registers. to Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 2 2016, 7:02 AM
valentinagiusti removed rL LLVM as the repository for D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 2 2016, 6:55 AM
valentinagiusti updated subscribers of D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support..
Sep 2 2016, 6:50 AM
valentinagiusti set the repository for D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. to rL LLVM.
Sep 2 2016, 6:23 AM
valentinagiusti added a reviewer for D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.: lldb-commits.
Sep 2 2016, 6:22 AM
valentinagiusti added reviewers for D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.: labath, clayborg, granata.enrico.
Sep 2 2016, 6:22 AM
valentinagiusti retitled D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. from to Enable eFormatVectorOfUInt64 formatting for registers..
Sep 2 2016, 6:20 AM