Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

ubsan (Nicole Mazzuca)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Apr 2 2016, 12:44 PM (400 w, 3 d)
Roles
Disabled

Recent Activity

Nov 21 2018

ubsan added a comment to D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

The ABI breakage was already there, in the difference between GCC and Clang

  • if one compiles against libc++ with gcc, it is not compatible with things

that are compiled with clang. I frankly think that being ABI compatible
with gcc (and correct according to the standard) is far more important than
being ABI compatible with previous versions of clang - if people need the
ABI compatibility, they can and should use -fclang-abi-compat

Nov 21 2018, 2:23 PM

Oct 25 2018

ubsan updated the diff for D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

fix nits

Oct 25 2018, 10:04 PM
ubsan added a comment to D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

I don't actually know how to send this upstream, since it's been accepted... How should I proceed?

Oct 25 2018, 10:21 AM

Oct 24 2018

ubsan updated the diff for D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

Add ABI breakage information and reflow

Oct 24 2018, 2:58 PM

Oct 23 2018

ubsan updated the diff for D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

Finish doing the thing! all tests are passing, at least on the revision I'm running on :)

Oct 23 2018, 11:16 PM
ubsan added a comment to D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

... Yup, that'd do it. Thanks Richard!

Oct 23 2018, 8:36 PM
ubsan added a comment to D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

Is it possible you have LLVM and Clang checked out at different revisions? That's a common source of weird behavior, particularly in CodeGen tests.

Oct 23 2018, 8:25 PM

Oct 18 2018

ubsan added a comment to D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

I'm having real difficulty with this - I get really odd errors in seemingly unrelated tests when I change things.

Oct 18 2018, 10:24 AM

Oct 12 2018

ubsan updated the diff for D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.

add tests

Oct 12 2018, 3:22 PM
ubsan created D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment.
Oct 12 2018, 10:08 AM

Apr 5 2016

ubsan updated the diff for D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

Coalesce the checks.

Apr 5 2016, 10:46 PM
ubsan updated the diff for D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

Add checks for the Ret value as well

Apr 5 2016, 8:35 AM

Apr 4 2016

ubsan updated the diff for D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.

Switch to explicit constructor.

Apr 4 2016, 11:47 PM
ubsan added a comment to D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

Can do.

Apr 4 2016, 3:29 PM
ubsan added inline comments to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 4 2016, 3:27 PM
ubsan added a comment to D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

So how this would work is; any additional values would be added after LLVMInstructionValueKind, and if any values are removed, they would be removed in this enum, and the values would have integer values assigned.

Apr 4 2016, 12:43 PM
ubsan updated the diff for D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

Fix deadalnix's problems with the revision.

Apr 4 2016, 11:56 AM
ubsan added inline comments to D18729: [llvm-c] Improve IR Introspection: Add ValueKind.
Apr 4 2016, 11:30 AM
ubsan updated the diff for D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.

Follow deadalnix's suggestions.

Apr 4 2016, 10:14 AM
ubsan added inline comments to D18729: [llvm-c] Improve IR Introspection: Add ValueKind.
Apr 4 2016, 7:32 AM

Apr 3 2016

ubsan updated the diff for D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.

Return a const string instead.

Apr 3 2016, 9:26 PM
ubsan added inline comments to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 7:22 PM
ubsan added inline comments to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 7:21 PM
ubsan updated the diff for D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 4:31 PM
ubsan added inline comments to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 2:59 PM
ubsan added inline comments to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 2:51 PM
ubsan retitled D18729: [llvm-c] Improve IR Introspection: Add ValueKind from [llvm-c] Improve IR Introspection: Add enums to [llvm-c] Improve IR Introspection: Add ValueKind.
Apr 3 2016, 2:50 PM
ubsan added inline comments to D18729: [llvm-c] Improve IR Introspection: Add ValueKind.
Apr 3 2016, 2:49 PM
ubsan added inline comments to D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 3 2016, 2:47 PM

Apr 2 2016

ubsan retitled D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier from to [llvm-c] Improve IR Introspection: Add LLVM{Get,Set}ModuleIdentifier.
Apr 2 2016, 9:49 PM
ubsan updated the diff for D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

Add tests, fix that switch in LLVMGetValueKind

Apr 2 2016, 7:57 PM
ubsan updated the diff for D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

listening to whitequark :P

Apr 2 2016, 2:53 PM
ubsan added a comment to D18729: [llvm-c] Improve IR Introspection: Add ValueKind.

I'm sorry, learning the tools :)

Apr 2 2016, 2:47 PM
ubsan updated the diff for D18729: [llvm-c] Improve IR Introspection: Add ValueKind.
Apr 2 2016, 2:47 PM
ubsan retitled D18729: [llvm-c] Improve IR Introspection: Add ValueKind from to [llvm-c] Improve IR Introspection: Add enums.
Apr 2 2016, 1:12 PM
ubsan abandoned D18728: [llvm-c] Improve IR Introspection.

This was meant to be four diffs; I don't understand the tools fully yet.

Apr 2 2016, 1:05 PM
ubsan updated D18728: [llvm-c] Improve IR Introspection.
Apr 2 2016, 12:58 PM
ubsan retitled D18728: [llvm-c] Improve IR Introspection from to [llvm-c] Improve IR Introspection.
Apr 2 2016, 12:58 PM