Page MenuHomePhabricator

tungld (Tung D. Le)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2020, 10:36 PM (130 w, 2 d)

Recent Activity

Tue, Jun 28

tungld added a comment to D125854: [mlir][normalize-memrefs] Non-normalizable operations with identity map layouts do not block normalization of the entire function.

@bondhugula @avarmapml @imaihal could you please review this patch again? Thanks!

Tue, Jun 28, 9:39 PM · Restricted Project, Restricted Project

May 23 2022

tungld added a comment to D125854: [mlir][normalize-memrefs] Non-normalizable operations with identity map layouts do not block normalization of the entire function.

@bondhugula Is the current change ok? or should I make any other change? Thanks!

May 23 2022, 8:22 PM · Restricted Project, Restricted Project

May 18 2022

tungld added inline comments to D125854: [mlir][normalize-memrefs] Non-normalizable operations with identity map layouts do not block normalization of the entire function.
May 18 2022, 7:28 PM · Restricted Project, Restricted Project
tungld updated the diff for D125854: [mlir][normalize-memrefs] Non-normalizable operations with identity map layouts do not block normalization of the entire function.
  • Use isIdentity() on the layout itself
May 18 2022, 7:21 PM · Restricted Project, Restricted Project

May 17 2022

tungld added reviewers for D125854: [mlir][normalize-memrefs] Non-normalizable operations with identity map layouts do not block normalization of the entire function: avarmapml, bondhugula, imaihal.
May 17 2022, 11:45 PM · Restricted Project, Restricted Project
tungld requested review of D125854: [mlir][normalize-memrefs] Non-normalizable operations with identity map layouts do not block normalization of the entire function.
May 17 2022, 11:37 PM · Restricted Project, Restricted Project

Aug 1 2021

tungld added a comment to D107247: [Z] Fix incomplete_type on ZLinux when compiling RemoteJITUtils.

I don't have. This is my information: "name (email)" : "Tung D. Le (tung@jp.ibm.com)". Thank you!

Aug 1 2021, 7:56 PM · Restricted Project
tungld added reviewers for D107247: [Z] Fix incomplete_type on ZLinux when compiling RemoteJITUtils: sgraenitz, lhames.
Aug 1 2021, 7:46 PM · Restricted Project
tungld retitled D107247: [Z] Fix incomplete_type on ZLinux when compiling RemoteJITUtils from [Z] Fix incomplete_type on ZLinux when compiling RemoteJITUtils When compiling on ZLinux, we got this error: ``` /llvm-project/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h:80:65: required from here... to [Z] Fix incomplete_type on ZLinux when compiling RemoteJITUtils.
Aug 1 2021, 7:42 PM · Restricted Project
tungld requested review of D107247: [Z] Fix incomplete_type on ZLinux when compiling RemoteJITUtils.
Aug 1 2021, 7:39 PM · Restricted Project

Jul 29 2021

tungld updated the diff for D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

Thanks @bondhugula! I changed variable names and comments accoring to your comments.

Jul 29 2021, 6:25 PM · Restricted Project

Jul 28 2021

tungld added a comment to D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

@bondhugula is this patch ok to be landed? Thanks!

Jul 28 2021, 6:09 PM · Restricted Project

Jul 25 2021

tungld added a comment to D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

@bondhugula @vinayaka-polymage is it the current patch good enough? Thanks!

Jul 25 2021, 7:02 PM · Restricted Project

Jul 22 2021

tungld updated the diff for D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

Thanks, @vinayaka-polymage, for your comments! I simplified the lit tests.

Jul 22 2021, 3:53 PM · Restricted Project
tungld added a comment to D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

@vinayaka-polymage I updated the patch according to your comments. Thanks!

Jul 22 2021, 6:45 AM · Restricted Project
tungld updated the summary of D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.
Jul 22 2021, 6:43 AM · Restricted Project
tungld updated the diff for D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

Move the check of AffineIf into LoopNestStateCollector and use 1D tensors in the lit tests.

Jul 22 2021, 6:38 AM · Restricted Project

Jul 21 2021

tungld updated the diff for D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.
Simplify the code according to Uday's comments.
Jul 21 2021, 10:44 PM · Restricted Project

Jul 16 2021

tungld added a comment to D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

@bondhugula I updated the patch to handle only the case that affine.if is inside affine.for. One more test is added for the case where affine.if is sandwiched by the source and dest ops.

Jul 16 2021, 12:59 AM · Restricted Project
tungld updated the diff for D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

Only handle AffineIfOp

Jul 16 2021, 12:49 AM · Restricted Project

Jul 15 2021

tungld added a comment to D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.

Thank you for your comments. I will update the patch to check affine.if only.

Jul 15 2021, 1:55 AM · Restricted Project

Jul 14 2021

tungld added reviewers for D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops: bondhugula, rriddle, dcaballe.
Jul 14 2021, 12:09 AM · Restricted Project
tungld requested review of D105963: [mlir][affine-loop-fusion] Fix a bug that AffineIfOp prevents fusion of the other loops.
Jul 14 2021, 12:04 AM · Restricted Project

Feb 24 2021

tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Just minor comments.

Done. Thanks!

Feb 24 2021, 7:09 PM · Restricted Project
tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Edit lit tests according to @dcaballe's comments.

Feb 24 2021, 7:08 PM · Restricted Project
tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

@dcaballe @bondhugula any further comments? Thanks!

Feb 24 2021, 4:25 PM · Restricted Project
tungld accepted D97347: [mlir] Check 'iter_args' in 'isLoopParallel' utility.

LGTM! Thanks!

Feb 24 2021, 4:18 PM · Restricted Project

Feb 23 2021

tungld added a comment to D97347: [mlir] Check 'iter_args' in 'isLoopParallel' utility.

Hi Diego,

Feb 23 2021, 6:12 PM · Restricted Project
tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

@tungld could you please rebase and fix a conflict due to another revision that updated fusion?

Feb 23 2021, 4:49 PM · Restricted Project
tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Rebase and fix a conflict

Feb 23 2021, 4:47 PM · Restricted Project
tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Hi Uday and Diego,

Feb 23 2021, 4:50 AM · Restricted Project
tungld updated the summary of D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.
Feb 23 2021, 4:39 AM · Restricted Project
tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Edit comments and lit tests

Feb 23 2021, 4:15 AM · Restricted Project

Feb 22 2021

tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

I moved the check of defining ops into getFusedLoopNestInsertionPoint and prevented loop nests with values from being fused. Also added TODO for loop nests with values. Thanks!

Feb 22 2021, 5:24 AM · Restricted Project
tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Move the check into getFusedLoopNestInsertionPoint and prevent fusing loop nests that return values

Feb 22 2021, 5:18 AM · Restricted Project
tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

We should prevent loops with iter_args to be fused

Hi Diego, do you prefer to have it in this patch? I could do it by simply checking the source and dest affine.for, if one of them uses iter_args (or returns a SSA value), we prevent them to be fused.

Feb 22 2021, 12:47 AM · Restricted Project
tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

However, the following code would still fail after the patch, right @tungld?

affine.for %arg2 = 0 to 10 {
  %2 = affine.load %arg1[] : memref<f32>
  affine.store %2, %arg0[%arg2] : memref<10xf32>
}
%0 = affine.load %arg1[] : memref<f32>
%1 = addf %0, %0 : f32
affine.for %arg2 = 0 to 10 {
  %2 = affine.load %arg0[%arg2] : memref<10xf32>
  %3 = divf %1, %2 : f32
}

It worked because we had load in the first loop which has no write-read dependence to %0 = affine.load %arg1[] : memref<f32>. I got this output using this patch:

%0 = affine.load %arg1[] : memref<f32>
%1 = addf %0, %0 : f32
affine.for %arg2 = 0 to 10 {
  %2 = affine.load %arg1[] : memref<f32>
  affine.store %2, %arg0[%arg2] : memref<10xf32>
  %3 = affine.load %arg0[%arg2] : memref<10xf32>
  %4 = divf %1, %3 : f32
}
Feb 22 2021, 12:30 AM · Restricted Project

Feb 21 2021

tungld added a comment to D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Thanks for your comments! I just updated the patch.

Feb 21 2021, 5:49 PM · Restricted Project
tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Reflect reviewers' comments

Feb 21 2021, 5:25 PM · Restricted Project

Feb 19 2021

tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Check causal dependence

Feb 19 2021, 5:07 AM · Restricted Project
tungld updated the summary of D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.
Feb 19 2021, 1:15 AM · Restricted Project
tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Clean the code

Feb 19 2021, 1:08 AM · Restricted Project

Feb 18 2021

tungld updated the diff for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.

Remove a redundant method

Feb 18 2021, 10:58 PM · Restricted Project
tungld updated the summary of D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.
Feb 18 2021, 9:03 PM · Restricted Project
tungld added reviewers for D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops: dcaballe, andydavis1.
Feb 18 2021, 9:03 PM · Restricted Project
tungld requested review of D97030: [MLIR][affine-loop-fusion] Handle defining ops between the source and dest loops.
Feb 18 2021, 8:55 PM · Restricted Project

Feb 5 2021

tungld added a comment to D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.

Thank you! Please help me to land it. My "name (email)" : "Tung D. Le (tung@jp.ibm.com)".

Feb 5 2021, 3:16 AM · Restricted Project

Feb 4 2021

tungld added inline comments to D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.
Feb 4 2021, 5:09 PM · Restricted Project

Feb 2 2021

tungld added a comment to D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.

@bondhugula any additional modification needed? thanks!

Feb 2 2021, 7:20 PM · Restricted Project

Feb 1 2021

tungld updated the diff for D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.

Change the lit test name

Feb 1 2021, 12:56 AM · Restricted Project

Jan 31 2021

tungld updated the diff for D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.

Readd the lit test into the new revision

Jan 31 2021, 10:15 PM · Restricted Project
tungld added a comment to D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.

@bondhugula Thank you for your comments! I updated the patch.

Jan 31 2021, 5:59 PM · Restricted Project
tungld updated the diff for D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.

Use MemWrite side effect to precisely capture the situation.

Jan 31 2021, 5:53 PM · Restricted Project

Jan 29 2021

tungld added a reviewer for D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion: bondhugula.
Jan 29 2021, 11:06 PM · Restricted Project

Jan 28 2021

tungld retitled D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion from This patch fixes the following bug when calling --affine-loop-fusion to [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.
Jan 28 2021, 11:23 PM · Restricted Project
tungld requested review of D95668: [MLIR] [affine-loop-fusion] Fix a bug about non-result ops in affine-loop-fusion.
Jan 28 2021, 11:21 PM · Restricted Project

Jun 24 2020

tungld added a comment to D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.

Could you let me know what "name <email>" info you want on the commit?

Please use "Tung D. Le <tung@jp.ibm.com>". Thanks!

Jun 24 2020, 5:56 PM · Restricted Project

Jun 23 2020

tungld added a comment to D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.

@bondhugula it seems I don't have permission to push a commit. Could you please help me to land this patch? Many thanks!

Jun 23 2020, 9:35 PM · Restricted Project
tungld updated the diff for D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.

Thanks Uday! I updated the code based on your comments.

Jun 23 2020, 6:21 PM · Restricted Project

Jun 21 2020

tungld updated the diff for D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.

Add unit tests.

Jun 21 2020, 10:13 PM · Restricted Project
tungld added a comment to D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.

@bondhugula Thank you for your comments! I updated the code based on your comments.

Jun 21 2020, 8:06 PM · Restricted Project
tungld updated the diff for D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.

Update the code according to Uday Bondhugula's comments.

Jun 21 2020, 7:41 PM · Restricted Project

Jun 19 2020

tungld updated the diff for D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.

Add missing changes for mlir/lib/Transforms/LoopFusion.cpp

Jun 19 2020, 2:07 AM · Restricted Project
tungld created D82158: [MLIR][Affine-loop-fusion] Fix a bug in affine-loop-fusion pass when there are non-affine operations.
Jun 19 2020, 1:34 AM · Restricted Project