Page MenuHomePhabricator

tomcherry (Tom)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2017, 1:11 PM (127 w, 2 d)

Recent Activity

Tue, Aug 13

tomcherry added inline comments to D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.
Tue, Aug 13, 4:21 PM
tomcherry updated the diff for D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

Add __safe_nanosecond_cast

Tue, Aug 13, 4:16 PM

Mon, Aug 12

tomcherry added a comment to D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

I simplified the code a bit more and responded to the comments. I haven't had a good chance to test this yet, but pushing early for feedback.

Mon, Aug 12, 4:28 PM
tomcherry updated the diff for D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

Responding to review comments

Mon, Aug 12, 4:28 PM

Fri, Jul 26

tomcherry added a comment to D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

So, to make sure I understand, this patch uses something that is *not yet* in POSIX, it's only proposed, correct?

Fri, Jul 26, 12:23 PM
tomcherry updated the diff for D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

Clarify that pthread_cond_clockwait() is only proposed to POSIX.
Remove enable_if.

Fri, Jul 26, 12:17 PM
tomcherry added reviewers for D65339: Implement std::condition_variable via pthread_cond_clockwait() where available: mclow.lists, EricWF, danalbert, srhines.
Fri, Jul 26, 10:28 AM
tomcherry abandoned D44945: Always have std::condition_variable wait on CLOCK_MONOTONIC on Android.

See https://reviews.llvm.org/D65339

Fri, Jul 26, 10:25 AM
tomcherry abandoned D36767: Implement the standard for timeouts for std::condition_variable.

See https://reviews.llvm.org/D65339

Fri, Jul 26, 10:25 AM
tomcherry created D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.
Fri, Jul 26, 10:25 AM

Mar 28 2018

tomcherry updated the diff for D44945: Always have std::condition_variable wait on CLOCK_MONOTONIC on Android.

Update commit message

Mar 28 2018, 10:56 AM

Mar 27 2018

tomcherry added a comment to D44945: Always have std::condition_variable wait on CLOCK_MONOTONIC on Android.

Thanks for the comments. I'm very open to suggestions if you have any better way of doing this.

Mar 27 2018, 2:02 PM
tomcherry added reviewers for D44945: Always have std::condition_variable wait on CLOCK_MONOTONIC on Android: mclow.lists, EricWF, danalbert, rprichard.
Mar 27 2018, 12:05 PM
tomcherry created D44945: Always have std::condition_variable wait on CLOCK_MONOTONIC on Android.
Mar 27 2018, 12:05 PM

Aug 15 2017

tomcherry added a comment to D36767: Implement the standard for timeouts for std::condition_variable.

This is mostly an RFC. The underlying issue is that we cannot use timed waits based on CLOCK_REALTIME on Android. In trying to fix that, I figured I might as well try implementing the standard as described, though I understand that there'd be resistance to such a re-implementation.

Aug 15 2017, 2:17 PM
tomcherry created D36767: Implement the standard for timeouts for std::condition_variable.
Aug 15 2017, 2:12 PM

Mar 8 2017

tomcherry added a comment to D30764: Disable unsigned integer sanitizer for basic_string::replace().

I don't have commit access, so please commit for me.

Mar 8 2017, 5:12 PM
tomcherry updated the diff for D30764: Disable unsigned integer sanitizer for basic_string::replace().

Moved comments to an appropriate line

Mar 8 2017, 4:49 PM
tomcherry updated the summary of D30764: Disable unsigned integer sanitizer for basic_string::replace().
Mar 8 2017, 4:03 PM
tomcherry added reviewers for D30764: Disable unsigned integer sanitizer for basic_string::replace(): mclow.lists, EricWF.
Mar 8 2017, 3:38 PM
tomcherry created D30764: Disable unsigned integer sanitizer for basic_string::replace().
Mar 8 2017, 3:37 PM