Page MenuHomePhabricator

tomasz-kaminski-sonarsource (Tomasz Kamiński)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2021, 2:39 AM (9 w, 5 d)

Recent Activity

Yesterday

tomasz-kaminski-sonarsource added inline comments to D106131: Fix FindZ3.cmake to support static libraries and Windows.
Mon, Jul 26, 1:07 AM · Restricted Project

Thu, Jul 22

tomasz-kaminski-sonarsource added a comment to D106131: Fix FindZ3.cmake to support static libraries and Windows.

Any input on the change?

Thu, Jul 22, 3:34 AM · Restricted Project

Fri, Jul 16

tomasz-kaminski-sonarsource updated the summary of D106131: Fix FindZ3.cmake to support static libraries and Windows.
Fri, Jul 16, 3:12 AM · Restricted Project
tomasz-kaminski-sonarsource updated the summary of D106131: Fix FindZ3.cmake to support static libraries and Windows.
Fri, Jul 16, 3:12 AM · Restricted Project
tomasz-kaminski-sonarsource updated the diff for D106131: Fix FindZ3.cmake to support static libraries and Windows.

Removed uncessary debug message.

Fri, Jul 16, 12:32 AM · Restricted Project
tomasz-kaminski-sonarsource updated the summary of D106131: Fix FindZ3.cmake to support static libraries and Windows.
Fri, Jul 16, 12:22 AM · Restricted Project
tomasz-kaminski-sonarsource requested review of D106131: Fix FindZ3.cmake to support static libraries and Windows.
Fri, Jul 16, 12:20 AM · Restricted Project

Mon, Jul 12

tomasz-kaminski-sonarsource added a comment to D80227: Fix FindZ3.cmake to work with static Z3 libraries.

Other (unrelated issue) in the file: The cross compilation version of section mode, refers to BUILD_VERSION instead of BUILD_NUMBER:

   file(STRINGS "${Z3_INCLUDE_DIR}/z3_version.h"
        z3_version_str REGEX "^#define[\t ]+Z3_BUILD_NUMBER[\t ]+.*")
-       string(REGEX REPLACE "^.*Z3_BUILD_VERSION[\t ]+([0-9]).*$" "\\1"
+       string(REGEX REPLACE "^.*Z3_BUILD_NUMBER[\t ]+([0-9]).*$" "\\1"
         Z3_BUILD "${z3_version_str}")
Mon, Jul 12, 11:43 PM · Restricted Project, Restricted Project
tomasz-kaminski-sonarsource added a comment to D80227: Fix FindZ3.cmake to work with static Z3 libraries.

In my case, the issue with file(WRITE race occurs only if the find_package(THREAD) is invoked afterwards. Rearanging the function as follows eliminates the issue for me:

Mon, Jul 12, 11:41 PM · Restricted Project, Restricted Project

Jun 18 2021

tomasz-kaminski-sonarsource added a comment to D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl() .

For the author information use:
Tomasz Kamiński
tomasz.kaminski@sonarsource.com

Jun 18 2021, 6:03 AM · Restricted Project
tomasz-kaminski-sonarsource added a comment to D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl() .

Would it be possible to merge it for me, as I do not have a commit right?

Jun 18 2021, 2:22 AM · Restricted Project
tomasz-kaminski-sonarsource added a comment to D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl() .

Any input on the change?

Jun 18 2021, 1:49 AM · Restricted Project

Jun 1 2021

tomasz-kaminski-sonarsource added a comment to D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl() .

Ping,

Jun 1 2021, 12:21 AM · Restricted Project

May 24 2021

tomasz-kaminski-sonarsource added a comment to D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl() .

The alternative solution, that I think may be preferable is to remove following functions from CheckerContext and use CallEvent.getDecl() instead:

const FunctionDecl *getCalleeDecl(const CallExpr *CE) const;
const IdentifierInfo *getCalleeIdentifier(const CallExpr *CE) const;
StringRef getCalleeName(const CallExpr *CE) const;
May 24 2021, 7:06 AM · Restricted Project
tomasz-kaminski-sonarsource requested review of D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl() .
May 24 2021, 7:04 AM · Restricted Project

May 21 2021

tomasz-kaminski-sonarsource added a comment to D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.

I do not have commit rights. If there are no additional changes needed, would it be possible to you to commit the changes on my behalf?

May 21 2021, 8:03 AM · Restricted Project

May 20 2021

tomasz-kaminski-sonarsource updated the diff for D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.

Adjusted Clang.Analysis::NewDelete-path-notes.cpp.plist for removed lines.

May 20 2021, 5:54 AM · Restricted Project
tomasz-kaminski-sonarsource added inline comments to D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.
May 20 2021, 5:01 AM · Restricted Project
tomasz-kaminski-sonarsource updated the diff for D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.

Removed duplicated runs that were only differing by specifying c++-allocator-inlinging=true, which is the default value.

May 20 2021, 4:59 AM · Restricted Project
tomasz-kaminski-sonarsource added inline comments to D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.
May 20 2021, 4:55 AM · Restricted Project
tomasz-kaminski-sonarsource updated the diff for D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.

Added // no warn comment to line that was raising warning before the fix.

May 20 2021, 3:28 AM · Restricted Project
tomasz-kaminski-sonarsource requested review of D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.
May 20 2021, 2:49 AM · Restricted Project